* [PATCH wireguard-go] conn: linux: fix incorrect endpoint address
@ 2021-11-23 19:03 Thomas Renoth
2021-11-23 21:01 ` Jason A. Donenfeld
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Renoth @ 2021-11-23 19:03 UTC (permalink / raw)
To: wireguard; +Cc: Thomas Renoth
Signed-off-by: Thomas Renoth <minus@mnus.de>
---
`wg show` just shows 0.0.0.0:<port> for peer endpoints currently.
conn/bind_linux.go | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/conn/bind_linux.go b/conn/bind_linux.go
index 975a6ab..da0670a 100644
--- a/conn/bind_linux.go
+++ b/conn/bind_linux.go
@@ -275,7 +275,7 @@ func (end *LinuxSocketEndpoint) SrcIP() netip.Addr {
func (end *LinuxSocketEndpoint) DstIP() netip.Addr {
if !end.isV6 {
- return netip.AddrFrom4(end.src4().Src)
+ return netip.AddrFrom4(end.dst4().Addr)
} else {
return netip.AddrFrom16(end.dst6().Addr)
}
--
2.34.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH wireguard-go] conn: linux: fix incorrect endpoint address
2021-11-23 19:03 [PATCH wireguard-go] conn: linux: fix incorrect endpoint address Thomas Renoth
@ 2021-11-23 21:01 ` Jason A. Donenfeld
2021-11-23 23:23 ` minus
0 siblings, 1 reply; 6+ messages in thread
From: Jason A. Donenfeld @ 2021-11-23 21:01 UTC (permalink / raw)
To: Thomas Renoth; +Cc: WireGuard mailing list
Thank you for catching this regression!
Jason
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH wireguard-go] conn: linux: fix incorrect endpoint address
2021-11-23 21:01 ` Jason A. Donenfeld
@ 2021-11-23 23:23 ` minus
2021-11-25 16:38 ` Jason A. Donenfeld
0 siblings, 1 reply; 6+ messages in thread
From: minus @ 2021-11-23 23:23 UTC (permalink / raw)
To: Jason A. Donenfeld; +Cc: WireGuard mailing list
On 23/11/2021 22.01, Jason A. Donenfeld wrote:
> Thank you for catching this regression!You're welcome. Unfortunately, I found another one: On an old Debian 8
system, wireguard-go does not receive or send packets anymore, nor does
`wg show` show any sent/received stats. On a current Arch system it
works fine. git bisect points to e3134bf (device: defer state machine
transitions until configuration is complete) as first bad commit. I
haven't further tried reproducing it, hoping that it's something obvious
to you.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH wireguard-go] conn: linux: fix incorrect endpoint address
2021-11-23 23:23 ` minus
@ 2021-11-25 16:38 ` Jason A. Donenfeld
2021-11-29 0:24 ` wireguard-go fails to send/receive data minus
0 siblings, 1 reply; 6+ messages in thread
From: Jason A. Donenfeld @ 2021-11-25 16:38 UTC (permalink / raw)
To: minus; +Cc: WireGuard mailing list
Hey Minus,
I'm not seeing what could be causing this. Could you triple check that
it really is busted on Debian 8?
Jason
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: wireguard-go fails to send/receive data
2021-11-25 16:38 ` Jason A. Donenfeld
@ 2021-11-29 0:24 ` minus
2021-11-29 17:34 ` Jason A. Donenfeld
0 siblings, 1 reply; 6+ messages in thread
From: minus @ 2021-11-29 0:24 UTC (permalink / raw)
To: Jason A. Donenfeld; +Cc: WireGuard mailing list
[-- Attachment #1: Type: text/plain, Size: 485 bytes --]
Hi Jason,
> I'm not seeing what could be causing this. Could you triple check that
> it really is busted on Debian 8?
I was mistaken, it has nothing to do with Debian 8 specifically. I could
reproduce it on Arch as well.
When you bring up an interface via wireguard-go and start pinging
there's a big chance that nothing at all will work starting with commit
e3134bf6. I've attached a script to reproduce the problem. It doesn't
always fail, so you may have to run it a few times.
[-- Attachment #2: repro.sh --]
[-- Type: application/x-shellscript, Size: 810 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: wireguard-go fails to send/receive data
2021-11-29 0:24 ` wireguard-go fails to send/receive data minus
@ 2021-11-29 17:34 ` Jason A. Donenfeld
0 siblings, 0 replies; 6+ messages in thread
From: Jason A. Donenfeld @ 2021-11-29 17:34 UTC (permalink / raw)
To: minus; +Cc: WireGuard mailing list
Thanks for the script and the report
https://git.zx2c4.com/wireguard-go/commit/?id=2dd424e2d808703339688ff78e32ed30cd0dfe87
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-11-29 17:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-23 19:03 [PATCH wireguard-go] conn: linux: fix incorrect endpoint address Thomas Renoth
2021-11-23 21:01 ` Jason A. Donenfeld
2021-11-23 23:23 ` minus
2021-11-25 16:38 ` Jason A. Donenfeld
2021-11-29 0:24 ` wireguard-go fails to send/receive data minus
2021-11-29 17:34 ` Jason A. Donenfeld
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).