Missing <asm/neon.h> with 0.0.20180904 on arm with kernel 3.10.107

Missing <asm/neon.h> with 0.0.20180904 on arm with kernel 3.10.107

[Philipp Richter]

[-- Attachment #1: Type: text/plain, Size: 3096 bytes --]

Hello,

while trying to install the new wireguard snapshot 0.0.20180904, I got an
error about missing <arm/neon.h> on my odroid-c1 running ArchLinux ARM

DKMS make.log for wireguard-0.0.20180904 for kernel 3.10.107-2-ARCH
(armv7l)
Thu Sep  6 22:45:48 CEST 2018
make: Entering directory '/usr/src/linux-3.10.107-2-ARCH'
 LD      /var/lib/dkms/wireguard/0.0.20180904/build/built-in.o
 CC [M]  /var/lib/dkms/wireguard/0.0.20180904/build/main.o
 CC [M]  /var/lib/dkms/wireguard/0.0.20180904/build/device.o
 CC [M]  /var/lib/dkms/wireguard/0.0.20180904/build/noise.o
 CC [M]  /var/lib/dkms/wireguard/0.0.20180904/build/peer.o
 CC [M]  /var/lib/dkms/wireguard/0.0.20180904/build/timers.o
 CC [M]  /var/lib/dkms/wireguard/0.0.20180904/build/queueing.o
 CC [M]  /var/lib/dkms/wireguard/0.0.20180904/build/send.o
 CC [M]  /var/lib/dkms/wireguard/0.0.20180904/build/receive.o
 CC [M]  /var/lib/dkms/wireguard/0.0.20180904/build/socket.o
 CC [M]  /var/lib/dkms/wireguard/0.0.20180904/build/hashtables.o
 CC [M]  /var/lib/dkms/wireguard/0.0.20180904/build/allowedips.o
 CC [M]  /var/lib/dkms/wireguard/0.0.20180904/build/ratelimiter.o
 CC [M]  /var/lib/dkms/wireguard/0.0.20180904/build/cookie.o
 CC [M]  /var/lib/dkms/wireguard/0.0.20180904/build/netlink.o
 CC [M]
 /var/lib/dkms/wireguard/0.0.20180904/build/crypto/zinc/chacha20/chacha20.o
 AS [M]
 /var/lib/dkms/wireguard/0.0.20180904/build/crypto/zinc/chacha20/chacha20-arm.o

 CC [M]
 /var/lib/dkms/wireguard/0.0.20180904/build/crypto/zinc/poly1305/poly1305.o
 AS [M]
 /var/lib/dkms/wireguard/0.0.20180904/build/crypto/zinc/poly1305/poly1305-arm.o

 CC [M]
 /var/lib/dkms/wireguard/0.0.20180904/build/crypto/zinc/chacha20poly1305.o
 CC [M]
 /var/lib/dkms/wireguard/0.0.20180904/build/crypto/zinc/curve25519/curve25519.o

In file included from <command-line>:
/var/lib/dkms/wireguard/0.0.20180904/build/crypto/zinc/chacha20/chacha20-arm-glue.h:8:10:
fatal error: asm/neon.h: No such file or directory
#include <asm/neon.h>
         ^~~~~~~~~~~~
compilation terminated.
make[1]: *** [scripts/Makefile.build:308:
/var/lib/dkms/wireguard/0.0.20180904/build/crypto/zinc/chacha20/chacha20.o]
Error 1
make[1]: *** Waiting for unfinished jobs....
In file included from <command-line>:
/var/lib/dkms/wireguard/0.0.20180904/build/crypto/zinc/poly1305/poly1305-arm-glue.h:8:10:
fatal error: asm/neon.h: No such file or directory
#include <asm/neon.h>
         ^~~~~~~~~~~~
compilation terminated.
make[1]: *** [scripts/Makefile.build:308:
/var/lib/dkms/wireguard/0.0.20180904/build/crypto/zinc/poly1305/poly1305.o]
Error 1
make: *** [Makefile:1233:
_module_/var/lib/dkms/wireguard/0.0.20180904/build] Error 2
make: Leaving directory '/usr/src/linux-3.10.107-2-ARCH'

Unfortunately I'm stuck with 3.10.107 on my odroid-c1 :'-( , sources can be
found here : https://github.com/hardkernel/linux/tree/odroidc-3.10.y

Wireguard has been working great so far, going back to 0.0.20180809 yields
a successful compilation.

Best Regards,
Philipp Richter

*Fingerprint* : *452F 7EBD 2716 B179 5E3E  A2CB AE2B 7FFA CA43 4586*
*PGP Public Key* <https://u.teknik.io/ytoEw.asc>

[-- Attachment #2: Type: text/html, Size: 4246 bytes --]

Re: Missing <asm/neon.h> with 0.0.20180904 on arm with kernel 3.10.107

[Jason A. Donenfeld]

Hi Philipp,

Thanks for the report. Can you tell me if this fixes it for you?

https://git.zx2c4.com/WireGuard/commit/?id=dcb765a453fa22e4195bc42de1792567fe511c67

Jason

Re: Missing <asm/neon.h> with 0.0.20180904 on arm with kernel 3.10.107

[Philipp Richter]

[-- Attachment #1: Type: text/plain, Size: 843 bytes --]

Hello Jason,

yes this works indeed thank you!

This means however that NEON SIMD instructions are not used, right ? The
datasheet of the board mentions that it includes the NEON SIMD coprocessor
: https://dn.odroid.com/S805/Datasheet/S805_Datasheet%20V0.8%2020150126.pdf

And CONFIG_NEON=y is activated in the kernel. Forgive me, I don't know much
about what it means for the wireguard module not using the neon simd
instructions.

Best Regards,
Philipp Richter

*Fingerprint* : *452F 7EBD 2716 B179 5E3E  A2CB AE2B 7FFA CA43 4586*
*PGP Public Key* <https://u.teknik.io/ytoEw.asc>


On Fri, 7 Sep 2018 at 04:47, Jason A. Donenfeld <Jason@zx2c4.com> wrote:

> Hi Philipp,
>
> Thanks for the report. Can you tell me if this fixes it for you?
>
>
> https://git.zx2c4.com/WireGuard/commit/?id=dcb765a453fa22e4195bc42de1792567fe511c67
>
> Jason
>

[-- Attachment #2: Type: text/html, Size: 1820 bytes --]

Re: Missing <asm/neon.h> with 0.0.20180904 on arm with kernel 3.10.107

[Jason A. Donenfeld]

Hi Philipp,

Super ancient kernels like that cannot use Neon in kernel space.

Jason

Re: Missing <asm/neon.h> with 0.0.20180904 on arm with kernel 3.10.107

[Philipp Richter]

[-- Attachment #1: Type: text/plain, Size: 433 bytes --]

Ah ok, I see. Thank you again :)
I hope some day all the necessary parts to make the board work will get
upstreamed.

Regards,
Philipp Richter

*Fingerprint* : *452F 7EBD 2716 B179 5E3E  A2CB AE2B 7FFA CA43 4586*
*PGP Public Key* <https://u.teknik.io/ytoEw.asc>


On Fri, 7 Sep 2018 at 16:22, Jason A. Donenfeld <Jason@zx2c4.com> wrote:

> Hi Philipp,
>
> Super ancient kernels like that cannot use Neon in kernel space.
>
> Jason
>

[-- Attachment #2: Type: text/html, Size: 1085 bytes --]