wireguard.lists.zx2c4.com archive mirror
 help / color / mirror / Atom feed
* [ANNOUNCE] WireGuard Snapshot `0.0.20191205` Available
@ 2019-12-05 10:55 Jason A. Donenfeld
  2019-12-06 15:10 ` Jordan Glover
  0 siblings, 1 reply; 10+ messages in thread
From: Jason A. Donenfeld @ 2019-12-05 10:55 UTC (permalink / raw)
  To: WireGuard mailing list

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hello,

A new snapshot, `0.0.20191205`, has been tagged in the git repository.

Please note that this snapshot is a snapshot rather than a final
release that is considered secure and bug-free. WireGuard is generally
thought to be fairly stable, and most likely will not crash your
computer (though it may).  However, as this is a snapshot, it comes
with no guarantees; it is not applicable for CVEs.

With all that said, if you'd like to test this snapshot out, there are a
few relevant changes.

== Changes ==

  * wg-quick: linux: suppress error when finding unused table
  
  This fixes a spurious warning messages seen with recent versions of iproute2
  and kernels.
  
  * wg-quick: linux: ensure postdown hooks execute
  * wg-quick: linux: have remove_iptables return true
  * wg-quick: linux: iptables-* -w is not widely supported
  
  Adding in iptables had some hiccups. For the record, I'm very unhappy about
  having to put any firewalling code into wg-quick(8). We'll of course need to
  support nftables too at some point if this continues. I'm investigating with
  upstream the possibility of adding a sysctl to patch the issue that iptables
  is handling now, so hopefully at somepoint down the line we'll be able to shed
  this dependency once again.
  
  * send: use kfree_skb_list
  * device: prepare skb_list_walk_safe for upstreaming
  * send: avoid touching skb->{next,prev} directly
  
  Suggestions from LKML.
  
  * ipc: make sure userspace communication frees wgdevice
  
  Free things properly on error paths.

This snapshot contains commits from: Jason A. Donenfeld.

As always, the source is available at https://git.zx2c4.com/WireGuard/ and
information about the project is available at https://www.wireguard.com/ .

This snapshot is available in compressed tarball form here:
  https://git.zx2c4.com/WireGuard/snapshot/WireGuard-0.0.20191205.tar.xz
  SHA2-256: 
  BLAKE2b-256: 

A PGP signature of that file decompressed is available here:
  https://git.zx2c4.com/WireGuard/snapshot/WireGuard-0.0.20191205.tar.asc
  Signing key: AB9942E6D4A4CFC3412620A749FC7012A5DE03AE

If you're a snapshot package maintainer, please bump your package version. If
you're a user, the WireGuard team welcomes any and all feedback on this latest
snapshot.

Finally, WireGuard development thrives on donations. By popular demand, we
have a webpage for this: https://www.wireguard.com/donations/

Thank you,
Jason Donenfeld


-----BEGIN PGP SIGNATURE-----

iQJEBAEBCAAuFiEEq5lC5tSkz8NBJiCnSfxwEqXeA64FAl3o4hYQHGphc29uQHp4
MmM0LmNvbQAKCRBJ/HASpd4DrrDBEADQmcpc3SnrfeULKtV3IBeFti9t2H5GejG2
t8/9ekTEAEVRvKIklrltoFZ5gof02BPPuLC0zB0N9UbtRxWdedgYDRjlXPvrkMZd
lvdul+AEOsrj8yySNCNnBWDrUZ8njxWLAMQW4zJI0681yXbjm7ZV6gazeQ89bPei
cYpfgoAlHyVSyT+XeGWtiVoUbGZtK1ocj04bcEAfsF3DFRLKSADR9VzXOId5zNXQ
LMN3vJ0ZGXQey6hDOdbJ1JzwChSDYZGNYE1xtrNLIgx3uZgiNSfjKmPY9XUEc669
NIJc0TBcSlF8HODfUyeMEGhqoLoTz3bZp4ld6jN+5pJ35bd6lDktZM2sbclBTQOm
XeapJ2A5M1hfk74xRMdoZbQpA39idLbUp4INDqYLW+o0lZRRQocEUNw/4uDR0GA9
zOo4nfrMRz4shTgVTbW1So8O+N3aGqQ8n1P7FLHs3CmZmQut37fdIBJkhVSFnBmA
00xNdHYl5JplAWiF4qfKsly+wGGgBeKnWHTunJZ82j8lfqtPL+h5av82Qe1gpDBA
A/MoxyCWH5HedSqBYTNr+xVKuoIBITypCqjyuXlaOaOwSa0T0SjgP2ZjPbYliGZB
xjcgMaWZUKay0pGl1HjpADJ7Bk4llrCHegPFQ13fS3EibzE/BU79zsWT7mqjvJFT
/CK+hrQwRw==
=S8Aq
-----END PGP SIGNATURE-----
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [ANNOUNCE] WireGuard Snapshot `0.0.20191205` Available
  2019-12-05 10:55 [ANNOUNCE] WireGuard Snapshot `0.0.20191205` Available Jason A. Donenfeld
@ 2019-12-06 15:10 ` Jordan Glover
  2019-12-06 15:20   ` Jason A. Donenfeld
  0 siblings, 1 reply; 10+ messages in thread
From: Jordan Glover @ 2019-12-06 15:10 UTC (permalink / raw)
  To: Jason A. Donenfeld; +Cc: WireGuard mailing list

On Thursday, December 5, 2019 10:55 AM, Jason A. Donenfeld <Jason@zx2c4.com> wrote:

> Hello,
>
> A new snapshot, `0.0.20191205`, has been tagged in the git repository.
>
> Please note that this snapshot is a snapshot rather than a final
> release that is considered secure and bug-free. WireGuard is generally
> thought to be fairly stable, and most likely will not crash your
> computer (though it may). However, as this is a snapshot, it comes
> with no guarantees; it is not applicable for CVEs.
>
> With all that said, if you'd like to test this snapshot out, there are a
> few relevant changes.
>
> == Changes ==
>
> -   wg-quick: linux: suppress error when finding unused table
>
>     This fixes a spurious warning messages seen with recent versions of iproute2
>     and kernels.
>
> -   wg-quick: linux: ensure postdown hooks execute
> -   wg-quick: linux: have remove_iptables return true
> -   wg-quick: linux: iptables-* -w is not widely supported
>
>     Adding in iptables had some hiccups. For the record, I'm very unhappy about
>     having to put any firewalling code into wg-quick(8). We'll of course need to
>     support nftables too at some point if this continues. I'm investigating with
>     upstream the possibility of adding a sysctl to patch the issue that iptables
>     is handling now, so hopefully at somepoint down the line we'll be able to shed
>     this dependency once again.
>
> -   send: use kfree_skb_list
> -   device: prepare skb_list_walk_safe for upstreaming
> -   send: avoid touching skb->{next,prev} directly
>
> Suggestions from LKML.
>
> -   ipc: make sure userspace communication frees wgdevice
>
>     Free things properly on error paths.
>
>     This snapshot contains commits from: Jason A. Donenfeld.
>
>     As always, the source is available at https://git.zx2c4.com/WireGuard/ and
>     information about the project is available at https://www.wireguard.com/ .
>
>     This snapshot is available in compressed tarball form here:
>     https://git.zx2c4.com/WireGuard/snapshot/WireGuard-0.0.20191205.tar.xz
>     SHA2-256:
>     BLAKE2b-256:
>
>     A PGP signature of that file decompressed is available here:
>     https://git.zx2c4.com/WireGuard/snapshot/WireGuard-0.0.20191205.tar.asc
>     Signing key: AB9942E6D4A4CFC3412620A749FC7012A5DE03AE
>
>     If you're a snapshot package maintainer, please bump your package version. If
>     you're a user, the WireGuard team welcomes any and all feedback on this latest
>     snapshot.
>
>     Finally, WireGuard development thrives on donations. By popular demand, we
>     have a webpage for this: https://www.wireguard.com/donations/
>
>     Thank you,
>     Jason Donenfeld
>

Hi, this release cause coredump on wg-quick down action:

systemd[1]: Stopping WireGuard via wg-quick(8) for wg0...
wg-quick[2241]: [#] iptables -D OUTPUT -o wg0 -j ACCEPT
wg-quick[2241]: [#] ip -4 rule delete table 51820
wg-quick[2241]: [#] ip -4 rule delete table main suppress_prefixlength 0
wg-quick[2257]: RTNETLINK answers: Address family not supported by protocol
wg-quick[2257]: Dump terminated
wg-quick[2258]: RTNETLINK answers: Address family not supported by protocol
wg-quick[2258]: Dump terminated
wg-quick[2241]: [#] ip link delete dev wg0
wg-quick[2241]: [#] resolvconf -d wg0 -f
wg-quick[2315]: [#] iptables-restore -n
audit[2316]: ANOM_ABEND auid=4294967295 uid=0 gid=0 ses=4294967295 subj==unconfined pid=2316 comm="iptables-restor" exe="/usr/bin/xtables-nft-multi" sig=11 res=1
wg-quick[2315]: /usr/bin/wg-quick: line 29:  2316 Segmentation fault      (core dumped) "$@"
kernel: show_signal_msg: 40 callbacks suppressed
kernel: iptables-restor[2316]: segfault at 0 ip 000064515b66fcc9 sp 00007e6bbcbfb720 error 4 in libnftnl.so.11.2.0[64515b66d000+18000]
kernel: Code: 15 5c 20 02 00 48 85 c0 74 07 48 89 00 48 89 40 08 48 83 c4 08 c3 66 66 2e 0f 1f 84 00 00 00 00 00 55 48 89 fd 53 48 83 ec 08 <48> 8b 3f 48 8b 1f 48 39 fd 74 2f 0f 1f 40 00 48 8b 47 08 48 89 43
systemd[1]: wg-quick@wg0.service: Succeeded.
systemd[1]: Stopped WireGuard via wg-quick(8) for wg0.

I saw some iptables related fix in git[1] but I don't know if
it's related to similar issue.

[1] https://git.zx2c4.com/WireGuard/commit/?id=884b6e36e6af0c6fa5b9467ccc8c2e2e4477bc95

Jordan
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [ANNOUNCE] WireGuard Snapshot `0.0.20191205` Available
  2019-12-06 15:10 ` Jordan Glover
@ 2019-12-06 15:20   ` Jason A. Donenfeld
  2019-12-06 15:36     ` Jordan Glover
  0 siblings, 1 reply; 10+ messages in thread
From: Jason A. Donenfeld @ 2019-12-06 15:20 UTC (permalink / raw)
  To: Jordan Glover; +Cc: WireGuard mailing list

On Fri, Dec 6, 2019 at 4:11 PM Jordan Glover
<Golden_Miller83@protonmail.ch> wrote:
>
> On Thursday, December 5, 2019 10:55 AM, Jason A. Donenfeld <Jason@zx2c4.com> wrote:
>
> > Hello,
> >
> > A new snapshot, `0.0.20191205`, has been tagged in the git repository.
> >
> > Please note that this snapshot is a snapshot rather than a final
> > release that is considered secure and bug-free. WireGuard is generally
> > thought to be fairly stable, and most likely will not crash your
> > computer (though it may). However, as this is a snapshot, it comes
> > with no guarantees; it is not applicable for CVEs.
> >
> > With all that said, if you'd like to test this snapshot out, there are a
> > few relevant changes.
> >
> > == Changes ==
> >
> > -   wg-quick: linux: suppress error when finding unused table
> >
> >     This fixes a spurious warning messages seen with recent versions of iproute2
> >     and kernels.
> >
> > -   wg-quick: linux: ensure postdown hooks execute
> > -   wg-quick: linux: have remove_iptables return true
> > -   wg-quick: linux: iptables-* -w is not widely supported
> >
> >     Adding in iptables had some hiccups. For the record, I'm very unhappy about
> >     having to put any firewalling code into wg-quick(8). We'll of course need to
> >     support nftables too at some point if this continues. I'm investigating with
> >     upstream the possibility of adding a sysctl to patch the issue that iptables
> >     is handling now, so hopefully at somepoint down the line we'll be able to shed
> >     this dependency once again.
> >
> > -   send: use kfree_skb_list
> > -   device: prepare skb_list_walk_safe for upstreaming
> > -   send: avoid touching skb->{next,prev} directly
> >
> > Suggestions from LKML.
> >
> > -   ipc: make sure userspace communication frees wgdevice
> >
> >     Free things properly on error paths.
> >
> >     This snapshot contains commits from: Jason A. Donenfeld.
> >
> >     As always, the source is available at https://git.zx2c4.com/WireGuard/ and
> >     information about the project is available at https://www.wireguard.com/ .
> >
> >     This snapshot is available in compressed tarball form here:
> >     https://git.zx2c4.com/WireGuard/snapshot/WireGuard-0.0.20191205.tar.xz
> >     SHA2-256:
> >     BLAKE2b-256:
> >
> >     A PGP signature of that file decompressed is available here:
> >     https://git.zx2c4.com/WireGuard/snapshot/WireGuard-0.0.20191205.tar.asc
> >     Signing key: AB9942E6D4A4CFC3412620A749FC7012A5DE03AE
> >
> >     If you're a snapshot package maintainer, please bump your package version. If
> >     you're a user, the WireGuard team welcomes any and all feedback on this latest
> >     snapshot.
> >
> >     Finally, WireGuard development thrives on donations. By popular demand, we
> >     have a webpage for this: https://www.wireguard.com/donations/
> >
> >     Thank you,
> >     Jason Donenfeld
> >
>
> Hi, this release cause coredump on wg-quick down action:
>
> systemd[1]: Stopping WireGuard via wg-quick(8) for wg0...
> wg-quick[2241]: [#] iptables -D OUTPUT -o wg0 -j ACCEPT
> wg-quick[2241]: [#] ip -4 rule delete table 51820
> wg-quick[2241]: [#] ip -4 rule delete table main suppress_prefixlength 0
> wg-quick[2257]: RTNETLINK answers: Address family not supported by protocol
> wg-quick[2257]: Dump terminated
> wg-quick[2258]: RTNETLINK answers: Address family not supported by protocol
> wg-quick[2258]: Dump terminated
> wg-quick[2241]: [#] ip link delete dev wg0
> wg-quick[2241]: [#] resolvconf -d wg0 -f
> wg-quick[2315]: [#] iptables-restore -n
> audit[2316]: ANOM_ABEND auid=4294967295 uid=0 gid=0 ses=4294967295 subj==unconfined pid=2316 comm="iptables-restor" exe="/usr/bin/xtables-nft-multi" sig=11 res=1
> wg-quick[2315]: /usr/bin/wg-quick: line 29:  2316 Segmentation fault      (core dumped) "$@"
> kernel: show_signal_msg: 40 callbacks suppressed
> kernel: iptables-restor[2316]: segfault at 0 ip 000064515b66fcc9 sp 00007e6bbcbfb720 error 4 in libnftnl.so.11.2.0[64515b66d000+18000]
> kernel: Code: 15 5c 20 02 00 48 85 c0 74 07 48 89 00 48 89 40 08 48 83 c4 08 c3 66 66 2e 0f 1f 84 00 00 00 00 00 55 48 89 fd 53 48 83 ec 08 <48> 8b 3f 48 8b 1f 48 39 fd 74 2f 0f 1f 40 00 48 8b 47 08 48 89 43
> systemd[1]: wg-quick@wg0.service: Succeeded.
> systemd[1]: Stopped WireGuard via wg-quick(8) for wg0.

What distro's iptables?
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [ANNOUNCE] WireGuard Snapshot `0.0.20191205` Available
  2019-12-06 15:20   ` Jason A. Donenfeld
@ 2019-12-06 15:36     ` Jordan Glover
  2019-12-06 15:52       ` Jason A. Donenfeld
  0 siblings, 1 reply; 10+ messages in thread
From: Jordan Glover @ 2019-12-06 15:36 UTC (permalink / raw)
  To: Jason A. Donenfeld; +Cc: WireGuard mailing list

On Friday, December 6, 2019 3:20 PM, Jason A. Donenfeld <Jason@zx2c4.com> wrote:

> On Fri, Dec 6, 2019 at 4:11 PM Jordan Glover
> Golden_Miller83@protonmail.ch wrote:
>
> > Hi, this release cause coredump on wg-quick down action:
> > systemd[1]: Stopping WireGuard via wg-quick(8) for wg0...
> > wg-quick[2241]: [#] iptables -D OUTPUT -o wg0 -j ACCEPT
> > wg-quick[2241]: [#] ip -4 rule delete table 51820
> > wg-quick[2241]: [#] ip -4 rule delete table main suppress_prefixlength 0
> > wg-quick[2257]: RTNETLINK answers: Address family not supported by protocol
> > wg-quick[2257]: Dump terminated
> > wg-quick[2258]: RTNETLINK answers: Address family not supported by protocol
> > wg-quick[2258]: Dump terminated
> > wg-quick[2241]: [#] ip link delete dev wg0
> > wg-quick[2241]: [#] resolvconf -d wg0 -f
> > wg-quick[2315]: [#] iptables-restore -n
> > audit[2316]: ANOM_ABEND auid=4294967295 uid=0 gid=0 ses=4294967295 subj==unconfined pid=2316 comm="iptables-restor" exe="/usr/bin/xtables-nft-multi" sig=11 res=1
> > wg-quick[2315]: /usr/bin/wg-quick: line 29: 2316 Segmentation fault (core dumped) "$@"
> > kernel: show_signal_msg: 40 callbacks suppressed
> > kernel: iptables-restor[2316]: segfault at 0 ip 000064515b66fcc9 sp 00007e6bbcbfb720 error 4 in libnftnl.so.11.2.0[64515b66d000+18000]
> > kernel: Code: 15 5c 20 02 00 48 85 c0 74 07 48 89 00 48 89 40 08 48 83 c4 08 c3 66 66 2e 0f 1f 84 00 00 00 00 00 55 48 89 fd 53 48 83 ec 08 <48> 8b 3f 48 8b 1f 48 39 fd 74 2f 0f 1f 40 00 48 8b 47 08 48 89 43
> > systemd[1]: wg-quick@wg0.service: Succeeded.
> > systemd[1]: Stopped WireGuard via wg-quick(8) for wg0.
>
> What distro's iptables?

iptables is from Arch Linux iptables-nft package:

$ iptables --version
iptables v1.8.3 (nf_tables)

Jordan

_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [ANNOUNCE] WireGuard Snapshot `0.0.20191205` Available
  2019-12-06 15:36     ` Jordan Glover
@ 2019-12-06 15:52       ` Jason A. Donenfeld
  2019-12-06 16:23         ` Jordan Glover
  0 siblings, 1 reply; 10+ messages in thread
From: Jason A. Donenfeld @ 2019-12-06 15:52 UTC (permalink / raw)
  To: Jordan Glover; +Cc: WireGuard mailing list

On Fri, Dec 6, 2019 at 4:36 PM Jordan Glover
<Golden_Miller83@protonmail.ch> wrote:
> iptables is from Arch Linux iptables-nft package:
>
> $ iptables --version
> iptables v1.8.3 (nf_tables)

Does the segfault happen with the latest version in the git repo?

https://git.zx2c4.com/WireGuard/tree/src/tools/wg-quick/linux.bash
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [ANNOUNCE] WireGuard Snapshot `0.0.20191205` Available
  2019-12-06 15:52       ` Jason A. Donenfeld
@ 2019-12-06 16:23         ` Jordan Glover
  2019-12-06 17:35           ` Jason A. Donenfeld
  0 siblings, 1 reply; 10+ messages in thread
From: Jordan Glover @ 2019-12-06 16:23 UTC (permalink / raw)
  To: Jason A. Donenfeld; +Cc: WireGuard mailing list

On Friday, December 6, 2019 3:52 PM, Jason A. Donenfeld <Jason@zx2c4.com> wrote:

> On Fri, Dec 6, 2019 at 4:36 PM Jordan Glover
> Golden_Miller83@protonmail.ch wrote:
>
> > iptables is from Arch Linux iptables-nft package:
> > $ iptables --version
> > iptables v1.8.3 (nf_tables)
>
> Does the segfault happen with the latest version in the git repo?
>
> https://git.zx2c4.com/WireGuard/tree/src/tools/wg-quick/linux.bash

Yes, it still segfaults in the same way as before:

systemd[1]: Stopping WireGuard via wg-quick(8) for wg0...
wg-quick[6528]: [#] iptables -D OUTPUT -o wg0 -j ACCEPT
wg-quick[6528]: [#] ip -4 rule delete table 51820
wg-quick[6528]: [#] ip -4 rule delete table main suppress_prefixlength 0
wg-quick[6528]: [#] ip link delete dev wg0
wg-quick[6528]: [#] resolvconf -d wg0 -f
wg-quick[6620]: [#] iptables-restore -n
audit[6621]: ANOM_ABEND auid=4294967295 uid=0 gid=0 ses=4294967295 subj==unconfined pid=6621 comm="iptables-restor" exe="/usr/bin/xtables-nft-multi" sig=11 res=1
wg-quick[6620]: /usr/bin/wg-quick: line 29:  6621 Segmentation fault      (core dumped) "$@"
kernel: iptables-restor[6621]: segfault at 0 ip 00006e4350496cc9 sp 00007bfae0479dd0 error 4 in libnftnl.so.11.2.0[6e4350494000+18000]
kernel: Code: 15 5c 20 02 00 48 85 c0 74 07 48 89 00 48 89 40 08 48 83 c4 08 c3 66 66 2e 0f 1f 84 00 00 00 00 00 55 48 89 fd 53 48 83 ec 08 <48> 8b 3f 48 8b 1f 48 39 fd 74 2f 0f 1f 40 00 48 8b 47 08 48 89 43
systemd[1]: wg-quick@wg0.service: Succeeded.
systemd[1]: Stopped WireGuard via wg-quick(8) for wg0.

The "RTNETLINK answers: Address family not supported by protocol"
messages which were caused by lack of ipv6 support in kernel
(AKA weird kernels) was silenced but I think they weren't related
to this problem.

Jordan
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [ANNOUNCE] WireGuard Snapshot `0.0.20191205` Available
  2019-12-06 16:23         ` Jordan Glover
@ 2019-12-06 17:35           ` Jason A. Donenfeld
  2019-12-11 19:13             ` Jordan Glover
  0 siblings, 1 reply; 10+ messages in thread
From: Jason A. Donenfeld @ 2019-12-06 17:35 UTC (permalink / raw)
  To: Jordan Glover; +Cc: WireGuard mailing list

Looks like an arch problem or a libnftnl problem. I've made a minimal
reproducer:

printf '*filter\nCOMMIT\n*raw\nCOMMIT\n*mangle\nCOMMIT\n' | sudo
iptables-nft-restore -n

I filed a bug report on Arch: https://bugs.archlinux.org/task/64755
You can follow up with them.
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [ANNOUNCE] WireGuard Snapshot `0.0.20191205` Available
  2019-12-06 17:35           ` Jason A. Donenfeld
@ 2019-12-11 19:13             ` Jordan Glover
  2019-12-11 19:22               ` Jason A. Donenfeld
  0 siblings, 1 reply; 10+ messages in thread
From: Jordan Glover @ 2019-12-11 19:13 UTC (permalink / raw)
  To: Jason A. Donenfeld; +Cc: WireGuard mailing list

On Friday, December 6, 2019 5:35 PM, Jason A. Donenfeld <Jason@zx2c4.com> wrote:

> Looks like an arch problem or a libnftnl problem. I've made a minimal
> reproducer:
>
> printf 'filter\nCOMMIT\nraw\nCOMMIT\n*mangle\nCOMMIT\n' | sudo
> iptables-nft-restore -n
>
> I filed a bug report on Arch: https://bugs.archlinux.org/task/64755
> You can follow up with them.

I tried to compile myself iptables 1.8.4 which is latest upstream version
and have good and bad news:

The good one is your minimal reproducer no longer causes segfault.

The bad one is wg-quick still does:

wg-quick[2325]: [#] iptables-restore -n
audit[2326]: ANOM_ABEND auid=4294967295 uid=0 gid=0 ses=4294967295 subj==unconfined pid=2326 comm="iptables-restor" exe="/usr/bin/xtables-nft-multi" sig=11 res=1
wg-quick[2325]: /usr/bin/wg-quick: line 29:  2326 Segmentation fault      (core dumped) "$@"
kernel: show_signal_msg: 40 callbacks suppressed
kernel: iptables-restor[2326]: segfault at 0 ip 000069bb4df13cc9 sp 0000716fcc5b9b30 error 4 in libnftnl.so.11.2.0[69bb4df11000+18000]
kernel: Code: 15 5c 20 02 00 48 85 c0 74 07 48 89 00 48 89 40 08 48 83 c4 08 c3 66 66 2e 0f 1f 84 00 00 00 00 00 55 48 89 fd 53 48 83 ec 08 <48> 8b 3f 48 8b 1f 48 39 fd 74 2f 0f 1f 40 00 48 8b 47 08 48 89 43

Maybe upstream found and fixed some regression but still missed
the other one.

Jordan
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [ANNOUNCE] WireGuard Snapshot `0.0.20191205` Available
  2019-12-11 19:13             ` Jordan Glover
@ 2019-12-11 19:22               ` Jason A. Donenfeld
  0 siblings, 0 replies; 10+ messages in thread
From: Jason A. Donenfeld @ 2019-12-11 19:22 UTC (permalink / raw)
  To: Jordan Glover; +Cc: WireGuard mailing list

On Wed, Dec 11, 2019 at 8:13 PM Jordan Glover
<Golden_Miller83@protonmail.ch> wrote:
>
> On Friday, December 6, 2019 5:35 PM, Jason A. Donenfeld <Jason@zx2c4.com> wrote:
>
> > Looks like an arch problem or a libnftnl problem. I've made a minimal
> > reproducer:
> >
> > printf 'filter\nCOMMIT\nraw\nCOMMIT\n*mangle\nCOMMIT\n' | sudo
> > iptables-nft-restore -n
> >
> > I filed a bug report on Arch: https://bugs.archlinux.org/task/64755
> > You can follow up with them.
>
> I tried to compile myself iptables 1.8.4 which is latest upstream version
> and have good and bad news:
>
> The good one is your minimal reproducer no longer causes segfault.
>
> The bad one is wg-quick still does:
>
> wg-quick[2325]: [#] iptables-restore -n
> audit[2326]: ANOM_ABEND auid=4294967295 uid=0 gid=0 ses=4294967295 subj==unconfined pid=2326 comm="iptables-restor" exe="/usr/bin/xtables-nft-multi" sig=11 res=1
> wg-quick[2325]: /usr/bin/wg-quick: line 29:  2326 Segmentation fault      (core dumped) "$@"
> kernel: show_signal_msg: 40 callbacks suppressed
> kernel: iptables-restor[2326]: segfault at 0 ip 000069bb4df13cc9 sp 0000716fcc5b9b30 error 4 in libnftnl.so.11.2.0[69bb4df11000+18000]
> kernel: Code: 15 5c 20 02 00 48 85 c0 74 07 48 89 00 48 89 40 08 48 83 c4 08 c3 66 66 2e 0f 1f 84 00 00 00 00 00 55 48 89 fd 53 48 83 ec 08 <48> 8b 3f 48 8b 1f 48 39 fd 74 2f 0f 1f 40 00 48 8b 47 08 48 89 43
>
> Maybe upstream found and fixed some regression but still missed
> the other one.

Can you craft a new minimal reproducer?
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [ANNOUNCE] WireGuard Snapshot `0.0.20191205` Available
@ 2019-12-05 10:57 Jason A. Donenfeld
  0 siblings, 0 replies; 10+ messages in thread
From: Jason A. Donenfeld @ 2019-12-05 10:57 UTC (permalink / raw)
  To: WireGuard mailing list

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hello,

A new snapshot, `0.0.20191205`, has been tagged in the git repository.

Please note that this snapshot is a snapshot rather than a final
release that is considered secure and bug-free. WireGuard is generally
thought to be fairly stable, and most likely will not crash your
computer (though it may).  However, as this is a snapshot, it comes
with no guarantees; it is not applicable for CVEs.

With all that said, if you'd like to test this snapshot out, there are a
few relevant changes.

== Changes ==

  * wg-quick: linux: suppress error when finding unused table
  
  This fixes a spurious warning messages seen with recent versions of iproute2
  and kernels.
  
  * wg-quick: linux: ensure postdown hooks execute
  * wg-quick: linux: have remove_iptables return true
  * wg-quick: linux: iptables-* -w is not widely supported
  
  Adding in iptables had some hiccups. For the record, I'm very unhappy about
  having to put any firewalling code into wg-quick(8). We'll of course need to
  support nftables too at some point if this continues. I'm investigating with
  upstream the possibility of adding a sysctl to patch the issue that iptables
  is handling now, so hopefully at somepoint down the line we'll be able to shed
  this dependency once again.
  
  * send: use kfree_skb_list
  * device: prepare skb_list_walk_safe for upstreaming
  * send: avoid touching skb->{next,prev} directly
  
  Suggestions from LKML.
  
  * ipc: make sure userspace communication frees wgdevice
  
  Free things properly on error paths.

This snapshot contains commits from: Jason A. Donenfeld.

As always, the source is available at https://git.zx2c4.com/WireGuard/ and
information about the project is available at https://www.wireguard.com/ .

This snapshot is available in compressed tarball form here:
  https://git.zx2c4.com/WireGuard/snapshot/WireGuard-0.0.20191205.tar.xz
  SHA2-256: 4de4c0efa35f8eb170c27a0bc8977e5c0634b8e19c03915d03218cc88bb0adbe
  BLAKE2b-256: 3cf4f58e1e4982ea3f25f287ae035ac2cca86007ceeefd124003982bba800bd4

A PGP signature of that file decompressed is available here:
  https://git.zx2c4.com/WireGuard/snapshot/WireGuard-0.0.20191205.tar.asc
  Signing key: AB9942E6D4A4CFC3412620A749FC7012A5DE03AE

If you're a snapshot package maintainer, please bump your package version. If
you're a user, the WireGuard team welcomes any and all feedback on this latest
snapshot.

Finally, WireGuard development thrives on donations. By popular demand, we
have a webpage for this: https://www.wireguard.com/donations/

Thank you,
Jason Donenfeld


-----BEGIN PGP SIGNATURE-----

iQJEBAEBCAAuFiEEq5lC5tSkz8NBJiCnSfxwEqXeA64FAl3o4qoQHGphc29uQHp4
MmM0LmNvbQAKCRBJ/HASpd4DrgToEADabWFukMDvEvTES9ngUnco0xMEz0IOcagF
1GdRXdNugEuxLcpXZKPvqjG6NxehWP9dAygJvXoxGat6BTOKe7VzTqtr2yzSftxQ
Yxa5Fn1ZQGlBGfkKBkMy20QI5XJ43cZ9Rm69I5HybrBjaHa+l15F8soDzSs/Yo4H
LJPoilxi27kylDQDSTPlHRsuEOuwnxY2HRTHrDm13nGXys9eELSsZ0EF1y90kxYC
CV3St8BUCKRB8ezQQiIrTNuiLa9wvJvNAe0tCjUticQyhXlQF9J+vWxRJCr620D2
vAZ9+uPQj1vb9SyJZWhdm08Wc1zYAgty2POL+9x4Wmlz0pSGTbUJKAwNcvAeCBVL
21/72y8HEitK+5/qiTe9wqlNbWIMVqr0GmFod5eMheqfLaepOcCeVMuLhMIUpciD
1vsMzIfOJmNmHUqiDo+vpFVUvlX5NHyB60kn6d90kLgZmd8JqXItZ0qLYT2VIJUe
PKFCOl9p5MNRcYN5ORisOS0H9qkIOXuTaemwf94OvC0VsPxLe1m7dSvfAbHmpM0j
8qB1dWwCWpjy6zzZ0EatKRA5HBwDfWIt2VuhvUj1ai8ayPnXY6PPQsilj6v7OjMW
vvgX6q+NGJ423F5uCaxp/GY1d5ywLjAxURnXG4E3oEQ8RV5QspsvbXQDTV8Yu+0f
08e7E/G2Tg==
=Oi5b
-----END PGP SIGNATURE-----
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2019-12-11 19:23 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-05 10:55 [ANNOUNCE] WireGuard Snapshot `0.0.20191205` Available Jason A. Donenfeld
2019-12-06 15:10 ` Jordan Glover
2019-12-06 15:20   ` Jason A. Donenfeld
2019-12-06 15:36     ` Jordan Glover
2019-12-06 15:52       ` Jason A. Donenfeld
2019-12-06 16:23         ` Jordan Glover
2019-12-06 17:35           ` Jason A. Donenfeld
2019-12-11 19:13             ` Jordan Glover
2019-12-11 19:22               ` Jason A. Donenfeld
2019-12-05 10:57 Jason A. Donenfeld

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).