kernel 4.4.0-161-generic (i686) build problem

kernel 4.4.0-161-generic (i686) build problem

[Jorge Mireles]

[-- Attachment #1.1: Type: text/plain, Size: 3133 bytes --]

Hello wireguard team!
After my linux box updated to kernel 4.40-161-generic wireguard stop
working.
I found dkms build reported a problem.
This is my /var/crash/wireguard-dkms.0.crash file content:

---------------------------------

ProblemType: Package
DKMSBuildLog:
 DKMS make.log for wireguard-0.0.20190702 for kernel 4.4.0-161-generic
(i686)
 Wed Sep  4 10:59:50 CDT 2019
 make: Entering directory '/usr/src/linux-headers-4.4.0-161-generic'
   LD      /var/lib/dkms/wireguard/0.0.20190702/build/built-in.o
   CC [M]  /var/lib/dkms/wireguard/0.0.20190702/build/main.o
   CC [M]  /var/lib/dkms/wireguard/0.0.20190702/build/noise.o
   CC [M]  /var/lib/dkms/wireguard/0.0.20190702/build/device.o
   CC [M]  /var/lib/dkms/wireguard/0.0.20190702/build/peer.o
   CC [M]  /var/lib/dkms/wireguard/0.0.20190702/build/timers.o
   CC [M]  /var/lib/dkms/wireguard/0.0.20190702/build/queueing.o
   CC [M]  /var/lib/dkms/wireguard/0.0.20190702/build/send.o
   CC [M]  /var/lib/dkms/wireguard/0.0.20190702/build/receive.o
   CC [M]  /var/lib/dkms/wireguard/0.0.20190702/build/socket.o
   CC [M]  /var/lib/dkms/wireguard/0.0.20190702/build/peerlookup.o
   CC [M]  /var/lib/dkms/wireguard/0.0.20190702/build/allowedips.o
   CC [M]  /var/lib/dkms/wireguard/0.0.20190702/build/ratelimiter.o
 /var/lib/dkms/wireguard/0.0.20190702/build/ratelimiter.c:25:8: error:
unknown type name ‘hsiphash_key_t’
  static hsiphash_key_t key;
         ^
 /var/lib/dkms/wireguard/0.0.20190702/build/ratelimiter.c: In function
‘wg_ratelimiter_allow’:
 /var/lib/dkms/wireguard/0.0.20190702/build/ratelimiter.c:109:22: error:
implicit declaration of function ‘hsiphash_2u32’
[-Werror=implicit-function-declaration]
    bucket = &table_v4[hsiphash_2u32(net_word, ip, &key) &
                       ^
 /var/lib/dkms/wireguard/0.0.20190702/build/ratelimiter.c:116:22: error:
implicit declaration of function ‘hsiphash_3u32’
[-Werror=implicit-function-declaration]
    bucket = &table_v6[hsiphash_3u32(net_word, ip >> 32, ip, &key) &
                       ^
 cc1: some warnings being treated as errors
 scripts/Makefile.build:285: recipe for target
'/var/lib/dkms/wireguard/0.0.20190702/build/ratelimiter.o' failed
 make[1]: *** [/var/lib/dkms/wireguard/0.0.20190702/build/ratelimiter.o]
Error 1
 Makefile:1454: recipe for target
'_module_/var/lib/dkms/wireguard/0.0.20190702/build' failed
 make: *** [_module_/var/lib/dkms/wireguard/0.0.20190702/build] Error 2
 make: Leaving directory '/usr/src/linux-headers-4.4.0-161-generic'
DKMSKernelVersion: 4.4.0-161-generic
Date: Wed Sep  4 10:59:58 2019
DuplicateSignature:
dkms:wireguard-dkms:0.0.20190702-wg1~xenial:/var/lib/dkms/wireguard/0.0.20190702/build/ratelimiter.c:25:8:
error: unknown type name ‘hsiphash_key_t’
Package: wireguard-dkms 0.0.20190702-wg1~xenial
PackageVersion: 0.0.20190702-wg1~xenial
SourcePackage: wireguard
Title: wireguard-dkms 0.0.20190702-wg1~xenial: wireguard kernel module
failed to build

-------------------------

Is 4.4.0-161 buggy or something sources can need to be adjusted?
Thanks in advance
Jorge

[-- Attachment #1.2: Type: text/html, Size: 4103 bytes --]

[-- Attachment #2: Type: text/plain, Size: 148 bytes --]

_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

Re: kernel 4.4.0-161-generic (i686) build problem

[Jason A. Donenfeld]

Thanks for the report. Ubuntu's kernel team made an error in
backporting a patch from mainline. They're aware of this error, but
they're unable to rectify it for another 7 weeks, which clearly isn't
an acceptable amount of downtime for WireGuard servers. So yesterday
we made a new WireGuard release that works around this issue. Then,
this morning, Egbert, the maintainer of our Ubuntu package, published
a new Ubuntu package for our new release. So you should be all set by
running `apt update && apt upgrade`. Sorry for the hassle. I'm not too
happy about this situation myself, and I'm going to try to figure out
how the Ubuntu kernel people can make sure they don't break WireGuard
in the future with some sort of CI.
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard