From: Willy Tarreau <w@1wt.eu>
To: "Theodore Y. Ts'o" <tytso@mit.edu>
Cc: Vegard Nossum <vegard.nossum@oracle.com>,
Santiago Torres Arias <santiago@nyu.edu>,
workflows@vger.kernel.org, Git Mailing List <git@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
Eric Wong <e@80x24.org>
Subject: Re: email as a bona fide git transport
Date: Sun, 20 Oct 2019 05:17:16 +0200 [thread overview]
Message-ID: <20191020031716.GA17475@1wt.eu> (raw)
In-Reply-To: <20191018191456.GI21137@mit.edu>
On Fri, Oct 18, 2019 at 03:14:56PM -0400, Theodore Y. Ts'o wrote:
> On Fri, Oct 18, 2019 at 06:50:51PM +0200, Vegard Nossum wrote:
> > The problem I ran into with putting the metadata at the end was
> > detecting where the diff ends. A comment in 'git apply' suggested that
> > detecting the difference between "--" as a diff/signature separator and
> > as part of the diff is nontrivial in the sense that you need to actually
> > do some parsing and keep track of hunk sizes.
>
> Could we cheat by having "git format-patch" add a "Diff-size" in the
> header which gives the number of lines in the diff so git am can just
> count lines to find the Trailer section?
Be careful with this, it starts like this and ends up with non-editable
patches. I'd rather have git-am use best-effort detection of the end.
Also when dealing with stable backports, I've done a lot of
"cat foo.diff >> bar.patch" to fixup some patches in which I just had
to move some parts around. Having to count lines and edit a counter
somewhere is going to become really painful.
Just my two cents,
Willy
next prev parent reply other threads:[~2019-10-20 3:17 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 10:22 email as a bona fide git transport Vegard Nossum
2019-10-16 11:10 ` Willy Tarreau
2019-10-16 14:45 ` Santiago Torres Arias
2019-10-17 20:43 ` Greg KH
2019-10-17 20:45 ` Konstantin Ryabitsev
2019-10-18 1:30 ` Greg KH
2019-10-18 1:54 ` Konstantin Ryabitsev
2019-10-18 2:52 ` Willy Tarreau
2019-10-18 6:34 ` Nicolas Belouin
2019-10-18 15:50 ` Santiago Torres Arias
2019-10-20 5:50 ` Laurent Pinchart
2019-10-18 14:27 ` Vegard Nossum
2019-10-18 15:54 ` Santiago Torres Arias
2019-10-18 16:03 ` Konstantin Ryabitsev
2019-10-18 16:11 ` Santiago Torres Arias
2019-10-18 18:00 ` Konstantin Ryabitsev
2019-10-18 16:15 ` Theodore Y. Ts'o
2019-10-18 16:50 ` Vegard Nossum
2019-10-18 19:14 ` Theodore Y. Ts'o
2019-10-20 3:17 ` Willy Tarreau [this message]
2019-10-20 6:28 ` Vegard Nossum
2019-10-22 12:11 ` Vegard Nossum
2019-10-22 13:53 ` Theodore Y. Ts'o
2019-10-22 16:29 ` Vegard Nossum
2019-10-22 19:01 ` Eric Wong
2019-10-16 15:00 ` Pratyush Yadav
2019-10-17 12:23 ` Vegard Nossum
2019-10-17 13:11 ` Theodore Y. Ts'o
2019-10-17 14:01 ` Vegard Nossum
2019-10-17 14:47 ` Theodore Y. Ts'o
2019-10-17 15:11 ` Steven Rostedt
2019-10-16 20:57 ` Jonathan Nieder
2019-10-17 13:08 ` Vegard Nossum
2019-10-17 3:17 ` Junio C Hamano
2019-10-17 13:30 ` Vegard Nossum
2019-10-18 2:22 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191020031716.GA17475@1wt.eu \
--to=w@1wt.eu \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=konstantin@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=santiago@nyu.edu \
--cc=tytso@mit.edu \
--cc=vegard.nossum@oracle.com \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).