From: Jesper Dangaard Brouer <jbrouer@redhat.com>
To: Srivats P <pstavirs@gmail.com>, Xdp <xdp-newbies@vger.kernel.org>,
Network Development <netdev@vger.kernel.org>
Cc: brouer@redhat.com, Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
David Ahern <dsahern@kernel.org>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: netdev stats for AF_XDP traffic
Date: Fri, 8 Jul 2022 09:00:09 +0200 [thread overview]
Message-ID: <58e538d6-d1cd-4689-694e-e14d91c47d41@redhat.com> (raw)
In-Reply-To: <CANzUK5_qwaRm=9c46yH8d_J54PAcNhZB-R5M=wYgXGGaJJaFAA@mail.gmail.com>
On 08/07/2022 08.19, Srivats P wrote:
> Hi,
>
> Is there any update on the "consistency for XDP statistics" [1]
> high-prio work item from the xdp-project.net project management page?
Lorenzo (cc) have done cleanups in several drivers, both mvneta and
veth, but not mlx5. Ahern (cc) also had an interest earlier.
> More specifically the fact that the mlx driver (are there others too?)
> don't update netdev/ifconfig stats for XDP/AF_XDP traffic?
IMHO the drivers MUST update the netdev/ifconfig RX stats, even when an
XDP action is taken. XDP-progs are user installed software, and not
updating netdev RX-stats (for some XDP actions) is very confusing for
all existing stats collector tools.
The mlx drivers are (sadly) the most inconsistent if I remember correctly.
> The email thread started for that item dates from 2018 and hasn't
> seen any updates after that.
I think nobody have really had the time to fix up this inconsistent
stats mess.
Are you interested in working on this?
> I see some recent patch/commit activity about XDP specific stats via
> netlink but I believe this is different from the standard
> netdev/ifconfig stats.
Yes, if taking this "task", I recommend focusing on standardizing
netdev/ifconfig stats behavior for XDP. Solving the other XDP specific
stats is a much larger task with much upstream discussions required.
> Srivats
>
> [1] https://xdp-project.net/#Consistency-for-statistics-with-XDP
>
--Jesper
next prev parent reply other threads:[~2022-07-08 7:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 6:19 netdev stats for AF_XDP traffic Srivats P
2022-07-08 7:00 ` Jesper Dangaard Brouer [this message]
2023-11-30 11:40 ` Srivats P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58e538d6-d1cd-4689-694e-e14d91c47d41@redhat.com \
--to=jbrouer@redhat.com \
--cc=brouer@redhat.com \
--cc=dsahern@kernel.org \
--cc=kuba@kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pstavirs@gmail.com \
--cc=xdp-newbies@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).