From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Julien Grall <julien@xen.org>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, nd <nd@arm.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"George Dunlap" <george.dunlap@citrix.com>,
"Ian Jackson" <ian.jackson@eu.citrix.com>,
"Jan Beulich" <jbeulich@suse.com>, "Wei Liu" <wl@xen.org>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH v3] xen/arm: Convert runstate address during hypcall
Date: Fri, 14 Aug 2020 09:11:35 +0000 [thread overview]
Message-ID: <0C2FA898-52D1-4C4B-918C-E7500FEABD0E@arm.com> (raw)
In-Reply-To: <f45d3213-c785-4f62-5c3e-77093062d1b6@xen.org>
> On 13 Aug 2020, at 18:35, Julien Grall <julien@xen.org> wrote:
>
> Hi Bertrand,
>
> On 31/07/2020 14:26, Bertrand Marquis wrote:
>>>> + {
>>>> + gprintk(XENLOG_WARNING, "Cannot map runstate pointer at 0x%"PRIvaddr
>>>> + ": Invalid offset\n", vaddr);
>>>
>>> We usually enforce 80 character per lines except for format string. So it is easier to grep them in the code.
>> Ok i will fix this one and the following ones.
>> But here PRIvaddr would break any attempt to grep something in fact.
>
> The idea is you can grep a few words on the message and then easily find the line.
Ok i will put everything back in one line.
Regards
Bertrand
prev parent reply other threads:[~2020-08-14 9:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 10:24 [PATCH v3] xen/arm: Convert runstate address during hypcall Bertrand Marquis
2020-07-30 20:50 ` Julien Grall
2020-07-31 1:18 ` Stefano Stabellini
2020-07-31 13:17 ` Bertrand Marquis
2020-07-31 12:19 ` Jan Beulich
2020-07-31 13:09 ` Bertrand Marquis
2020-07-31 15:06 ` Julien Grall
2020-07-31 13:16 ` Bertrand Marquis
2020-08-13 17:28 ` Julien Grall
2020-08-14 9:11 ` Bertrand Marquis
2020-07-31 13:26 ` Bertrand Marquis
2020-07-31 23:03 ` Stefano Stabellini
2020-08-14 9:12 ` Bertrand Marquis
2020-08-13 17:35 ` Julien Grall
2020-08-14 9:11 ` Bertrand Marquis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0C2FA898-52D1-4C4B-918C-E7500FEABD0E@arm.com \
--to=bertrand.marquis@arm.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=nd@arm.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).