From: Julien Grall <julien.grall@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Julien Grall <julien.grall@citrix.com>,
netdev@vger.kernel.org, Wei Liu <wei.liu2@citrix.com>,
linux-kernel@vger.kernel.org,
Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH v4 2/3] net/xen-netback: Remove unused code in xenvif_rx_action
Date: Tue, 16 Jun 2015 20:10:47 +0100 [thread overview]
Message-ID: <1434481848-26387-3-git-send-email-julien.grall__45153.7162102342$1434482027$gmane$org@citrix.com> (raw)
In-Reply-To: <1434481848-26387-1-git-send-email-julien.grall@citrix.com>
The variables old_req_cons and ring_slots_used are assigned but never
used since commit 1650d5455bd2dc6b5ee134bd6fc1a3236c266b5b "xen-netback:
always fully coalesce guest Rx packets".
Signed-off-by: Julien Grall <julien.grall@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>
Cc: netdev@vger.kernel.org
---
Changes in v2:
- Add Wei's Acked-by
---
drivers/net/xen-netback/netback.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
index 0d25943..ba3ae30 100644
--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -515,14 +515,9 @@ static void xenvif_rx_action(struct xenvif_queue *queue)
while (xenvif_rx_ring_slots_available(queue, XEN_NETBK_RX_SLOTS_MAX)
&& (skb = xenvif_rx_dequeue(queue)) != NULL) {
- RING_IDX old_req_cons;
- RING_IDX ring_slots_used;
-
queue->last_rx_time = jiffies;
- old_req_cons = queue->rx.req_cons;
XENVIF_RX_CB(skb)->meta_slots_used = xenvif_gop_skb(skb, &npo, queue);
- ring_slots_used = queue->rx.req_cons - old_req_cons;
__skb_queue_tail(&rxq, skb);
}
--
2.1.4
next prev parent reply other threads:[~2015-06-16 19:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1434481848-26387-1-git-send-email-julien.grall@citrix.com>
2015-06-16 19:10 ` [PATCH v4 1/3] net/xen-netfront: Correct printf format in xennet_get_responses Julien Grall
2015-06-16 19:10 ` Julien Grall [this message]
2015-06-16 19:10 ` [PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with 0x in the printf format Julien Grall
[not found] ` <1434481848-26387-4-git-send-email-julien.grall@citrix.com>
2015-06-16 20:07 ` Sergei Shtylyov
[not found] ` <5580821D.4080408@cogentembedded.com>
2015-06-16 22:09 ` Joe Perches
[not found] ` <1434492550.2689.8.camel@perches.com>
2015-06-16 22:29 ` Sergei Shtylyov
[not found] ` <5580A33C.4040007@cogentembedded.com>
2015-06-16 23:55 ` Joe Perches
[not found] ` <1434498919.2689.35.camel@perches.com>
2015-06-17 8:54 ` Ian Campbell
2015-06-17 9:13 ` Jan Beulich
2015-06-17 9:25 ` Ian Campbell
[not found] ` <1434533143.13744.273.camel@citrix.com>
2015-06-17 9:30 ` Julien Grall
[not found] ` <55813E3F.8030602@citrix.com>
2015-06-17 9:37 ` Ian Campbell
2015-06-21 16:41 ` David Miller
[not found] ` <1434481848-26387-2-git-send-email-julien.grall@citrix.com>
2015-06-21 16:41 ` [PATCH v4 1/3] net/xen-netfront: Correct printf format in xennet_get_responses David Miller
[not found] ` <1434481848-26387-3-git-send-email-julien.grall@citrix.com>
2015-06-21 16:41 ` [PATCH v4 2/3] net/xen-netback: Remove unused code in xenvif_rx_action David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='1434481848-26387-3-git-send-email-julien.grall__45153.7162102342$1434482027$gmane$org@citrix.com' \
--to=julien.grall@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).