From: Joe Perches <joe@perches.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Julien Grall <julien.grall@citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with 0x in the printf format
Date: Tue, 16 Jun 2015 16:55:19 -0700 [thread overview]
Message-ID: <1434498919.2689.35.camel__45017.2473713339$1434499071$gmane$org@perches.com> (raw)
In-Reply-To: <5580A33C.4040007@cogentembedded.com>
On Wed, 2015-06-17 at 01:29 +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 06/17/2015 01:09 AM, Joe Perches wrote:
>
> >>> Append 0x to all %x in order to avoid while reading when there is other
> >>> decimal value in the log.
>
> > []
>
> >>> @@ -874,7 +874,7 @@ static inline void xenvif_grant_handle_set(struct xenvif_queue *queue,
> >>> if (unlikely(queue->grant_tx_handle[pending_idx] !=
> >>> NETBACK_INVALID_HANDLE)) {
> >>> netdev_err(queue->vif->dev,
> >>> - "Trying to overwrite active handle! pending_idx: %x\n",
> >>> + "Trying to overwrite active handle! pending_idx: 0x%x\n",
>
> >> Using "%#x" is shorter ind does the same.
>
> > That's true, but it's also far less common.
>
> Which is a pity... People just don't know the format specifiers well
> enough. :-(
>
> > $ git grep -E "%#[\*\d\.]*x" | wc -l
> > 1419
> > $ git grep "0x%" | wc -l
> > 29844
>
> Which means 29 KB could theoretically be saved on allyesconfig build. :-)
> (Actually less since the width specifiers will likely need to be fixed where
> present.)
And less than that because a lot of these are in
arch specific code.
0x%x is easier and simpler to visualize than %#x.
But you are welcome to try to make the kernel smaller.
One byte at a time.
There are ~14.5k uses of 0x%x in ~10.5k lines and
~2600 files that would be changed.
That's a lot of lines and a lot of patches.
$ git grep --name-only "0x%x" | xargs sed -i -e 's/0x%x/%#x/g'
$ git diff | wc
96250 415388 3949872
Only a 4M patch.
The pretty common (~5k) "0x%08x" would be "%#010x"
so that doesn't save any space.
but this one's a ~3.5M patch.
$ git grep --name-only -P "0x%\d+\w*x" | xargs perl -p -i -e 's/0x%0(\d+)(\w*)x/"\%#0" . eval($1 + 2) . "$2x"/eg'
$ git diff | wc
80857 344565 3306990
enjoy...
next prev parent reply other threads:[~2015-06-16 23:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1434481848-26387-1-git-send-email-julien.grall@citrix.com>
2015-06-16 19:10 ` [PATCH v4 1/3] net/xen-netfront: Correct printf format in xennet_get_responses Julien Grall
2015-06-16 19:10 ` [PATCH v4 2/3] net/xen-netback: Remove unused code in xenvif_rx_action Julien Grall
2015-06-16 19:10 ` [PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with 0x in the printf format Julien Grall
[not found] ` <1434481848-26387-4-git-send-email-julien.grall@citrix.com>
2015-06-16 20:07 ` Sergei Shtylyov
[not found] ` <5580821D.4080408@cogentembedded.com>
2015-06-16 22:09 ` Joe Perches
[not found] ` <1434492550.2689.8.camel@perches.com>
2015-06-16 22:29 ` Sergei Shtylyov
[not found] ` <5580A33C.4040007@cogentembedded.com>
2015-06-16 23:55 ` Joe Perches [this message]
[not found] ` <1434498919.2689.35.camel@perches.com>
2015-06-17 8:54 ` Ian Campbell
2015-06-17 9:13 ` Jan Beulich
2015-06-17 9:25 ` Ian Campbell
[not found] ` <1434533143.13744.273.camel@citrix.com>
2015-06-17 9:30 ` Julien Grall
[not found] ` <55813E3F.8030602@citrix.com>
2015-06-17 9:37 ` Ian Campbell
2015-06-21 16:41 ` David Miller
[not found] ` <1434481848-26387-2-git-send-email-julien.grall@citrix.com>
2015-06-21 16:41 ` [PATCH v4 1/3] net/xen-netfront: Correct printf format in xennet_get_responses David Miller
[not found] ` <1434481848-26387-3-git-send-email-julien.grall@citrix.com>
2015-06-21 16:41 ` [PATCH v4 2/3] net/xen-netback: Remove unused code in xenvif_rx_action David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='1434498919.2689.35.camel__45017.2473713339$1434499071$gmane$org@perches.com' \
--to=joe@perches.com \
--cc=ian.campbell@citrix.com \
--cc=julien.grall@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).