From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: stefano.stabellini@eu.citrix.com, xen-devel@lists.xenproject.org,
qemu-devel@nongnu.org
Subject: [PATCH v1] Cleanups + various fixes due to libxl ABI + more logging on errors.
Date: Thu, 2 Jul 2015 15:31:13 -0400 [thread overview]
Message-ID: <1435865479-18329-1-git-send-email-konrad.wilk@oracle.com> (raw)
Hey!
since RFC [https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg07326.html]
- Added Acks
- Followed 'xen: Print and use errno where applicable.' suggestion by Stefano
and added a wrapper.
As I am in the process of syncing the 'dev.config' and Xen's internal
cache of the PCI config space I noticed that some oddities
in the code and figured that having them in would be easier
for me (so I don't have to handle 20 odd patches).
Stefano, patches 1-3 are unchanged since the RFC posting (well, they have the
Ack tag added). Patch:
[PATCH v1 4/6] xen: use errno instead of rc for xc_domain_add_to_physmap
uses the new wrapper you suggested.
The last two patches are new and I missed them the first time I posted:
[PATCH v1 5/6] xen/pt/msi: Add the register value when printing
[PATCH v1 6/6] xen/pt: Use XEN_PT_LOG properly to guard against
In short, please review #4,#5, and #6.
hw/xen/xen_pt.c | 6 +++---
hw/xen/xen_pt.h | 1 -
hw/xen/xen_pt_config_init.c | 8 ++++----
hw/xen/xen_pt_msi.c | 2 +-
include/hw/xen/xen_common.h | 22 ++++++++++++++++++++++
xen-hvm.c | 4 ++--
6 files changed, 32 insertions(+), 11 deletions(-)
Konrad Rzeszutek Wilk (6):
xen/pt: Update comments with proper function name.
xen/pt: Make xen_pt_msi_set_enable static
xen/pt: xen_host_pci_config_read returns -errno, not -1 on failure
xen: use errno instead of rc for xc_domain_add_to_physmap
xen/pt/msi: Add the register value when printing logging and error messages
xen/pt: Use XEN_PT_LOG properly to guard against compiler warnings.
next reply other threads:[~2015-07-02 19:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 19:31 Konrad Rzeszutek Wilk [this message]
2015-07-02 19:31 ` [PATCH v1 1/6] xen/pt: Update comments with proper function name Konrad Rzeszutek Wilk
2015-07-02 19:31 ` [PATCH v1 2/6] xen/pt: Make xen_pt_msi_set_enable static Konrad Rzeszutek Wilk
2015-07-02 19:31 ` [PATCH v1 3/6] xen/pt: xen_host_pci_config_read returns -errno, not -1 on failure Konrad Rzeszutek Wilk
2015-07-02 19:31 ` [PATCH v1 4/6] xen: use errno instead of rc for xc_domain_add_to_physmap Konrad Rzeszutek Wilk
2015-07-17 15:22 ` Stefano Stabellini
2015-07-02 19:31 ` [PATCH v1 5/6] xen/pt/msi: Add the register value when printing logging and error messages Konrad Rzeszutek Wilk
2015-07-02 19:31 ` [PATCH v1 6/6] xen/pt: Use XEN_PT_LOG properly to guard against compiler warnings Konrad Rzeszutek Wilk
2015-07-17 15:29 ` Stefano Stabellini
[not found] ` <1435865479-18329-6-git-send-email-konrad.wilk@oracle.com>
2015-07-17 15:26 ` [PATCH v1 5/6] xen/pt/msi: Add the register value when printing logging and error messages Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435865479-18329-1-git-send-email-konrad.wilk@oracle.com \
--to=konrad.wilk@oracle.com \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).