xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: stefano.stabellini@eu.citrix.com, xen-devel@lists.xenproject.org,
	qemu-devel@nongnu.org
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: [PATCH v1 6/6] xen/pt: Use XEN_PT_LOG properly to guard against compiler warnings.
Date: Thu,  2 Jul 2015 15:31:19 -0400	[thread overview]
Message-ID: <1435865479-18329-7-git-send-email-konrad.wilk@oracle.com> (raw)
In-Reply-To: <1435865479-18329-1-git-send-email-konrad.wilk@oracle.com>

If XEN_PT_LOGGING_ENABLED is enabled the XEN_PT_LOG macros start
using the first argument. Which means if within the function there
is only one user of the argument ('d') and XEN_PT_LOGGING_ENABLED
is not set, we get compiler warnings. This is not the case now
but with the "xen/pt: Use xen_host_pci_get_[byte|word] instead of dev.config"
we will hit - so this sync up the function to the rest of them.

Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
 hw/xen/xen_pt_config_init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/xen_pt_config_init.c
index 462e1b9..21d4938 100644
--- a/hw/xen/xen_pt_config_init.c
+++ b/hw/xen/xen_pt_config_init.c
@@ -1418,7 +1418,7 @@ static int xen_pt_msixctrl_reg_init(XenPCIPassthroughState *s,
     reg_field = pci_get_word(d->config + real_offset);
 
     if (reg_field & PCI_MSIX_FLAGS_ENABLE) {
-        XEN_PT_LOG(d, "MSIX already enabled, disabling it first\n");
+        XEN_PT_LOG(&s->dev, "MSIX already enabled, disabling it first\n");
         xen_host_pci_set_word(&s->real_device, real_offset,
                               reg_field & ~PCI_MSIX_FLAGS_ENABLE);
     }
-- 
2.1.0

  parent reply	other threads:[~2015-07-02 19:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-02 19:31 [PATCH v1] Cleanups + various fixes due to libxl ABI + more logging on errors Konrad Rzeszutek Wilk
2015-07-02 19:31 ` [PATCH v1 1/6] xen/pt: Update comments with proper function name Konrad Rzeszutek Wilk
2015-07-02 19:31 ` [PATCH v1 2/6] xen/pt: Make xen_pt_msi_set_enable static Konrad Rzeszutek Wilk
2015-07-02 19:31 ` [PATCH v1 3/6] xen/pt: xen_host_pci_config_read returns -errno, not -1 on failure Konrad Rzeszutek Wilk
2015-07-02 19:31 ` [PATCH v1 4/6] xen: use errno instead of rc for xc_domain_add_to_physmap Konrad Rzeszutek Wilk
2015-07-17 15:22   ` Stefano Stabellini
2015-07-02 19:31 ` [PATCH v1 5/6] xen/pt/msi: Add the register value when printing logging and error messages Konrad Rzeszutek Wilk
2015-07-02 19:31 ` Konrad Rzeszutek Wilk [this message]
2015-07-17 15:29   ` [PATCH v1 6/6] xen/pt: Use XEN_PT_LOG properly to guard against compiler warnings Stefano Stabellini
     [not found] ` <1435865479-18329-6-git-send-email-konrad.wilk@oracle.com>
2015-07-17 15:26   ` [PATCH v1 5/6] xen/pt/msi: Add the register value when printing logging and error messages Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1435865479-18329-7-git-send-email-konrad.wilk@oracle.com \
    --to=konrad.wilk@oracle.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).