From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xensource.com
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH 2/5] xl: Command line: Remove maximum argument limit for network-attach
Date: Fri, 17 Jul 2015 18:00:48 +0100 [thread overview]
Message-ID: <1437152451-22507-2-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1437152451-22507-1-git-send-email-ian.jackson@eu.citrix.com>
This limit of 11 has been in this function since it was written, but
serves no purpose. The extra arguments are fed one by one to
parse_nic_config, and it is possible to have as many as you like.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
tools/libxl/xl_cmdimpl.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
index 55c041c..770b71c 100644
--- a/tools/libxl/xl_cmdimpl.c
+++ b/tools/libxl/xl_cmdimpl.c
@@ -6373,11 +6373,6 @@ int main_networkattach(int argc, char **argv)
/* No options */
}
- if (argc-optind > 11) {
- help("network-attach");
- return 0;
- }
-
domid = find_domain(argv[optind]);
config= xlu_cfg_init(stderr, "command line");
--
1.7.10.4
next prev parent reply other threads:[~2015-07-17 17:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 17:00 [PATCH 1/5] xl: Command line: Adjust "Fix segfaults from `xl psr-cat-cbm-set`..." Ian Jackson
2015-07-17 17:00 ` Ian Jackson [this message]
2015-07-20 10:00 ` [PATCH 2/5] xl: Command line: Remove maximum argument limit for network-attach Wei Liu
2015-07-17 17:00 ` [PATCH 3/5] xl: Command line: Support -h everywhere Ian Jackson
2015-07-20 10:06 ` Wei Liu
2015-07-17 17:00 ` [PATCH 4/5] xl: Command line: Make COMMON_LONG_OPTS include sentinel Ian Jackson
2015-07-17 17:09 ` Andrew Cooper
2015-07-17 17:11 ` Ian Jackson
2015-07-24 11:06 ` Ian Campbell
2015-07-17 17:00 ` [PATCH 5/5] xl: Command line: Support xl vcpu-set --help Ian Jackson
2015-07-20 10:07 ` Wei Liu
2015-07-17 17:04 ` [PATCH 1/5] xl: Command line: Adjust "Fix segfaults from `xl psr-cat-cbm-set`..." Andrew Cooper
2015-07-21 14:16 ` Ian Campbell
2015-07-21 14:27 ` Ian Jackson
2015-07-21 14:36 ` Wei Liu
2015-07-21 15:26 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437152451-22507-2-git-send-email-ian.jackson@eu.citrix.com \
--to=ian.jackson@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).