Re: [PATCH 4/5] xl: Command line: Make COMMON_LONG_OPTS include sentinel

From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xensource.com
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH 4/5] xl: Command line: Make COMMON_LONG_OPTS include sentinel
Date: Fri, 17 Jul 2015 18:09:59 +0100	[thread overview]
Message-ID: <55A936E7.6020908@citrix.com> (raw)
In-Reply-To: <1437152451-22507-4-git-send-email-ian.jackson@eu.citrix.com>

On 17/07/15 18:00, Ian Jackson wrote:
> No functional change.
>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> ---
>  tools/libxl/xl_cmdimpl.c |   51 ++++++++++++++++------------------------------
>  1 file changed, 18 insertions(+), 33 deletions(-)
>
> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> index 803c627..1fa98e6 100644
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -3025,7 +3025,8 @@ static int64_t parse_mem_size_kb(const char *mem)
>      return kbytes;
>  }
>  

Perhaps a comment stating that COMMON_LONG_OPTS must now be the final
entry in an option list?  Previously it was technically able to live
anywhere in the list.

~Andrew

> -#define COMMON_LONG_OPTS {"help", 0, 0, 'h'}
> +#define COMMON_LONG_OPTS {"help", 0, 0, 'h'}, \
> +                         {0, 0, 0, 0}
>  
>  /*
>   * Callers should use SWITCH_FOREACH_OPT in preference to calling this
>