From: Wei Liu <wei.liu2@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH for-4.6 03/13] xl/libxl: remove a bunch of pointless assignments
Date: Thu, 23 Jul 2015 08:59:04 +0100 [thread overview]
Message-ID: <1437638354-14216-4-git-send-email-wei.liu2@citrix.com> (raw)
In-Reply-To: <1437638354-14216-1-git-send-email-wei.liu2@citrix.com>
Those values are overwritten before they can be of any use.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
tools/libxl/libxl_dom.c | 2 +-
tools/libxl/libxl_remus_disk_drbd.c | 2 +-
tools/libxl/xl_cmdimpl.c | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
index edd7f3f..93ab8fe 100644
--- a/tools/libxl/libxl_dom.c
+++ b/tools/libxl/libxl_dom.c
@@ -1686,7 +1686,7 @@ void libxl__domain_save(libxl__egc *egc, libxl__domain_suspend_state *dss)
{
STATE_AO_GC(dss->ao);
int port;
- int rc = ERROR_FAIL;
+ int rc;
/* Convenience aliases */
const uint32_t domid = dss->domid;
diff --git a/tools/libxl/libxl_remus_disk_drbd.c b/tools/libxl/libxl_remus_disk_drbd.c
index fc76b89..1c3a88a 100644
--- a/tools/libxl/libxl_remus_disk_drbd.c
+++ b/tools/libxl/libxl_remus_disk_drbd.c
@@ -47,7 +47,7 @@ static void drbd_async_call(libxl__egc *egc,
void func(libxl__remus_device *),
libxl__ev_child_callback callback)
{
- int pid = -1, rc;
+ int pid, rc;
libxl__ao_device *aodev = &dev->aodev;
STATE_AO_GC(dev->rds->ao);
diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
index 5c6d1b0..5c74a73 100644
--- a/tools/libxl/xl_cmdimpl.c
+++ b/tools/libxl/xl_cmdimpl.c
@@ -4037,7 +4037,7 @@ static pid_t create_migration_child(const char *rune, int *send_fd,
int *recv_fd)
{
int sendpipe[2], recvpipe[2];
- pid_t child = -1;
+ pid_t child;
if (!rune || !send_fd || !recv_fd)
return -1;
@@ -7788,7 +7788,7 @@ int main_getenforce(int argc, char **argv)
int main_setenforce(int argc, char **argv)
{
- int ret, mode = -1;
+ int ret, mode;
const char *p = NULL;
if (optind >= argc) {
--
1.9.1
next prev parent reply other threads:[~2015-07-23 7:59 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 7:59 [PATCH for-4.6 00/13] tools: fixes inspired by Coverity scan Wei Liu
2015-07-23 7:59 ` [PATCH for-4.6 01/13] libxl: use thread-safe localtime_t and handle NULL Wei Liu
2015-07-23 9:14 ` Ian Campbell
2015-07-23 9:34 ` Wei Liu
2015-07-23 7:59 ` [PATCH for-4.6 02/13] libxl: properly clean up array in libxl_list_cpupool failure path Wei Liu
2015-07-23 9:22 ` Ian Campbell
2015-07-23 14:29 ` Dario Faggioli
2015-07-23 7:59 ` Wei Liu [this message]
2015-07-23 9:25 ` [PATCH for-4.6 03/13] xl/libxl: remove a bunch of pointless assignments Ian Campbell
2015-07-23 7:59 ` [PATCH for-4.6 04/13] xl: free pid string in do_daemonize Wei Liu
2015-07-23 9:34 ` Ian Campbell
2015-07-23 7:59 ` [PATCH for-4.6 05/13] xl: check json string is not null before printing in create_domain Wei Liu
2015-07-23 9:36 ` Ian Campbell
2015-07-23 7:59 ` [PATCH for-4.6 06/13] xl: call libxl_dominfo_{init, dispose} in psr_cmt_show Wei Liu
2015-07-23 9:36 ` Ian Campbell
2015-07-23 7:59 ` [PATCH for-4.6 07/13] xl: call libxl_dominfo_{init, dispose} in main_cpupoolnumasplit Wei Liu
2015-07-23 9:41 ` Ian Campbell
2015-07-23 10:34 ` Wei Liu
2015-07-23 7:59 ` [PATCH for-4.6 08/13] xl: call libxl_dominfo_init in main_list Wei Liu
2015-07-23 9:44 ` Ian Campbell
2015-07-23 7:59 ` [PATCH for-4.6 09/13] xl: call libxl_bitmap_{init, dispose} in main_cpupoolcreate Wei Liu
2015-07-23 9:46 ` Ian Campbell
2015-07-23 7:59 ` [PATCH for-4.6 10/13] xl: valid fd can be 0 in main_loadpolicy Wei Liu
2015-07-23 9:48 ` Ian Campbell
2015-07-23 7:59 ` [PATCH for-4.6 11/13] xl: free event struct after use in main_shutdown_or_reboot Wei Liu
2015-07-23 9:52 ` Ian Campbell
2015-07-23 7:59 ` [PATCH for-4.6 12/13] tools/ocaml: call libxl_dominfo_{init, dispose} in stub Wei Liu
2015-07-23 8:32 ` Andrew Cooper
2015-07-23 8:38 ` Wei Liu
2015-07-23 9:07 ` Andrew Cooper
2015-07-23 9:55 ` Ian Campbell
2015-07-23 10:00 ` Andrew Cooper
2015-07-23 7:59 ` [PATCH for-4.6 13/13] tools/ocaml: handle strdup failure in stub_xl_device_disk_of_vdev Wei Liu
2015-07-23 8:38 ` Andrew Cooper
2015-07-23 9:12 ` Dave Scott
2015-07-23 9:06 ` Dave Scott
2015-07-24 11:06 ` [PATCH for-4.6 00/13] tools: fixes inspired by Coverity scan Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437638354-14216-4-git-send-email-wei.liu2@citrix.com \
--to=wei.liu2@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).