xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>
Subject: [OSSTEST PATCH 01/10] Flight restriction: Move $maxflight to Osstest::Executive
Date: Thu, 23 Jul 2015 19:19:15 +0100	[thread overview]
Message-ID: <1437675564-16602-2-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1437675564-16602-1-git-send-email-ian.jackson@eu.citrix.com>

We are going to move the interpretation of --max-flight into
Osstest::Executive.  Start this by making $maxflight shared between
Executive and the main program.  Later, we will make it no longer
exported.

There are a number of places in Executive where a `my' variable
$maxflight shadows the newly moved global.  These will be got rid of
later, too.

No functional change.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
 Osstest/Executive.pm   |    3 +++
 sg-report-flight       |    2 --
 sg-report-host-history |    1 -
 sg-report-job-history  |    1 -
 4 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm
index ecd38c3..ec41ca1 100644
--- a/Osstest/Executive.pm
+++ b/Osstest/Executive.pm
@@ -46,6 +46,7 @@ BEGIN {
     @ISA         = qw(Exporter);
     @EXPORT      = qw(get_harness_rev grabrepolock_reexec
                       findtask @all_lock_tables
+                      $maxflight
                       report_run_getinfo report_altcolour
                       report_blessingscond report_find_push_age_info
                       tcpconnect_queuedaemon plan_search
@@ -193,6 +194,8 @@ sub opendb ($) {
 
 #---------- history reporting ----------
 
+our $maxflight;
+
 our $green=  '#008800';
 our $red=    '#ff8888';
 our $yellow= '#ffff00';
diff --git a/sg-report-flight b/sg-report-flight
index e6ca38c..018e8e2 100755
--- a/sg-report-flight
+++ b/sg-report-flight
@@ -45,8 +45,6 @@ our (@includebeginfiles,@includefiles);
 open DEBUG, ">/dev/null";
 open MRO, ">/dev/null";
 
-our $maxflight;
-
 while (@ARGV && $ARGV[0] =~ m/^-/) {
     $_= shift @ARGV;
     last if m/^--?$/;
diff --git a/sg-report-host-history b/sg-report-host-history
index 8e0e2aa..be51483 100755
--- a/sg-report-host-history
+++ b/sg-report-host-history
@@ -31,7 +31,6 @@ our $limit= 200;
 our $flightlimit;
 our $htmlout = ".";
 our @blessings;
-our $maxflight;
 
 open DEBUG, ">/dev/null";
 
diff --git a/sg-report-job-history b/sg-report-job-history
index e20c376..358c949 100755
--- a/sg-report-job-history
+++ b/sg-report-job-history
@@ -29,7 +29,6 @@ use Osstest::Executive;
 our (@blessings,@branches);
 our $limit= 100;
 our $htmlout;
-our $maxflight;
 our $flight;
 our $job;
 
-- 
1.7.10.4

  reply	other threads:[~2015-07-23 18:20 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-23 18:19 [OSSTEST PATCH 00/10] Bisection fix and reporting improvements Ian Jackson
2015-07-23 18:19 ` Ian Jackson [this message]
2015-07-24  9:20   ` [OSSTEST PATCH 01/10] Flight restriction: Move $maxflight to Osstest::Executive Ian Campbell
2015-07-23 18:19 ` [OSSTEST PATCH 02/10] Flight restriction: Introduce restrictflight_arg and restrictflight_cond Ian Jackson
2015-07-24  9:21   ` Ian Campbell
2015-07-23 18:19 ` [OSSTEST PATCH 03/10] Flight restriction: Update cs-bisection-step Ian Jackson
2015-07-24  9:21   ` Ian Campbell
2015-07-23 18:19 ` [OSSTEST PATCH 04/10] Flight restriction: Update sg-report-flight and sg-report-job-history Ian Jackson
2015-07-24  9:22   ` Ian Campbell
2015-07-23 18:19 ` [OSSTEST PATCH 05/10] Flight restriction: Make report_blessingscond use implicit $maxflight Ian Jackson
2015-07-24  9:24   ` Ian Campbell
2015-07-23 18:19 ` [OSSTEST PATCH 06/10] Flight restriction: Change implementation of --max-flight Ian Jackson
2015-07-24  9:24   ` Ian Campbell
2015-07-23 18:19 ` [OSSTEST PATCH 07/10] Flight restriction: Honour --exclude-flights=F1, F2, Ian Jackson
2015-07-24  9:25   ` Ian Campbell
2015-07-23 18:19 ` [OSSTEST PATCH 08/10] cs-bisection-step: Fix memoisation of search_compute_length_at Ian Jackson
2015-07-24  9:26   ` Ian Campbell
2015-07-24 10:57     ` Ian Jackson
2015-07-24 11:09       ` Ian Campbell
2015-07-23 18:19 ` [OSSTEST PATCH 09/10] sg-report-job-history: Introduce report_altchangecolour Ian Jackson
2015-07-24  9:27   ` Ian Campbell
2015-07-23 18:19 ` [OSSTEST PATCH 10/10] sg-report-job-history: Colour host column according to whether it changes Ian Jackson
2015-07-24  9:28   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1437675564-16602-2-git-send-email-ian.jackson@eu.citrix.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).