From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Ian Campbell <ian.campbell@citrix.com>
Subject: [OSSTEST PATCH 06/10] Flight restriction: Change implementation of --max-flight
Date: Thu, 23 Jul 2015 19:19:20 +0100 [thread overview]
Message-ID: <1437675564-16602-7-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1437675564-16602-1-git-send-email-ian.jackson@eu.citrix.com>
Abolish $maxflight. All the users outside Osstest::Executive have
been eliminated, so this is fine. Replace it with
$restrictflight_cond, which can accumulate multiple conditions.
There is a minor functional change: when multiple --max-flight options
are specified, _all_ of them take effect (effectively using the lowest
value). That option is not used in production, and I don't expect
people elsewhere to be passing multiple different such options.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
Osstest/Executive.pm | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm
index a1bc0ad..b8ab5cd 100644
--- a/Osstest/Executive.pm
+++ b/Osstest/Executive.pm
@@ -47,7 +47,6 @@ BEGIN {
@EXPORT = qw(get_harness_rev grabrepolock_reexec
findtask @all_lock_tables
restrictflight_arg restrictflight_cond
- $maxflight
report_run_getinfo report_altcolour
report_blessingscond report_find_push_age_info
tcpconnect_queuedaemon plan_search
@@ -195,12 +194,12 @@ sub opendb ($) {
#---------- history reporting ----------
-our $maxflight;
+our $restrictflight_cond = 'TRUE';
sub restrictflight_arg ($) {
my ($arg) = @_;
if ($arg =~ m/^--max-flight\=([1-9]\d*)$/) {
- $maxflight = $1;
+ $restrictflight_cond .= " AND flight <= $1";
return 1;
} else {
return 0;
@@ -208,7 +207,7 @@ sub restrictflight_arg ($) {
}
sub restrictflight_cond () {
- return defined($maxflight) ? "(flight <= $maxflight)" : "TRUE";
+ return "($restrictflight_cond)";
}
our $green= '#008800';
--
1.7.10.4
next prev parent reply other threads:[~2015-07-23 18:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 18:19 [OSSTEST PATCH 00/10] Bisection fix and reporting improvements Ian Jackson
2015-07-23 18:19 ` [OSSTEST PATCH 01/10] Flight restriction: Move $maxflight to Osstest::Executive Ian Jackson
2015-07-24 9:20 ` Ian Campbell
2015-07-23 18:19 ` [OSSTEST PATCH 02/10] Flight restriction: Introduce restrictflight_arg and restrictflight_cond Ian Jackson
2015-07-24 9:21 ` Ian Campbell
2015-07-23 18:19 ` [OSSTEST PATCH 03/10] Flight restriction: Update cs-bisection-step Ian Jackson
2015-07-24 9:21 ` Ian Campbell
2015-07-23 18:19 ` [OSSTEST PATCH 04/10] Flight restriction: Update sg-report-flight and sg-report-job-history Ian Jackson
2015-07-24 9:22 ` Ian Campbell
2015-07-23 18:19 ` [OSSTEST PATCH 05/10] Flight restriction: Make report_blessingscond use implicit $maxflight Ian Jackson
2015-07-24 9:24 ` Ian Campbell
2015-07-23 18:19 ` Ian Jackson [this message]
2015-07-24 9:24 ` [OSSTEST PATCH 06/10] Flight restriction: Change implementation of --max-flight Ian Campbell
2015-07-23 18:19 ` [OSSTEST PATCH 07/10] Flight restriction: Honour --exclude-flights=F1, F2, Ian Jackson
2015-07-24 9:25 ` Ian Campbell
2015-07-23 18:19 ` [OSSTEST PATCH 08/10] cs-bisection-step: Fix memoisation of search_compute_length_at Ian Jackson
2015-07-24 9:26 ` Ian Campbell
2015-07-24 10:57 ` Ian Jackson
2015-07-24 11:09 ` Ian Campbell
2015-07-23 18:19 ` [OSSTEST PATCH 09/10] sg-report-job-history: Introduce report_altchangecolour Ian Jackson
2015-07-24 9:27 ` Ian Campbell
2015-07-23 18:19 ` [OSSTEST PATCH 10/10] sg-report-job-history: Colour host column according to whether it changes Ian Jackson
2015-07-24 9:28 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437675564-16602-7-git-send-email-ian.jackson@eu.citrix.com \
--to=ian.jackson@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).