From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Cc: Dario Faggioli <dario.faggioli@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH for-4.6 v2 1/8] libxl: properly clean up array in libxl_list_cpupool failure path
Date: Tue, 28 Jul 2015 11:27:07 +0100 [thread overview]
Message-ID: <1438079227.11600.114.camel@citrix.com> (raw)
In-Reply-To: <1438019109-31997-2-git-send-email-wei.liu2@citrix.com>
On Mon, 2015-07-27 at 18:45 +0100, Wei Liu wrote:
> Document how cpupool_info works. Distinguish success (ERROR_FAIL +
> ENOENT) vs failure in libxl_list_cpupool and properly clean up the array
> in failure path.
>
> Also switch to libxl__realloc and call libxl_cpupool_{init,dispose}
> where appropriate.
>
> There is change of behaviour. Previously if memory allocation fails the
> said function returns NULL. Now memory allocation failure is fatal. This
> is in line with how we deal with memory allocation failure in other
> places in libxl though.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
next prev parent reply other threads:[~2015-07-28 10:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-27 17:45 [PATCH for-4.6 v2 0/8] tools: fixes inspired by Coverity scan Wei Liu
2015-07-27 17:45 ` [PATCH for-4.6 v2 1/8] libxl: properly clean up array in libxl_list_cpupool failure path Wei Liu
2015-07-28 8:39 ` Dario Faggioli
2015-07-28 10:27 ` Ian Campbell [this message]
2015-07-27 17:45 ` [PATCH for-4.6 v2 2/8] xl: lockdir should be lockfile in error message Wei Liu
2015-07-28 10:27 ` Ian Campbell
2015-07-27 17:45 ` [PATCH for-4.6 v2 3/8] xl: call libxl_dominfo_init in main_list Wei Liu
2015-07-28 10:28 ` Ian Campbell
2015-07-27 17:45 ` [PATCH for-4.6 v2 4/8] xl: valid fd can be 0 in main_loadpolicy Wei Liu
2015-07-28 10:28 ` Ian Campbell
2015-07-27 17:45 ` [PATCH for-4.6 v2 5/8] xl: call libxl_dominfo_{init, dispose} in main_cpupoolnumasplit Wei Liu
2015-07-28 9:49 ` Dario Faggioli
2015-07-28 10:33 ` Ian Campbell
2015-07-27 17:45 ` [PATCH for-4.6 v2 6/8] libxlu: free buffer in failure path for PCI related functions Wei Liu
2015-07-28 10:35 ` Ian Campbell
2015-07-27 17:45 ` [PATCH for-4.6 v2 7/8] python/xc: reinstate original implementation of next_bdf Wei Liu
2015-07-27 22:58 ` Andrew Cooper
2015-07-28 1:06 ` Chen, Tiejun
2015-07-28 10:38 ` Ian Campbell
2015-07-28 10:44 ` Wei Liu
2015-07-27 17:45 ` [PATCH for-4.6 v2 8/8] libxl: remove dead code libxl__domain_shutdown_reason Wei Liu
2015-07-28 10:52 ` Ian Campbell
2015-07-28 11:08 ` [PATCH for-4.6 v2 0/8] tools: fixes inspired by Coverity scan Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438079227.11600.114.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).