xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH for 4-7] xenalyze: fix a spurious newline
@ 2016-05-19  4:04 Dario Faggioli
  2016-05-19  4:04 ` [PATCH] " Dario Faggioli
  0 siblings, 1 reply; 4+ messages in thread
From: Dario Faggioli @ 2016-05-19  4:04 UTC (permalink / raw)
  To: xen-devel; +Cc: George Dunlap, Wei Liu, Ian Jackson

Hey Wei,

I know where we stand in the release process, but the patch is so trivial and
free of risks, and the trace output, with the spurious newline, so disturbing,
that I think this should go in.

Regards,
Dario
---

Dario Faggioli (1):
      xenalyze: fix a spurious newline

 tools/xentrace/xenalyze.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] xenalyze: fix a spurious newline
  2016-05-19  4:04 [PATCH for 4-7] xenalyze: fix a spurious newline Dario Faggioli
@ 2016-05-19  4:04 ` Dario Faggioli
  2016-05-19  9:07   ` George Dunlap
  0 siblings, 1 reply; 4+ messages in thread
From: Dario Faggioli @ 2016-05-19  4:04 UTC (permalink / raw)
  To: xen-devel; +Cc: George Dunlap, Wei Liu, Ian Jackson

in dump mode, when tracing context switches.

Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
---
Cc: George Dunlap <george.dunlap@eu.citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
---
 tools/xentrace/xenalyze.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c
index b949986..01ead8b 100644
--- a/tools/xentrace/xenalyze.c
+++ b/tools/xentrace/xenalyze.c
@@ -7655,7 +7655,7 @@ void sched_process(struct pcpu_info *p)
                     printf(", was runnable for %u.%uus, ", r->rsince / 1000,
                            r->rsince % 1000);
                 if ( r->slice > 0 )
-                    printf("next slice %u.%uus\n", r->slice / 1000,
+                    printf("next slice %u.%uus", r->slice / 1000,
                            r->slice % 1000);
                 printf("\n");
             }


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] xenalyze: fix a spurious newline
  2016-05-19  4:04 ` [PATCH] " Dario Faggioli
@ 2016-05-19  9:07   ` George Dunlap
  2016-05-19  9:19     ` Wei Liu
  0 siblings, 1 reply; 4+ messages in thread
From: George Dunlap @ 2016-05-19  9:07 UTC (permalink / raw)
  To: Dario Faggioli, xen-devel; +Cc: George Dunlap, Wei Liu, Ian Jackson

On 19/05/16 05:04, Dario Faggioli wrote:
> in dump mode, when tracing context switches.
> 
> Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>

Acked-by: George Dunlap <george.dunlap@citrix.com>

> ---
> Cc: George Dunlap <george.dunlap@eu.citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> ---
>  tools/xentrace/xenalyze.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c
> index b949986..01ead8b 100644
> --- a/tools/xentrace/xenalyze.c
> +++ b/tools/xentrace/xenalyze.c
> @@ -7655,7 +7655,7 @@ void sched_process(struct pcpu_info *p)
>                      printf(", was runnable for %u.%uus, ", r->rsince / 1000,
>                             r->rsince % 1000);
>                  if ( r->slice > 0 )
> -                    printf("next slice %u.%uus\n", r->slice / 1000,
> +                    printf("next slice %u.%uus", r->slice / 1000,
>                             r->slice % 1000);
>                  printf("\n");
>              }
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] xenalyze: fix a spurious newline
  2016-05-19  9:07   ` George Dunlap
@ 2016-05-19  9:19     ` Wei Liu
  0 siblings, 0 replies; 4+ messages in thread
From: Wei Liu @ 2016-05-19  9:19 UTC (permalink / raw)
  To: George Dunlap
  Cc: George Dunlap, xen-devel, Dario Faggioli, Ian Jackson, Wei Liu

On Thu, May 19, 2016 at 10:07:44AM +0100, George Dunlap wrote:
> On 19/05/16 05:04, Dario Faggioli wrote:
> > in dump mode, when tracing context switches.
> > 
> > Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
> 
> Acked-by: George Dunlap <george.dunlap@citrix.com>
> 

Ack and queued.

> > ---
> > Cc: George Dunlap <george.dunlap@eu.citrix.com>
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > Cc: Wei Liu <wei.liu2@citrix.com>
> > ---
> >  tools/xentrace/xenalyze.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c
> > index b949986..01ead8b 100644
> > --- a/tools/xentrace/xenalyze.c
> > +++ b/tools/xentrace/xenalyze.c
> > @@ -7655,7 +7655,7 @@ void sched_process(struct pcpu_info *p)
> >                      printf(", was runnable for %u.%uus, ", r->rsince / 1000,
> >                             r->rsince % 1000);
> >                  if ( r->slice > 0 )
> > -                    printf("next slice %u.%uus\n", r->slice / 1000,
> > +                    printf("next slice %u.%uus", r->slice / 1000,
> >                             r->slice % 1000);
> >                  printf("\n");
> >              }
> > 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-05-19  9:19 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-19  4:04 [PATCH for 4-7] xenalyze: fix a spurious newline Dario Faggioli
2016-05-19  4:04 ` [PATCH] " Dario Faggioli
2016-05-19  9:07   ` George Dunlap
2016-05-19  9:19     ` Wei Liu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).