From: Dario Faggioli <dario.faggioli@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>,
Stefano Stabellini <sstabellini@kernel.org>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH 3/3] libxl: update vcpus bitmap in retrieved guest config
Date: Tue, 7 Jun 2016 19:05:04 +0200 [thread overview]
Message-ID: <1465319104.15816.172.camel@citrix.com> (raw)
In-Reply-To: <20160607164627.GU25922@citrix.com>
[-- Attachment #1.1: Type: text/plain, Size: 1020 bytes --]
On Tue, 2016-06-07 at 17:46 +0100, Wei Liu wrote:
> > > I agree it would be good to set the exact bits though -- if you
> > > can
> > > tell
> > > me which field to test.
> > >
> > Perhaps at least mention something about all this either in a
> > comment
> > or in the changelog?
> >
> What would you like to see in a comment? I guess this is now moot
> because the exact bits will be set.
>
Well, if the code ends up looking like:
"the most correct thing would be to set the proper bits, but it's
hard/cumbersome/unknown how to do so, and setting all up until count it
enough for making things work"
Then, exactly that. :-)
If the code does the most correct thing already, as you seem to say,
then nothing.
Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-07 17:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 11:23 [PATCH 0/3] libxl: update available vcpus map in retrieve configuration function Wei Liu
2016-06-07 11:24 ` [PATCH 1/3] libxl: introduce libxl__json_array_count Wei Liu
2016-06-07 11:24 ` [PATCH 2/3] libxl: introduce libxl__qmp_query_cpus Wei Liu
2016-06-07 11:24 ` [PATCH 3/3] libxl: update vcpus bitmap in retrieved guest config Wei Liu
2016-06-07 14:45 ` Anthony PERARD
2016-06-07 16:03 ` Wei Liu
2016-06-07 16:22 ` Dario Faggioli
2016-06-07 16:46 ` Wei Liu
2016-06-07 17:05 ` Dario Faggioli [this message]
2016-06-07 16:36 ` Anthony PERARD
2016-06-07 16:39 ` Wei Liu
2016-06-14 16:31 ` Ian Jackson
2016-06-14 16:39 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465319104.15816.172.camel@citrix.com \
--to=dario.faggioli@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=anthony.perard@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).