[PATCH v1 0/1] xen/arm: Disable the Cortex-a53-edac

[PATCH v1 0/1] xen/arm: Disable the Cortex-a53-edac

[Edgar E. Iglesias]

From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>

The Cortex-A53 EDAC (Error Detection And Correction) Linux driver
uses the implementation defined CPUMERRSR register.
Xen traps but does not yet handle accesses to this reg so dom0 panics
on an undefined instruction at boot.

For Xen-4.8, this patchs disables the A53 EDAC module by removing it from
the device tree.

For Xen-4.9 we may want to allow dom0 to access these regs.

Comments welcome!

Best regards,
Edgar

Edgar E. Iglesias (1):
  xen/arm: Disable the Cortex-a53-edac

 xen/arch/arm/domain_build.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.5.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[PATCH v1 1/1] xen/arm: Disable the Cortex-a53-edac

[Edgar E. Iglesias]

From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>

Disable the Cortex-a53-edac. Xen currently does not yet
handle reads/writes to the implementation defined CPUMERRSR
register.

Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
---
 xen/arch/arm/domain_build.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index ce97359..e8a400c 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -1188,6 +1188,7 @@ static int handle_node(struct domain *d, struct kernel_info *kinfo,
         DT_MATCH_COMPATIBLE("arm,psci-1.0"),
         DT_MATCH_COMPATIBLE("arm,cortex-a7-pmu"),
         DT_MATCH_COMPATIBLE("arm,cortex-a15-pmu"),
+        DT_MATCH_COMPATIBLE("arm,cortex-a53-edac"),
         DT_MATCH_COMPATIBLE("arm,armv8-pmuv3"),
         DT_MATCH_PATH("/cpus"),
         DT_MATCH_TYPE("memory"),
-- 
2.5.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH v1 1/1] xen/arm: Disable the Cortex-a53-edac

[Alistair Francis]

On Thu, Oct 6, 2016 at 9:36 AM, Edgar E. Iglesias
<edgar.iglesias@gmail.com> wrote:
> From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
>
> Disable the Cortex-a53-edac. Xen currently does not yet
> handle reads/writes to the implementation defined CPUMERRSR
> register.
>
> Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>

This solution looks fine to me and everything boots on ZynqMP as
expected with this patch.

Acked-by: Alistair Francis <alistair.francis@xilinx.com>

Thanks,

Alistair


> ---
>  xen/arch/arm/domain_build.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index ce97359..e8a400c 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -1188,6 +1188,7 @@ static int handle_node(struct domain *d, struct kernel_info *kinfo,
>          DT_MATCH_COMPATIBLE("arm,psci-1.0"),
>          DT_MATCH_COMPATIBLE("arm,cortex-a7-pmu"),
>          DT_MATCH_COMPATIBLE("arm,cortex-a15-pmu"),
> +        DT_MATCH_COMPATIBLE("arm,cortex-a53-edac"),
>          DT_MATCH_COMPATIBLE("arm,armv8-pmuv3"),
>          DT_MATCH_PATH("/cpus"),
>          DT_MATCH_TYPE("memory"),
> --
> 2.5.0
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH v1 1/1] xen/arm: Disable the Cortex-a53-edac

[Stefano Stabellini]

On Fri, 7 Oct 2016, Alistair Francis wrote:
> On Thu, Oct 6, 2016 at 9:36 AM, Edgar E. Iglesias
> <edgar.iglesias@gmail.com> wrote:
> > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
> >
> > Disable the Cortex-a53-edac. Xen currently does not yet
> > handle reads/writes to the implementation defined CPUMERRSR
> > register.
> >
> > Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> 
> This solution looks fine to me and everything boots on ZynqMP as
> expected with this patch.
> 
> Acked-by: Alistair Francis <alistair.francis@xilinx.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

Wei, can we have this in 4.8? See the 0/1 email for an explanation of
why this change is needed. The patch just adds the troublesome
cortex-a15-pmu to the "skip_matches" array to remove it from dom0's
device tree.


> > ---
> >  xen/arch/arm/domain_build.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> > index ce97359..e8a400c 100644
> > --- a/xen/arch/arm/domain_build.c
> > +++ b/xen/arch/arm/domain_build.c
> > @@ -1188,6 +1188,7 @@ static int handle_node(struct domain *d, struct kernel_info *kinfo,
> >          DT_MATCH_COMPATIBLE("arm,psci-1.0"),
> >          DT_MATCH_COMPATIBLE("arm,cortex-a7-pmu"),
> >          DT_MATCH_COMPATIBLE("arm,cortex-a15-pmu"),
> > +        DT_MATCH_COMPATIBLE("arm,cortex-a53-edac"),
> >          DT_MATCH_COMPATIBLE("arm,armv8-pmuv3"),
> >          DT_MATCH_PATH("/cpus"),
> >          DT_MATCH_TYPE("memory"),
> > --
> > 2.5.0
> >
> >
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xen.org
> > https://lists.xen.org/xen-devel
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH v1 1/1] xen/arm: Disable the Cortex-a53-edac

[Wei Liu]

On Fri, Oct 07, 2016 at 10:34:15AM -0700, Stefano Stabellini wrote:
> On Fri, 7 Oct 2016, Alistair Francis wrote:
> > On Thu, Oct 6, 2016 at 9:36 AM, Edgar E. Iglesias
> > <edgar.iglesias@gmail.com> wrote:
> > > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
> > >
> > > Disable the Cortex-a53-edac. Xen currently does not yet
> > > handle reads/writes to the implementation defined CPUMERRSR
> > > register.
> > >
> > > Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> > 
> > This solution looks fine to me and everything boots on ZynqMP as
> > expected with this patch.
> > 
> > Acked-by: Alistair Francis <alistair.francis@xilinx.com>
> 
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> 
> Wei, can we have this in 4.8? See the 0/1 email for an explanation of
> why this change is needed. The patch just adds the troublesome
> cortex-a15-pmu to the "skip_matches" array to remove it from dom0's
> device tree.
> 

Sure.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH v1 1/1] xen/arm: Disable the Cortex-a53-edac

[Edgar E. Iglesias]

On Fri, Oct 07, 2016 at 07:22:33PM +0100, Wei Liu wrote:
> On Fri, Oct 07, 2016 at 10:34:15AM -0700, Stefano Stabellini wrote:
> > On Fri, 7 Oct 2016, Alistair Francis wrote:
> > > On Thu, Oct 6, 2016 at 9:36 AM, Edgar E. Iglesias
> > > <edgar.iglesias@gmail.com> wrote:
> > > > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
> > > >
> > > > Disable the Cortex-a53-edac. Xen currently does not yet
> > > > handle reads/writes to the implementation defined CPUMERRSR
> > > > register.
> > > >
> > > > Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> > > 
> > > This solution looks fine to me and everything boots on ZynqMP as
> > > expected with this patch.
> > > 
> > > Acked-by: Alistair Francis <alistair.francis@xilinx.com>
> > 
> > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> > 
> > Wei, can we have this in 4.8? See the 0/1 email for an explanation of
> > why this change is needed. The patch just adds the troublesome
> > cortex-a15-pmu to the "skip_matches" array to remove it from dom0's
> > device tree.
> > 
> 
> Sure.


Hi Wei,

Just a friendly reminder:
This is still missing from master, staging and 4.8.0-rc2.

Best regards,
Edgar

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH v1 1/1] xen/arm: Disable the Cortex-a53-edac

[Wei Liu]

On Wed, Oct 12, 2016 at 03:23:43PM +0200, Edgar E. Iglesias wrote:
> On Fri, Oct 07, 2016 at 07:22:33PM +0100, Wei Liu wrote:
> > On Fri, Oct 07, 2016 at 10:34:15AM -0700, Stefano Stabellini wrote:
> > > On Fri, 7 Oct 2016, Alistair Francis wrote:
> > > > On Thu, Oct 6, 2016 at 9:36 AM, Edgar E. Iglesias
> > > > <edgar.iglesias@gmail.com> wrote:
> > > > > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
> > > > >
> > > > > Disable the Cortex-a53-edac. Xen currently does not yet
> > > > > handle reads/writes to the implementation defined CPUMERRSR
> > > > > register.
> > > > >
> > > > > Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> > > > 
> > > > This solution looks fine to me and everything boots on ZynqMP as
> > > > expected with this patch.
> > > > 
> > > > Acked-by: Alistair Francis <alistair.francis@xilinx.com>
> > > 
> > > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> > > 
> > > Wei, can we have this in 4.8? See the 0/1 email for an explanation of
> > > why this change is needed. The patch just adds the troublesome
> > > cortex-a15-pmu to the "skip_matches" array to remove it from dom0's
> > > device tree.
> > > 
> > 
> > Sure.
> 
> 
> Hi Wei,
> 
> Just a friendly reminder:
> This is still missing from master, staging and 4.8.0-rc2.
> 

I thought Stefano would do it. 

I will apply this shortly. Thanks for the heads-up.

Wei.

> Best regards,
> Edgar

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH v1 1/1] xen/arm: Disable the Cortex-a53-edac

[Wei Liu]

On Wed, Oct 12, 2016 at 02:47:18PM +0100, Wei Liu wrote:
> On Wed, Oct 12, 2016 at 03:23:43PM +0200, Edgar E. Iglesias wrote:
> > On Fri, Oct 07, 2016 at 07:22:33PM +0100, Wei Liu wrote:
> > > On Fri, Oct 07, 2016 at 10:34:15AM -0700, Stefano Stabellini wrote:
> > > > On Fri, 7 Oct 2016, Alistair Francis wrote:
> > > > > On Thu, Oct 6, 2016 at 9:36 AM, Edgar E. Iglesias
> > > > > <edgar.iglesias@gmail.com> wrote:
> > > > > > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
> > > > > >
> > > > > > Disable the Cortex-a53-edac. Xen currently does not yet
> > > > > > handle reads/writes to the implementation defined CPUMERRSR
> > > > > > register.
> > > > > >
> > > > > > Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> > > > > 
> > > > > This solution looks fine to me and everything boots on ZynqMP as
> > > > > expected with this patch.
> > > > > 
> > > > > Acked-by: Alistair Francis <alistair.francis@xilinx.com>
> > > > 
> > > > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> > > > 
> > > > Wei, can we have this in 4.8? See the 0/1 email for an explanation of
> > > > why this change is needed. The patch just adds the troublesome
> > > > cortex-a15-pmu to the "skip_matches" array to remove it from dom0's
> > > > device tree.
> > > > 
> > > 
> > > Sure.
> > 
> > 
> > Hi Wei,
> > 
> > Just a friendly reminder:
> > This is still missing from master, staging and 4.8.0-rc2.
> > 
> 
> I thought Stefano would do it. 
> 
> I will apply this shortly. Thanks for the heads-up.
> 

Now applied.

Wei.

> Wei.
> 
> > Best regards,
> > Edgar

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH v1 1/1] xen/arm: Disable the Cortex-a53-edac

[Stefano Stabellini]

On Wed, 12 Oct 2016, Wei Liu wrote:
> On Wed, Oct 12, 2016 at 02:47:18PM +0100, Wei Liu wrote:
> > On Wed, Oct 12, 2016 at 03:23:43PM +0200, Edgar E. Iglesias wrote:
> > > On Fri, Oct 07, 2016 at 07:22:33PM +0100, Wei Liu wrote:
> > > > On Fri, Oct 07, 2016 at 10:34:15AM -0700, Stefano Stabellini wrote:
> > > > > On Fri, 7 Oct 2016, Alistair Francis wrote:
> > > > > > On Thu, Oct 6, 2016 at 9:36 AM, Edgar E. Iglesias
> > > > > > <edgar.iglesias@gmail.com> wrote:
> > > > > > > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
> > > > > > >
> > > > > > > Disable the Cortex-a53-edac. Xen currently does not yet
> > > > > > > handle reads/writes to the implementation defined CPUMERRSR
> > > > > > > register.
> > > > > > >
> > > > > > > Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> > > > > > 
> > > > > > This solution looks fine to me and everything boots on ZynqMP as
> > > > > > expected with this patch.
> > > > > > 
> > > > > > Acked-by: Alistair Francis <alistair.francis@xilinx.com>
> > > > > 
> > > > > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> > > > > 
> > > > > Wei, can we have this in 4.8? See the 0/1 email for an explanation of
> > > > > why this change is needed. The patch just adds the troublesome
> > > > > cortex-a15-pmu to the "skip_matches" array to remove it from dom0's
> > > > > device tree.
> > > > > 
> > > > 
> > > > Sure.
> > > 
> > > 
> > > Hi Wei,
> > > 
> > > Just a friendly reminder:
> > > This is still missing from master, staging and 4.8.0-rc2.
> > > 
> > 
> > I thought Stefano would do it. 
> > 
> > I will apply this shortly. Thanks for the heads-up.
> > 
> 
> Now applied.

Thanks Wei. They day I acked it, it was the day you asked not to commit,
then I forgot about it :-)

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel