From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: [OSSTEST PATCH 02/11] TestSupport: target_cmd_*: Add some doc comments
Date: Wed, 7 Jun 2017 18:48:53 +0100 [thread overview]
Message-ID: <1496857742-20191-3-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1496857742-20191-1-git-send-email-ian.jackson@eu.citrix.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
v4: Split off from the patch introducing target_cmd_output_root_status.
Rewrote all the comments to be true.
---
Osstest/TestSupport.pm | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
index c36dc76..f54962a 100644
--- a/Osstest/TestSupport.pm
+++ b/Osstest/TestSupport.pm
@@ -692,8 +692,18 @@ sub tcmd { # $tcmd will be put between '' but not escaped
'ssh', sshopts(), @{ $extrasshopts || [] },
sshuho($user,$ho), $tcmd);
}
+
+# target_cmd[_VARIANT]($ho, $cmd, [ $timeout, \@EXTRASSHOPTS ]);
+#
+# target_cmd executes $cmd with the shell as the osstest user on $ho.
+# stdout goes to our own stdout. dies if the command exits nonzero.
sub target_cmd ($$;$$) { tcmd(undef,undef,0, 'osstest',@_); }
+
+# Like target_cmd but as root.
sub target_cmd_root ($$;$$) { tcmd(undef,undef,0, 'root',@_); }
+
+# Like target_cmd_root, but does not die if the command fails.
+# Instead, returns the wait status (ie, what came in $?)
sub target_cmd_root_status ($$;$$) { tcmd(undef,undef,1, 'root',@_); }
sub tcmdout {
@@ -708,6 +718,7 @@ sub tcmdout {
return $r;
}
+# Like target_cmd[_root], but collect the stdout and return it as a string.
sub target_cmd_output ($$;$) { tcmdout('osstest',@_); }
sub target_cmd_output_root ($$;$) { tcmdout('root',@_); }
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-06-07 17:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 17:48 [OSSTEST PATCH v4 00/11] livepatch test support Ian Jackson
2017-06-07 17:48 ` [OSSTEST PATCH 01/11] TestSupport: target_cmd_root_status: New sub which returns return code Ian Jackson
2017-06-07 17:48 ` Ian Jackson [this message]
2017-06-07 17:48 ` [OSSTEST PATCH 03/11] TestSupport: target_cmd_output_root_status: New sub Ian Jackson
2017-06-07 17:48 ` [OSSTEST PATCH 04/11] mfi-common: Add an enable_livepatch runvar to the Xen build jobs Ian Jackson
2017-06-07 17:48 ` [OSSTEST PATCH 05/11] ts-xen-build: Build livepatches test-cases Ian Jackson
2017-06-07 17:48 ` [OSSTEST PATCH 06/11] ts-livepatch: Initial test-cases Ian Jackson
2017-06-07 17:48 ` [OSSTEST PATCH 07/11] sg-run-job: Add the test-livepatch Ian Jackson
2017-06-07 17:48 ` [OSSTEST PATCH 08/11] make-flight: Add livepatch build/test target in the matrix Ian Jackson
2017-06-07 17:49 ` [OSSTEST PATCH 09/11] PDU/lab: Similar to xenuse Ian Jackson
2017-06-07 17:49 ` [OSSTEST PATCH 10/11] cs-adjust-flight: Rework runvar-build-set new value handling Ian Jackson
2017-06-07 17:49 ` [OSSTEST PATCH 11/11] sg-check-tested: Provide --flight option Ian Jackson
2017-06-07 18:54 ` [OSSTEST PATCH v4 00/11] livepatch test support Ian Jackson
2017-06-08 0:50 ` Konrad Rzeszutek Wilk
2017-06-09 11:01 ` Ian Jackson
2017-06-11 0:19 ` Konrad Rzeszutek Wilk
2017-06-09 14:35 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496857742-20191-3-git-send-email-ian.jackson@eu.citrix.com \
--to=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).