Re: [OSSTEST PATCH v4 00/11] livepatch test support

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

On Wed, Jun 07, 2017 at 06:48:51PM +0100, Ian Jackson wrote:
> Thanks to Konrad, who passed me his git branch under the table.
> I have tidied up some loose ends, and tested it with my xen.git
> Makefile patches.

Yeey! Thank you for taking them over.
> 
> Konrad, would you please take a look at this to make sure you don't
> think I've broken anything and that my changes look sane ?  In

They look splendid!

> particlar the patches I have marked with `#' below.
> 
>  m  01   TestSupport: target_cmd_root_status: New sub which returns return code.
>  -  02   TestSupport: target_cmd_*: Add some doc comments
>  -  03   TestSupport: target_cmd_output_root_status: New sub
>  *# 04   mfi-common: Add an enable_livepatch runvar to the Xen build jobs
>  *# 05   ts-xen-build: Build livepatches test-cases

Both Reviewed-by (albeit they have my SoB so that is kind of silly, but
eh).

>  -  06   ts-livepatch: Initial test-cases.
>  -  07   sg-run-job: Add the test-livepatch.
>  m  08   make-flight: Add livepatch build/test target in the matrix.
>  *# 09   PDU/lab: Similar to xenuse

I would ditch that one. That 'lab' thing is what I use at home and
I am OK keeping it in my local branch.

>  +  10   cs-adjust-flight: Rework runvar-build-set new value handling
>  +  11   sg-check-tested: Provide --flight option
> 
> Key:
>  m   Changed only the commit message
>  -   Very minor changes
>  *   Actual changes
>  +   Added patch (not really related, TBH)
>   #  Konrad, please review this! 

Done. I am satisfied with them.
> (All compared to Konrad's v3)
> 
> Thanks,
> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel