From: Steven Haigh <netwiz@crc.id.au>
To: "YOUNG, MICHAEL A." <m.a.young@durham.ac.uk>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [Xen-devel] [PATCH] failing to set value to 0 in Grub2ConfigFile
Date: Wed, 14 Aug 2019 15:14:18 +1000 [thread overview]
Message-ID: <1565759658.2987.0@crc.id.au> (raw)
In-Reply-To: <alpine.LFD.2.21.1908132223440.3016@austen3.home>
I've had a tinker with the patch - I don't have a Fedora build system
atm - so I just edited the file on the Dom0 and removed the pyc/pyo
files. Same issue:
pyGRUB version 0.6
┌────────────────────────────────────────────────────────────────────────┐
│ Fedora (5.2.6-200.fc30.x86_64) 30 (Thirty)
│
│ Fedora (0-rescue-ee4b18b1898e4bf2b36ff71077b23b5e) 30 (Thirty)
│
│
│
│
│
│
│
│
│
│
│
│
│
└────────────────────────────────────────────────────────────────────────┘
Use the ^ and v keys to select which entry is highlighted.
Press enter to boot the selected OS, 'e' to edit the
commands before booting, 'a' to modify the kernel arguments
before booting, or 'c' for a command line.
The rescue entry is selected in the above example.
My crappy hack has been to edit /usr/libexec/xen/bin/pygrub and add
sel=0 as follows:
def image_index(self):
if isinstance(self.cf.default, int):
sel = self.cf.default
elif self.cf.default.isdigit():
sel = int(self.cf.default)
sel = 0
else:
I know this is horrible!
I'm still disabling BLSCFG in /etc/default/grub - otherwise the pygrub
menu is completely empty.
I don't know what the solution is right now - but I do somewhat agree
with ignoring anything inside an if statement in grub.cfg - as the
logic is ignored anyway. Do you still need to read the grubenv in doing
this?
I assume the read for grubenv is to get the 'saved_entry' value?
Steven Haigh
📧 netwiz@crc.id.au 💻 https://www.crc.id.au
📞 +613 9001 6090 📱 +614 1293 5897
On Wed, Aug 14, 2019 at 7:51 AM, "YOUNG, MICHAEL A."
<m.a.young@durham.ac.uk> wrote:
> On Tue, 13 Aug 2019, Andrew Cooper wrote:
>
>> On 13/08/2019 22:02, YOUNG, MICHAEL A. wrote:
>>> I have been looking at the pygrub code to see if it is possible to
>>> cope
>>> with grub files with BLSCFG and spotted this minor issue in
>>> GrubConf.py
>>> where the code intends to replace ${saved_entry} and ${next_entry}
>>> with 0
>>> but doesn't succeed.
>>>
>>> Signed-off-by: Michael Young <m.a.young@durham.ac.uk>
>>
>> Ah - this looks suspiciously like it might be the bugfix for an
>> issue
>> reported by Steven.
>>
>> Steven - do you mind giving this patch a try for your "Fedora 30
>> DomU -
>> pygrub always boots the second menu option" problem?
>
> Sadly I don't think it is that simple and to it properly would require
> parsing if clauses in the grub file and also reading variables from
> the
> grubenv file.
>
> I do however have an idea which might work which is to ignore
> anything in
> if clauses, read the grubenv file (which I now have a hacky way of
> doing)
> and treating the value of next_entry or saved_entry as the setting for
> the default kernel to pick. If I finish a patch that does this I will
> post
> it on the list, but I very much doubt it will be of commitable
> quality.
>
> Michael Young
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xenproject.org
> https://lists.xenproject.org/mailman/listinfo/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-08-14 5:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 21:02 [Xen-devel] [PATCH] failing to set value to 0 in Grub2ConfigFile YOUNG, MICHAEL A.
2019-08-13 21:09 ` Andrew Cooper
2019-08-13 21:51 ` YOUNG, MICHAEL A.
2019-08-14 5:14 ` Steven Haigh [this message]
2019-08-14 11:17 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1565759658.2987.0@crc.id.au \
--to=netwiz@crc.id.au \
--cc=andrew.cooper3@citrix.com \
--cc=m.a.young@durham.ac.uk \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).