From: "YOUNG, MICHAEL A." <m.a.young@durham.ac.uk>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Steven Haigh <netwiz@crc.id.au>
Subject: Re: [Xen-devel] [PATCH] failing to set value to 0 in Grub2ConfigFile
Date: Tue, 13 Aug 2019 21:51:18 +0000 [thread overview]
Message-ID: <alpine.LFD.2.21.1908132223440.3016@austen3.home> (raw)
In-Reply-To: <5d38908a-30b9-6ca6-c5de-f612679b2f0e@citrix.com>
On Tue, 13 Aug 2019, Andrew Cooper wrote:
> On 13/08/2019 22:02, YOUNG, MICHAEL A. wrote:
>> I have been looking at the pygrub code to see if it is possible to cope
>> with grub files with BLSCFG and spotted this minor issue in GrubConf.py
>> where the code intends to replace ${saved_entry} and ${next_entry} with 0
>> but doesn't succeed.
>>
>> Signed-off-by: Michael Young <m.a.young@durham.ac.uk>
>
> Ah - this looks suspiciously like it might be the bugfix for an issue
> reported by Steven.
>
> Steven - do you mind giving this patch a try for your "Fedora 30 DomU -
> pygrub always boots the second menu option" problem?
Sadly I don't think it is that simple and to it properly would require
parsing if clauses in the grub file and also reading variables from the
grubenv file.
I do however have an idea which might work which is to ignore anything in
if clauses, read the grubenv file (which I now have a hacky way of doing)
and treating the value of next_entry or saved_entry as the setting for
the default kernel to pick. If I finish a patch that does this I will post
it on the list, but I very much doubt it will be of commitable quality.
Michael Young
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-08-13 21:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 21:02 [Xen-devel] [PATCH] failing to set value to 0 in Grub2ConfigFile YOUNG, MICHAEL A.
2019-08-13 21:09 ` Andrew Cooper
2019-08-13 21:51 ` YOUNG, MICHAEL A. [this message]
2019-08-14 5:14 ` Steven Haigh
2019-08-14 11:17 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.1908132223440.3016@austen3.home \
--to=m.a.young@durham.ac.uk \
--cc=andrew.cooper3@citrix.com \
--cc=netwiz@crc.id.au \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).