From: Igor Druzhinin <igor.druzhinin@citrix.com>
To: <xen-devel@lists.xenproject.org>
Cc: andrew.cooper3@citrix.com,
Igor Druzhinin <igor.druzhinin@citrix.com>,
wl@xen.org, jbeulich@suse.com, roger.pau@citrix.com
Subject: [PATCH] x86/svm: retry after unhandled NPT fault if gfn was marked for recalculation
Date: Thu, 21 May 2020 22:43:58 +0100 [thread overview]
Message-ID: <1590097438-28829-1-git-send-email-igor.druzhinin@citrix.com> (raw)
If a recalculation NPT fault hasn't been handled explicitly in
hvm_hap_nested_page_fault() then it's potentially safe to retry -
US bit has been re-instated in PTE and any real fault would be correctly
re-raised next time.
This covers a specific case of migration with vGPU assigned on AMD:
global log-dirty is enabled and causes immediate recalculation NPT
fault in MMIO area upon access. This type of fault isn't described
explicitly in hvm_hap_nested_page_fault (this isn't called on
EPT misconfig exit on Intel) which results in domain crash.
Signed-off-by: Igor Druzhinin <igor.druzhinin@citrix.com>
---
xen/arch/x86/hvm/svm/svm.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c
index 46a1aac..f0d0bd3 100644
--- a/xen/arch/x86/hvm/svm/svm.c
+++ b/xen/arch/x86/hvm/svm/svm.c
@@ -1726,6 +1726,10 @@ static void svm_do_nested_pgfault(struct vcpu *v,
/* inject #VMEXIT(NPF) into guest. */
nestedsvm_vmexit_defer(v, VMEXIT_NPF, pfec, gpa);
return;
+ case 0:
+ /* If a recalculation page fault hasn't been handled - just retry. */
+ if ( pfec & PFEC_user_mode )
+ return;
}
/* Everything else is an error. */
--
2.7.4
next reply other threads:[~2020-05-21 21:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 21:43 Igor Druzhinin [this message]
2020-05-22 0:26 ` [PATCH] x86/svm: retry after unhandled NPT fault if gfn was marked for recalculation Igor Druzhinin
2020-05-22 9:45 ` Andrew Cooper
2020-05-22 10:05 ` Igor Druzhinin
2020-05-22 10:19 ` Andrew Cooper
2020-05-22 10:25 ` Igor Druzhinin
2020-05-22 13:34 ` Jan Beulich
2020-05-22 10:08 ` Roger Pau Monné
2020-05-22 10:14 ` Igor Druzhinin
2020-05-22 10:23 ` Roger Pau Monné
2020-05-22 10:27 ` Igor Druzhinin
2020-05-22 11:11 ` Roger Pau Monné
2020-05-22 13:04 ` Jan Beulich
2020-05-22 13:11 ` Andrew Cooper
2020-05-22 13:32 ` Roger Pau Monné
2020-05-22 15:53 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1590097438-28829-1-git-send-email-igor.druzhinin@citrix.com \
--to=igor.druzhinin@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).