From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Igor Druzhinin <igor.druzhinin@citrix.com>
Cc: xen-devel@lists.xenproject.org, wl@xen.org, jbeulich@suse.com,
andrew.cooper3@citrix.com
Subject: Re: [PATCH] x86/svm: retry after unhandled NPT fault if gfn was marked for recalculation
Date: Fri, 22 May 2020 12:08:46 +0200 [thread overview]
Message-ID: <20200522100846.GV54375@Air-de-Roger> (raw)
In-Reply-To: <1590097438-28829-1-git-send-email-igor.druzhinin@citrix.com>
On Thu, May 21, 2020 at 10:43:58PM +0100, Igor Druzhinin wrote:
> If a recalculation NPT fault hasn't been handled explicitly in
> hvm_hap_nested_page_fault() then it's potentially safe to retry -
> US bit has been re-instated in PTE and any real fault would be correctly
> re-raised next time.
>
> This covers a specific case of migration with vGPU assigned on AMD:
> global log-dirty is enabled and causes immediate recalculation NPT
> fault in MMIO area upon access. This type of fault isn't described
> explicitly in hvm_hap_nested_page_fault (this isn't called on
> EPT misconfig exit on Intel) which results in domain crash.
Couldn't direct MMIO regions be handled like other types of memory for
the purposes of logdiry mode?
I assume there's already a path here used for other memory types when
logdirty is turned on, and hence would seem better to just make direct
MMIO regions also use that path?
> Signed-off-by: Igor Druzhinin <igor.druzhinin@citrix.com>
> ---
> xen/arch/x86/hvm/svm/svm.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c
> index 46a1aac..f0d0bd3 100644
> --- a/xen/arch/x86/hvm/svm/svm.c
> +++ b/xen/arch/x86/hvm/svm/svm.c
> @@ -1726,6 +1726,10 @@ static void svm_do_nested_pgfault(struct vcpu *v,
> /* inject #VMEXIT(NPF) into guest. */
> nestedsvm_vmexit_defer(v, VMEXIT_NPF, pfec, gpa);
> return;
> + case 0:
> + /* If a recalculation page fault hasn't been handled - just retry. */
> + if ( pfec & PFEC_user_mode )
> + return;
I'm slightly worried that this diverges from the EPT implementation
now, in the sense that returning 0 from hvm_hap_nested_page_fault will
no longer trigger a guest crash.
Thanks, Roger.
next prev parent reply other threads:[~2020-05-22 10:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 21:43 [PATCH] x86/svm: retry after unhandled NPT fault if gfn was marked for recalculation Igor Druzhinin
2020-05-22 0:26 ` Igor Druzhinin
2020-05-22 9:45 ` Andrew Cooper
2020-05-22 10:05 ` Igor Druzhinin
2020-05-22 10:19 ` Andrew Cooper
2020-05-22 10:25 ` Igor Druzhinin
2020-05-22 13:34 ` Jan Beulich
2020-05-22 10:08 ` Roger Pau Monné [this message]
2020-05-22 10:14 ` Igor Druzhinin
2020-05-22 10:23 ` Roger Pau Monné
2020-05-22 10:27 ` Igor Druzhinin
2020-05-22 11:11 ` Roger Pau Monné
2020-05-22 13:04 ` Jan Beulich
2020-05-22 13:11 ` Andrew Cooper
2020-05-22 13:32 ` Roger Pau Monné
2020-05-22 15:53 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522100846.GV54375@Air-de-Roger \
--to=roger.pau@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=igor.druzhinin@citrix.com \
--cc=jbeulich@suse.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).