xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Tim Deegan <tim@xen.org>, Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Paul Durrant <paul.durrant@citrix.com>,
	dgdegra@tycho.nsa.gov
Subject: Re: [PATCH 01/11] public / x86: introduce hvmctl hypercall
Date: Thu, 23 Jun 2016 15:55:04 +0100	[thread overview]
Message-ID: <1c8d94c3-7a7e-4b2d-6ded-e82d778852af@citrix.com> (raw)
In-Reply-To: <5768033902000078000F6BBE@prv-mh.provo.novell.com>

On 20/06/16 13:52, Jan Beulich wrote:
> +/*
> + * Note that this value is effectively part of the ABI, even if we don't need
> + * to make it a formal part of it.  Hence this value may only be changed if
> + * accompanied by a suitable interface version increase.
> + */
> +#define HVMCTL_iter_shift 8
> +#define HVMCTL_iter_mask  ((1U << HVMCTL_iter_shift) - 1)
> +#define HVMCTL_iter_max   (1U << (16 + HVMCTL_iter_shift))

This (mis)use of the cmd parameter is surely no longer necessary, given
that there is space in xen_hvmctl_t to encode continuation information?

~Andrew


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  parent reply	other threads:[~2016-06-23 14:55 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-20 12:39 [PATCH 00/11] hvmctl hypercall Jan Beulich
2016-06-20 12:52 ` [PATCH 01/11] public / x86: introduce " Jan Beulich
2016-06-21 10:14   ` Wei Liu
2016-06-23 14:55   ` Andrew Cooper [this message]
2016-06-23 15:10     ` Jan Beulich
2016-06-23 15:35       ` Andrew Cooper
2016-06-20 12:53 ` [PATCH 02/11] hvmctl: convert HVMOP_set_pci_intx_level Jan Beulich
2016-06-20 14:32   ` Daniel De Graaf
2016-06-20 14:48     ` Ian Jackson
2016-06-20 15:25       ` Jan Beulich
2016-06-21 10:14   ` Wei Liu
2016-06-20 12:53 ` [PATCH 03/11] hvmctl: convert HVMOP_set_isa_irq_level Jan Beulich
2016-06-21 10:14   ` Wei Liu
2016-06-20 12:54 ` [PATCH 04/11] hvmctl: convert HVMOP_set_pci_link_route Jan Beulich
2016-06-21 10:14   ` Wei Liu
2016-06-20 12:54 ` [PATCH 05/11] hvmctl: convert HVMOP_track_dirty_vram Jan Beulich
2016-06-21 10:14   ` Wei Liu
2016-06-20 12:55 ` [PATCH 06/11] hvmctl: convert HVMOP_modified_memory Jan Beulich
2016-06-21 10:14   ` Wei Liu
2016-06-20 12:56 ` [PATCH 07/11] hvmctl: convert HVMOP_set_mem_type Jan Beulich
2016-06-21 10:14   ` Wei Liu
2016-06-20 12:56 ` [PATCH 08/11] hvmctl: convert HVMOP_inject_trap Jan Beulich
2016-06-21 10:14   ` Wei Liu
2016-06-20 12:57 ` [PATCH 09/11] hvmctl: convert HVMOP_inject_msi Jan Beulich
2016-06-21 10:14   ` Wei Liu
2016-06-20 12:57 ` [PATCH 10/11] hvmctl: convert HVMOP_*ioreq_server* Jan Beulich
2016-06-21 10:14   ` Wei Liu
2016-06-21 12:44   ` Paul Durrant
2016-06-20 12:58 ` [PATCH 11/11] x86/HVM: serialize trap injecting producer and consumer Jan Beulich
2016-06-23 15:14   ` Andrew Cooper
2016-06-23 15:15 ` [PATCH 00/11] hvmctl hypercall Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1c8d94c3-7a7e-4b2d-6ded-e82d778852af@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=dgdegra@tycho.nsa.gov \
    --cc=paul.durrant@citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=tim@xen.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).