From: Daniel De Graaf <dgdegra@tycho.nsa.gov>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Paul Durrant <paul.durrant@citrix.com>
Subject: Re: [PATCH 02/11] hvmctl: convert HVMOP_set_pci_intx_level
Date: Mon, 20 Jun 2016 10:32:28 -0400 [thread overview]
Message-ID: <f75a7e5a-1633-fd88-012c-ceaa13ea9372@tycho.nsa.gov> (raw)
In-Reply-To: <5768036302000078000F6BC2@prv-mh.provo.novell.com>
On 06/20/2016 08:53 AM, Jan Beulich wrote:
> Note that this adds validation of the "domain" interface structure
> field, which previously got ignored.
>
> Note further that this retains the hvmop interface definitions as those
> had (wrongly) been exposed to non-tool stack consumers (albeit the
> operation wouldn't have succeeded when requested by a domain for
> itself).
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> TBD: xen/xsm/flask/policy/access_vectors says "also needs hvmctl", but
> I don't see how this has been done so far. With the change here,
> doing two checks in flask_hvm_control() (the generic one always
> and a specific one if needed) would of course be simple, but it's
> unclear how subsequently added sub-ops should then be dealt with
> (which don't have a similar remark).
I am not sure why that remark is there: it seems like it refers to an
overall check in the HVM operation hypercall, which does not exist.
There is no reason to have an operation protected by two different
access checks, so I think that both the previous and patched code
are correct and the "also needs hvmctl" comment should be removed.
With that, Acked-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-20 14:33 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 12:39 [PATCH 00/11] hvmctl hypercall Jan Beulich
2016-06-20 12:52 ` [PATCH 01/11] public / x86: introduce " Jan Beulich
2016-06-21 10:14 ` Wei Liu
2016-06-23 14:55 ` Andrew Cooper
2016-06-23 15:10 ` Jan Beulich
2016-06-23 15:35 ` Andrew Cooper
2016-06-20 12:53 ` [PATCH 02/11] hvmctl: convert HVMOP_set_pci_intx_level Jan Beulich
2016-06-20 14:32 ` Daniel De Graaf [this message]
2016-06-20 14:48 ` Ian Jackson
2016-06-20 15:25 ` Jan Beulich
2016-06-21 10:14 ` Wei Liu
2016-06-20 12:53 ` [PATCH 03/11] hvmctl: convert HVMOP_set_isa_irq_level Jan Beulich
2016-06-21 10:14 ` Wei Liu
2016-06-20 12:54 ` [PATCH 04/11] hvmctl: convert HVMOP_set_pci_link_route Jan Beulich
2016-06-21 10:14 ` Wei Liu
2016-06-20 12:54 ` [PATCH 05/11] hvmctl: convert HVMOP_track_dirty_vram Jan Beulich
2016-06-21 10:14 ` Wei Liu
2016-06-20 12:55 ` [PATCH 06/11] hvmctl: convert HVMOP_modified_memory Jan Beulich
2016-06-21 10:14 ` Wei Liu
2016-06-20 12:56 ` [PATCH 07/11] hvmctl: convert HVMOP_set_mem_type Jan Beulich
2016-06-21 10:14 ` Wei Liu
2016-06-20 12:56 ` [PATCH 08/11] hvmctl: convert HVMOP_inject_trap Jan Beulich
2016-06-21 10:14 ` Wei Liu
2016-06-20 12:57 ` [PATCH 09/11] hvmctl: convert HVMOP_inject_msi Jan Beulich
2016-06-21 10:14 ` Wei Liu
2016-06-20 12:57 ` [PATCH 10/11] hvmctl: convert HVMOP_*ioreq_server* Jan Beulich
2016-06-21 10:14 ` Wei Liu
2016-06-21 12:44 ` Paul Durrant
2016-06-20 12:58 ` [PATCH 11/11] x86/HVM: serialize trap injecting producer and consumer Jan Beulich
2016-06-23 15:14 ` Andrew Cooper
2016-06-23 15:15 ` [PATCH 00/11] hvmctl hypercall Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f75a7e5a-1633-fd88-012c-ceaa13ea9372@tycho.nsa.gov \
--to=dgdegra@tycho.nsa.gov \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=paul.durrant@citrix.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).