From: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, jeremy.fitzhardinge@citrix.com,
konrad.wilk@oracle.com, Ian.Campbell@citrix.com,
xen-devel@lists.xensource.com,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] xen: netfront: fix declaration order
Date: Sun, 3 Apr 2011 19:35:26 +0200 [thread overview]
Message-ID: <20110403173526.GA2082@rere.qmqm.pl> (raw)
In-Reply-To: <1301828839.2837.143.camel@edumazet-laptop>
On Sun, Apr 03, 2011 at 01:07:19PM +0200, Eric Dumazet wrote:
> Le vendredi 01 avril 2011 à 20:54 -0700, David Miller a écrit :
> > From: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> > Date: Thu, 31 Mar 2011 13:01:35 +0200 (CEST)
> >
> > > Not tested in any way. The original code for offload setting seems broken
> > > as it resets the features on every netback reconnect.
> > >
> > > This will set GSO_ROBUST at device creation time (earlier than connect time).
> > >
> > > RX checksum offload is forced on - so advertise as it is.
> > >
> > > Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> > Applied.
> Hmm... I had to apply following patch to make it actually compile.
> [PATCH] xen: netfront: fix declaration order
>
> Must declare xennet_fix_features() and xennet_set_features() before
> using them.
Hmm. Sorry for that. Looks like x86 allyesconfig doesn't include this
driver in the build. :/
There really needs to be something like CONFIG_LINT...
Best Regards,
Michał Mirosław
next prev parent reply other threads:[~2011-04-03 17:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-31 11:01 [PATCH RESEND] net: convert xen-netfront to hw_features Michał Mirosław
2011-03-31 11:13 ` Ian Campbell
2011-03-31 11:37 ` Michał Mirosław
2011-04-02 3:54 ` David Miller
2011-04-03 11:07 ` [PATCH] xen: netfront: fix declaration order Eric Dumazet
2011-04-03 17:35 ` Michał Mirosław [this message]
2011-04-04 0:24 ` David Miller
2011-04-04 9:55 ` [PATCH] xen: drop anti-dependency on X86_VISWS (Was: Re: [PATCH] xen: netfront: fix declaration order) Ian Campbell
2011-04-06 21:45 ` [PATCH] xen: drop anti-dependency on X86_VISWS David Miller
2011-04-07 6:58 ` Ian Campbell
2011-04-07 17:00 ` H. Peter Anvin
2011-04-08 6:46 ` Ian Campbell
2011-04-08 20:15 ` H. Peter Anvin
2011-04-07 18:07 ` Jeremy Fitzhardinge
2011-04-08 6:38 ` Ian Campbell
2011-04-08 15:25 ` Jeremy Fitzhardinge
2011-04-08 15:42 ` Jan Beulich
2011-04-08 18:24 ` Jeremy Fitzhardinge
2011-04-09 10:34 ` Ian Campbell
2011-04-14 8:20 ` Jeremy Fitzhardinge
2011-04-04 12:29 ` [PATCH RESEND] net: convert xen-netfront to hw_features Ian Campbell
2011-04-04 18:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110403173526.GA2082@rere.qmqm.pl \
--to=mirq-linux@rere.qmqm.pl \
--cc=Ian.Campbell@citrix.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).