Re: [PATCH 3/6] tools: Add a block-tap script for setting up tapdisks via tap-ctl

From: Wei Liu <wei.liu2@citrix.com>
To: George Dunlap <george.dunlap@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
	Felipe Franciosi <felipe.franciosi@citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>,
	Jonathan Ludlam <Jonathan.Ludlam@eu.citrix.com>,
	xen-devel@lists.xen.org, Dave Scott <Dave.Scott@eu.citrix.com>,
	Ian Jackson <ian.jackson@citrix.com>,
	Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH 3/6] tools: Add a block-tap script for setting up tapdisks via tap-ctl
Date: Tue, 7 Jul 2015 13:03:24 +0100	[thread overview]
Message-ID: <20150707120324.GW1134@zion.uk.xensource.com> (raw)
In-Reply-To: <1436179903-449-4-git-send-email-george.dunlap@eu.citrix.com>

On Mon, Jul 06, 2015 at 11:51:40AM +0100, George Dunlap wrote:
> The blocktap library isn't really necessary; all the necessary functionality
> is available via the tap-ctl binary.
> 
> To use:
> 
> script=block-tap,vdev=[whatever],target=vhd:/path/to/file.vhd
> 
> script=block-tap,vdev=[whatever],target=aio:/path/to/file.raw
> 

Is "scirpt=block-tap" the only change required for current syntax?

Does this still supports deprecated syntax like

  vhd:disk.img,hda,rw

I'm assuming in later patch you will massage relevant bits into
parameter string to this script.

Wei.