From: George Dunlap <George.Dunlap@eu.citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Felipe Franciosi <felipe.franciosi@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Wen Congyang <wency@cn.fujitsu.com>,
Jonathan Ludlam <Jonathan.Ludlam@eu.citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
Ian Jackson <ian.jackson@citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Yang Hongyang <yanghy@cn.fujitsu.com>,
Dave Scott <Dave.Scott@eu.citrix.com>
Subject: Re: [PATCH 4/6] libxl: Use the block-tap script for LIBXL_DISK_BACKEND_TAP
Date: Mon, 6 Jul 2015 13:39:43 +0100 [thread overview]
Message-ID: <CAFLBxZZ7KnyZnvv5FEOTRw+rLCKHXLkO7O4z4TzXKVQnUsyHwA@mail.gmail.com> (raw)
In-Reply-To: <559A6001.2010202@citrix.com>
On Mon, Jul 6, 2015 at 12:01 PM, Andrew Cooper
<andrew.cooper3@citrix.com> wrote:
> On 06/07/15 11:51, George Dunlap wrote:
>> The block-tap script can now do everything needed for libxl; no need
>> to link against the blktap library.
>>
>> To do this:
>>
>> * Set disk->script to "block-tap" and dev to "format:pdev_path" in
>> device_disk_add for LIBXL_DISK_BACKEND_TAP
>>
>> * Remove libxl_blktap2.o and libxl_noblktap2.o and all code depending
>> on them
>>
>> Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
>> ---
>> CC: Ian Campbell <ian.campbell@citrix.com>
>> CC: Ian Jackson <ian.jackson@citrix.com>
>> CC: Wei Liu <wei.liu2@citrix.com>
>> CC: Dave Scott <Dave.Scott@eu.citrix.com>
>> CC: Jonathan Ludlam <Jonathan.Ludlam@eu.citrix.com>
>> CC: Wen Congyang <wency@cn.fujitsu.com>
>> CC: Yang Hongyang <yanghy@cn.fujitsu.com>
>> CC: Felipe Franciosi <felipe.franciosi@citrix.com>
>>
>> Note: This is broken for HVM domains at the moment because all block
>> scripts are broken for HVM domains. That is a bug which should be a
>> blocker for the 4.6 release. As such, I think there is justification
>> for checking in this "feature" (enabling use of a 'system' blktap)
>> with the assumption that the FIXME will go away before the release.
>>
>> That will technically break bisectability; but only for users of
>> blktap (which does not include osstest).
>> ---
>> tools/libxl/Makefile | 5 ---
>> tools/libxl/libxl.c | 28 ++++---------
>> tools/libxl/libxl_blktap2.c | 93 -------------------------------------------
>> tools/libxl/libxl_device.c | 14 -------
>> tools/libxl/libxl_dm.c | 5 ++-
>> tools/libxl/libxl_internal.h | 26 ------------
>> tools/libxl/libxl_noblktap2.c | 42 -------------------
>> 7 files changed, 11 insertions(+), 202 deletions(-)
>>
>> diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
>> index cc9c152..43ab243 100644
>> --- a/tools/libxl/Makefile
>> +++ b/tools/libxl/Makefile
>> @@ -44,11 +44,6 @@ LIBXL_LIBS += $(LIBXL_LIBS-y)
>> LIBXLU_LIBS = libxenlight.so
>>
>> LIBXL_OBJS-y = osdeps.o libxl_paths.o libxl_bootloader.o flexarray.o
>> -ifeq ($(LIBXL_BLKTAP),y)
>
> You will also want to remove reference to LIBXL_BLKTAP from Rules.mk
Indeed, there is quite a bit I seem to have missed... I'll add a patch
exising the configure- and make-related bits, separately from both
this patch and the rm -rf tools/blktap2 patch.
-George
next prev parent reply other threads:[~2015-07-06 12:39 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 10:51 [PATCH 0/6] Use system blktap George Dunlap
2015-07-06 10:51 ` [PATCH 1/6] libxl: Make local_initiate_attach more rational George Dunlap
2015-07-06 10:51 ` [PATCH 2/6] libxl: Remove linux udev rules George Dunlap
2015-07-07 11:39 ` Wei Liu
2015-07-14 16:13 ` Konrad Rzeszutek Wilk
2015-07-14 16:21 ` Ian Campbell
2015-07-14 16:35 ` George Dunlap
2015-07-14 16:40 ` Wei Liu
2015-07-14 16:48 ` Ian Campbell
2015-07-23 11:55 ` Roger Pau Monné
2015-07-23 12:30 ` Ian Campbell
2015-07-15 11:07 ` [PATCH for-4.6] tools/hotplug: Add an initscript to start "xl devd" in a driver domain Ian Campbell
2015-07-15 13:26 ` Wei Liu
2015-07-15 13:40 ` Ian Campbell
2015-07-15 15:25 ` George Dunlap
2015-07-15 15:32 ` Ian Jackson
2015-07-15 15:35 ` George Dunlap
2015-07-15 15:37 ` Ian Campbell
2015-07-16 16:58 ` [PATCH for-4.6 v2] " Ian Campbell
2015-07-16 17:09 ` Ian Jackson
2015-07-16 17:48 ` Wei Liu
2015-07-17 9:05 ` Wei Liu
2015-07-17 11:36 ` Ian Campbell
2015-07-20 14:16 ` Roger Pau Monné
2015-07-20 14:28 ` Ian Campbell
2015-07-06 10:51 ` [PATCH 3/6] tools: Add a block-tap script for setting up tapdisks via tap-ctl George Dunlap
2015-07-07 12:03 ` Wei Liu
2015-07-07 12:35 ` Wei Liu
2015-07-06 10:51 ` [PATCH 4/6] libxl: Use the block-tap script for LIBXL_DISK_BACKEND_TAP George Dunlap
2015-07-06 11:01 ` Andrew Cooper
2015-07-06 12:39 ` George Dunlap [this message]
2015-07-07 12:29 ` Wei Liu
2015-07-07 13:41 ` George Dunlap
2015-07-07 14:20 ` Ian Campbell
2015-07-07 14:27 ` George Dunlap
2015-07-06 10:51 ` [PATCH 5/6] tools: Remove in-tree blktap2 George Dunlap
2015-07-07 11:55 ` Wei Liu
2015-07-06 10:51 ` [PATCH 6/6] libxl: Add more logging to hotplug script path George Dunlap
2015-07-07 11:55 ` Wei Liu
2015-07-07 14:21 ` [PATCH 0/6] Use system blktap Ian Campbell
2015-07-07 14:24 ` George Dunlap
2015-07-07 14:52 ` Ian Campbell
2015-07-07 14:59 ` George Dunlap
2015-07-07 15:04 ` Ian Campbell
2015-07-07 15:20 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFLBxZZ7KnyZnvv5FEOTRw+rLCKHXLkO7O4z4TzXKVQnUsyHwA@mail.gmail.com \
--to=george.dunlap@eu.citrix.com \
--cc=Dave.Scott@eu.citrix.com \
--cc=Jonathan.Ludlam@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=felipe.franciosi@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=wency@cn.fujitsu.com \
--cc=xen-devel@lists.xen.org \
--cc=yanghy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).