Re: Requesting for freeze exception for RMRR

[Wei Liu <wei.liu2@citrix.com>]

On Tue, Jul 14, 2015 at 09:27:17AM +0800, Chen, Tiejun wrote:
> >Please work with maintainers to get those hvmloader patches acked or
> >reviewed.
> 
> I will do.
> 
> >
> >>
> >>Note Jackson and Campbell also raised some comments to improve current
> >>codes.
> >>
> >>2. explain why it needs to be in this release (benefits).
> >>
> >>RMRR mechanism was broken for a long time and this makes VM always face
> >>security issues. In addition, those associated devices can't be passed
> >>through to VM and even result in VM crashes.
> >>
> >>3. explain why it doesn't break things (risks).
> >>
> >>Our policy makes sure that system will work in the original way by default
> >>as without the RMRR patches. And especially, this series just impacts those
> >>platforms which have RMRR.
> >>
> >
> >Your patches touch crucial path in hvmloader to build memory map. There
> >is risk that it may break hvmloader even if it is turned off.
> >
> >I would need at least some positive test results from you to confirm if
> >this feature is turned off everything works as before.
> >
> 
> Could you show what sort of test you need here? I just did boot a VM without
> any RDM parameters. I just think maybe someone had this good experience to
> check this.
> 

Yes, this is the basic test I need -- at least booting a VM with RDM
off.

Feel free to do more tests and report back if you have time.

Wei.

> Thanks
> Tiejun