From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Bob Liu <bob.liu@oracle.com>
Cc: jgross@suse.com, xen-devel@lists.xen.org, annie.li@oracle.com,
Paul.Durrant@citrix.com, Ian.Jackson@citrix.com,
roger.pau@citrix.com
Subject: Re: [RFC PATCH] blkif.h: document scsi/0x12/0x83 node
Date: Wed, 16 Mar 2016 03:16:56 -0400 [thread overview]
Message-ID: <20160316071656.GC24628@localhost.localdomain> (raw)
In-Reply-To: <1458097745-554-1-git-send-email-bob.liu@oracle.com>
On Wed, Mar 16, 2016 at 11:09:05AM +0800, Bob Liu wrote:
> Sometimes, we need to query VPD page=0x83 data from underlying storage so
> that vendor supplied software can run inside the VM and believe it's talking to
> the vendor's own storage.
> But different vendors may have different special features, so it's not suitable
> to export through "feature-xxxx".
>
> One solution is query the whole VPD page through Xenstore node, which has
> already been used by windows pv driver.
> http://xenbits.xen.org/gitweb/?p=pvdrivers/win/xenvbd.git;a=blob;f=src/xenvbd/pdoinquiry.c
>
> This patch documents the Xenstore node to blkif.h, so that blkfront in Linux and
> other frontends can use the same mechanism.
>
> Signed-off-by: Bob Liu <bob.liu@oracle.com>
> ---
> xen/include/public/io/blkif.h | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/xen/include/public/io/blkif.h b/xen/include/public/io/blkif.h
> index 99f0326..30a6e46 100644
> --- a/xen/include/public/io/blkif.h
> +++ b/xen/include/public/io/blkif.h
> @@ -182,6 +182,14 @@
> * backend driver paired with a LIFO queue in the frontend will
> * allow us to have better performance in this scenario.
> *
> + * scsi/0x12/0x83
Could you mention that 0x12 is the SCSI opcode for INQUIRY and
0x83 is for device identity.
There is also the 0x80 with serial number (useful?)
> + * Values: string
> + *
> + * A base64 formatted string providing VPD pages read out from backend
> + * device.
> + * The backend driver or the toolstack should write this node with VPD
> + * informations when attaching devices.
> + *
> *----------------------- Request Transport Parameters ------------------------
> *
> * max-ring-page-order
> --
> 1.7.10.4
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-16 7:16 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 3:09 [RFC PATCH] blkif.h: document scsi/0x12/0x83 node Bob Liu
2016-03-16 7:16 ` Konrad Rzeszutek Wilk [this message]
2016-03-16 12:36 ` Ian Jackson
2016-03-16 13:59 ` Bob Liu
2016-03-16 14:07 ` Paul Durrant
2016-03-17 5:04 ` Bob Liu
2016-03-16 14:32 ` David Vrabel
2016-03-17 5:07 ` Bob Liu
2016-03-17 11:12 ` Ian Jackson
2016-03-17 11:18 ` David Vrabel
2016-03-17 11:20 ` Ian Jackson
2016-03-22 12:55 ` Bob Liu
2016-03-22 13:41 ` David Vrabel
2016-03-22 14:10 ` Konrad Rzeszutek Wilk
2016-03-22 14:38 ` David Vrabel
2016-03-22 14:43 ` Paul Durrant
2016-03-22 15:09 ` Ian Jackson
2016-03-22 15:25 ` Paul Durrant
2016-03-22 16:14 ` Ian Jackson
2016-03-22 16:50 ` Konrad Rzeszutek Wilk
2016-03-22 17:39 ` Paul Durrant
2016-03-22 15:12 ` Ian Jackson
2016-03-22 15:27 ` Konrad Rzeszutek Wilk
2016-03-22 16:11 ` Ian Jackson
2016-03-22 16:38 ` Konrad Rzeszutek Wilk
2016-03-22 16:25 ` Jan Beulich
2016-03-16 14:33 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160316071656.GC24628@localhost.localdomain \
--to=konrad.wilk@oracle.com \
--cc=Ian.Jackson@citrix.com \
--cc=Paul.Durrant@citrix.com \
--cc=annie.li@oracle.com \
--cc=bob.liu@oracle.com \
--cc=jgross@suse.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).