Re: [RFC PATCH] blkif.h: document scsi/0x12/0x83 node

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

On Wed, Mar 16, 2016 at 11:09:05AM +0800, Bob Liu wrote:
> Sometimes, we need to query VPD page=0x83 data from underlying storage so
> that vendor supplied software can run inside the VM and believe it's talking to
> the vendor's own storage.
> But different vendors may have different special features, so it's not suitable
> to export through "feature-xxxx".
> 
> One solution is query the whole VPD page through Xenstore node, which has
> already been used by windows pv driver.
> http://xenbits.xen.org/gitweb/?p=pvdrivers/win/xenvbd.git;a=blob;f=src/xenvbd/pdoinquiry.c
> 
> This patch documents the Xenstore node to blkif.h, so that blkfront in Linux and
> other frontends can use the same mechanism.
> 
> Signed-off-by: Bob Liu <bob.liu@oracle.com>
> ---
>  xen/include/public/io/blkif.h |    8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/xen/include/public/io/blkif.h b/xen/include/public/io/blkif.h
> index 99f0326..30a6e46 100644
> --- a/xen/include/public/io/blkif.h
> +++ b/xen/include/public/io/blkif.h
> @@ -182,6 +182,14 @@
>   *      backend driver paired with a LIFO queue in the frontend will
>   *      allow us to have better performance in this scenario.
>   *
> + * scsi/0x12/0x83

Could you mention that 0x12 is the SCSI opcode for INQUIRY and
0x83 is for device identity.

There is also the 0x80 with serial number (useful?)
> + * 	Values:	string
> + *
> + * 	A base64 formatted string providing VPD pages read out from backend
> + * 	device.
> + * 	The backend driver or the toolstack should write this node with VPD
> + * 	informations when attaching devices.
> + *
>   *----------------------- Request Transport Parameters ------------------------
>   *
>   * max-ring-page-order
> -- 
> 1.7.10.4
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel