xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] tools/python/xc: fix tmem_control parameter parsing
@ 2016-03-23 17:45 Zhigang Wang
  2016-03-23 18:43 ` Konrad Rzeszutek Wilk
  2016-03-25 15:58 ` Wei Liu
  0 siblings, 2 replies; 3+ messages in thread
From: Zhigang Wang @ 2016-03-23 17:45 UTC (permalink / raw)
  To: xen-devel; +Cc: Zhigang Wang, Ian Jackson, Ian Campbell, Stefano Stabellini

There should be 6 instead of 7 arguments now for tmem_control().

Signed-off-by: Zhigang Wang <zhigang.x.wang@oracle.com>
---
 tools/python/xen/lowlevel/xc/xc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/python/xen/lowlevel/xc/xc.c b/tools/python/xen/lowlevel/xc/xc.c
index c40a4e9..ff714d7 100644
--- a/tools/python/xen/lowlevel/xc/xc.c
+++ b/tools/python/xen/lowlevel/xc/xc.c
@@ -1620,7 +1620,7 @@ static PyObject *pyxc_tmem_control(XcObject *self,
 
     static char *kwd_list[] = { "pool_id", "subop", "cli_id", "arg1", "arg2", "buf", NULL };
 
-    if ( !PyArg_ParseTupleAndKeywords(args, kwds, "iiiiiis", kwd_list,
+    if ( !PyArg_ParseTupleAndKeywords(args, kwds, "iiiiis", kwd_list,
                         &pool_id, &subop, &cli_id, &arg1, &arg2, &buf) )
         return NULL;
 
-- 
2.5.5


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] tools/python/xc: fix tmem_control parameter parsing
  2016-03-23 17:45 [PATCH] tools/python/xc: fix tmem_control parameter parsing Zhigang Wang
@ 2016-03-23 18:43 ` Konrad Rzeszutek Wilk
  2016-03-25 15:58 ` Wei Liu
  1 sibling, 0 replies; 3+ messages in thread
From: Konrad Rzeszutek Wilk @ 2016-03-23 18:43 UTC (permalink / raw)
  To: Zhigang Wang; +Cc: xen-devel, Ian Jackson, Ian Campbell, Stefano Stabellini

On Wed, Mar 23, 2016 at 01:45:37PM -0400, Zhigang Wang wrote:
> There should be 6 instead of 7 arguments now for tmem_control().
.. which was done in commit 54a51b1766fd433b95e63834eb15d4b1f70271de
"tmem: Remove xc_tmem_control mystical arg3"

but it missed the removal of an 'i'.
    
> 
> Signed-off-by: Zhigang Wang <zhigang.x.wang@oracle.com>

Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

> ---
>  tools/python/xen/lowlevel/xc/xc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/python/xen/lowlevel/xc/xc.c b/tools/python/xen/lowlevel/xc/xc.c
> index c40a4e9..ff714d7 100644
> --- a/tools/python/xen/lowlevel/xc/xc.c
> +++ b/tools/python/xen/lowlevel/xc/xc.c
> @@ -1620,7 +1620,7 @@ static PyObject *pyxc_tmem_control(XcObject *self,
>  
>      static char *kwd_list[] = { "pool_id", "subop", "cli_id", "arg1", "arg2", "buf", NULL };
>  
> -    if ( !PyArg_ParseTupleAndKeywords(args, kwds, "iiiiiis", kwd_list,
> +    if ( !PyArg_ParseTupleAndKeywords(args, kwds, "iiiiis", kwd_list,
>                          &pool_id, &subop, &cli_id, &arg1, &arg2, &buf) )
>          return NULL;
>  
> -- 
> 2.5.5
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] tools/python/xc: fix tmem_control parameter parsing
  2016-03-23 17:45 [PATCH] tools/python/xc: fix tmem_control parameter parsing Zhigang Wang
  2016-03-23 18:43 ` Konrad Rzeszutek Wilk
@ 2016-03-25 15:58 ` Wei Liu
  1 sibling, 0 replies; 3+ messages in thread
From: Wei Liu @ 2016-03-25 15:58 UTC (permalink / raw)
  To: Zhigang Wang
  Cc: xen-devel, Wei Liu, Ian Jackson, Ian Campbell, Stefano Stabellini

On Wed, Mar 23, 2016 at 01:45:37PM -0400, Zhigang Wang wrote:
> There should be 6 instead of 7 arguments now for tmem_control().
> 
> Signed-off-by: Zhigang Wang <zhigang.x.wang@oracle.com>

Acked-by: Wei Liu <wei.liu2@citrix.com>

> ---
>  tools/python/xen/lowlevel/xc/xc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/python/xen/lowlevel/xc/xc.c b/tools/python/xen/lowlevel/xc/xc.c
> index c40a4e9..ff714d7 100644
> --- a/tools/python/xen/lowlevel/xc/xc.c
> +++ b/tools/python/xen/lowlevel/xc/xc.c
> @@ -1620,7 +1620,7 @@ static PyObject *pyxc_tmem_control(XcObject *self,
>  
>      static char *kwd_list[] = { "pool_id", "subop", "cli_id", "arg1", "arg2", "buf", NULL };
>  
> -    if ( !PyArg_ParseTupleAndKeywords(args, kwds, "iiiiiis", kwd_list,
> +    if ( !PyArg_ParseTupleAndKeywords(args, kwds, "iiiiis", kwd_list,
>                          &pool_id, &subop, &cli_id, &arg1, &arg2, &buf) )
>          return NULL;
>  
> -- 
> 2.5.5
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-03-25 15:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-23 17:45 [PATCH] tools/python/xc: fix tmem_control parameter parsing Zhigang Wang
2016-03-23 18:43 ` Konrad Rzeszutek Wilk
2016-03-25 15:58 ` Wei Liu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).