From: Wei Liu <wei.liu2@citrix.com>
To: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Wen Congyang <wency@cn.fujitsu.com>,
xen devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] tools: add missing header for xenctrl.h
Date: Fri, 1 Apr 2016 11:04:51 +0100 [thread overview]
Message-ID: <20160401100451.GB26151@citrix.com> (raw)
In-Reply-To: <56FDE258.6040607@cn.fujitsu.com>
On Fri, Apr 01, 2016 at 10:52:08AM +0800, Changlong Xie wrote:
> My build machine is
>
> master:/etc # cat SuSE-release
> SUSE Linux Enterprise Server 11 (x86_64)
> VERSION = 11
> PATCHLEVEL = 3
>
> You may not to reproduce the same errors on fedora or some other platforms.
>
Olaf posted a similar patch yesterday.
This issue will be fixed soon.
Wei.
> On 04/01/2016 10:46 AM, Changlong Xie wrote:
> >Commit d275ec9c introduce ssize_t but not include relevant header,
> >it will cause compile errors just like below:
> >
> >./include/xenctrl.h:1485: error: expected '=', ',', ';', 'asm' or
> >'__attribute__' before 'xc_version_len'
> >
> >Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> >Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
> >---
> > tools/libxc/include/xenctrl.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> >diff --git a/tools/libxc/include/xenctrl.h b/tools/libxc/include/xenctrl.h
> >index a9e4dc1..fb5c26c 100644
> >--- a/tools/libxc/include/xenctrl.h
> >+++ b/tools/libxc/include/xenctrl.h
> >@@ -31,6 +31,7 @@
> > #include <stdint.h>
> > #include <stdio.h>
> > #include <stdbool.h>
> >+#include <unistd.h>
> > #include <xen/xen.h>
> > #include <xen/domctl.h>
> > #include <xen/physdev.h>
> >
>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-01 10:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 2:46 [PATCH] tools: add missing header for xenctrl.h Changlong Xie
2016-04-01 2:52 ` Changlong Xie
2016-04-01 10:04 ` Wei Liu [this message]
2016-03-31 11:25 ` [PATCH v2] tools/libxc: Fix build error when using xc_version_len Olaf Hering
2016-03-31 14:23 ` Konrad Rzeszutek Wilk
2016-03-31 14:33 ` Olaf Hering
2016-04-01 13:47 ` Wei Liu
2016-04-01 13:50 ` [PATCH v2] tools/libxc: Fix build error when using xc_version_len [and 2 more messages] Ian Jackson
2016-04-01 15:29 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160401100451.GB26151@citrix.com \
--to=wei.liu2@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wency@cn.fujitsu.com \
--cc=xen-devel@lists.xen.org \
--cc=xiecl.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).