* [PATCH] tools: add missing header for xenctrl.h
@ 2016-04-01 2:46 Changlong Xie
2016-04-01 2:52 ` Changlong Xie
0 siblings, 1 reply; 9+ messages in thread
From: Changlong Xie @ 2016-04-01 2:46 UTC (permalink / raw)
To: xen devel, Konrad Rzeszutek Wilk, Ian Jackson, Wei Liu
Cc: Changlong Xie, Wen Congyang
Commit d275ec9c introduce ssize_t but not include relevant header,
it will cause compile errors just like below:
./include/xenctrl.h:1485: error: expected '=', ',', ';', 'asm' or
'__attribute__' before 'xc_version_len'
Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
---
tools/libxc/include/xenctrl.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/libxc/include/xenctrl.h b/tools/libxc/include/xenctrl.h
index a9e4dc1..fb5c26c 100644
--- a/tools/libxc/include/xenctrl.h
+++ b/tools/libxc/include/xenctrl.h
@@ -31,6 +31,7 @@
#include <stdint.h>
#include <stdio.h>
#include <stdbool.h>
+#include <unistd.h>
#include <xen/xen.h>
#include <xen/domctl.h>
#include <xen/physdev.h>
--
1.9.3
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] tools: add missing header for xenctrl.h
2016-04-01 2:46 [PATCH] tools: add missing header for xenctrl.h Changlong Xie
@ 2016-04-01 2:52 ` Changlong Xie
2016-04-01 10:04 ` Wei Liu
0 siblings, 1 reply; 9+ messages in thread
From: Changlong Xie @ 2016-04-01 2:52 UTC (permalink / raw)
To: xen devel, Konrad Rzeszutek Wilk, Ian Jackson, Wei Liu; +Cc: Wen Congyang
My build machine is
master:/etc # cat SuSE-release
SUSE Linux Enterprise Server 11 (x86_64)
VERSION = 11
PATCHLEVEL = 3
You may not to reproduce the same errors on fedora or some other platforms.
On 04/01/2016 10:46 AM, Changlong Xie wrote:
> Commit d275ec9c introduce ssize_t but not include relevant header,
> it will cause compile errors just like below:
>
> ./include/xenctrl.h:1485: error: expected '=', ',', ';', 'asm' or
> '__attribute__' before 'xc_version_len'
>
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
> ---
> tools/libxc/include/xenctrl.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/libxc/include/xenctrl.h b/tools/libxc/include/xenctrl.h
> index a9e4dc1..fb5c26c 100644
> --- a/tools/libxc/include/xenctrl.h
> +++ b/tools/libxc/include/xenctrl.h
> @@ -31,6 +31,7 @@
> #include <stdint.h>
> #include <stdio.h>
> #include <stdbool.h>
> +#include <unistd.h>
> #include <xen/xen.h>
> #include <xen/domctl.h>
> #include <xen/physdev.h>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] tools: add missing header for xenctrl.h
2016-04-01 2:52 ` Changlong Xie
@ 2016-04-01 10:04 ` Wei Liu
2016-03-31 11:25 ` [PATCH v2] tools/libxc: Fix build error when using xc_version_len Olaf Hering
0 siblings, 1 reply; 9+ messages in thread
From: Wei Liu @ 2016-04-01 10:04 UTC (permalink / raw)
To: Changlong Xie; +Cc: Wei Liu, Ian Jackson, Wen Congyang, xen devel
On Fri, Apr 01, 2016 at 10:52:08AM +0800, Changlong Xie wrote:
> My build machine is
>
> master:/etc # cat SuSE-release
> SUSE Linux Enterprise Server 11 (x86_64)
> VERSION = 11
> PATCHLEVEL = 3
>
> You may not to reproduce the same errors on fedora or some other platforms.
>
Olaf posted a similar patch yesterday.
This issue will be fixed soon.
Wei.
> On 04/01/2016 10:46 AM, Changlong Xie wrote:
> >Commit d275ec9c introduce ssize_t but not include relevant header,
> >it will cause compile errors just like below:
> >
> >./include/xenctrl.h:1485: error: expected '=', ',', ';', 'asm' or
> >'__attribute__' before 'xc_version_len'
> >
> >Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> >Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
> >---
> > tools/libxc/include/xenctrl.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> >diff --git a/tools/libxc/include/xenctrl.h b/tools/libxc/include/xenctrl.h
> >index a9e4dc1..fb5c26c 100644
> >--- a/tools/libxc/include/xenctrl.h
> >+++ b/tools/libxc/include/xenctrl.h
> >@@ -31,6 +31,7 @@
> > #include <stdint.h>
> > #include <stdio.h>
> > #include <stdbool.h>
> >+#include <unistd.h>
> > #include <xen/xen.h>
> > #include <xen/domctl.h>
> > #include <xen/physdev.h>
> >
>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2] tools/libxc: Fix build error when using xc_version_len
@ 2016-03-31 11:25 ` Olaf Hering
2016-03-31 14:23 ` Konrad Rzeszutek Wilk
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Olaf Hering @ 2016-03-31 11:25 UTC (permalink / raw)
To: xen-devel; +Cc: Wei Liu, Olaf Hering, Ian Jackson
Tools fails to build with gcc 4.5, it does not provide ssize_t.
Fixes d275ec9 ("libxc/libxl/python/xenstat/ocaml: Use new XEN_VERSION
hypercall")
Signed-off-by: Olaf Hering <olaf@aepfle.de>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
---
v2:
use correct summary
tools/libxc/include/xenctrl.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/libxc/include/xenctrl.h b/tools/libxc/include/xenctrl.h
index a9e4dc1..2140702 100644
--- a/tools/libxc/include/xenctrl.h
+++ b/tools/libxc/include/xenctrl.h
@@ -27,6 +27,7 @@
#define __XEN_TOOLS__ 1
#endif
+#include <unistd.h>
#include <stddef.h>
#include <stdint.h>
#include <stdio.h>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v2] tools/libxc: Fix build error when using xc_version_len
2016-03-31 11:25 ` [PATCH v2] tools/libxc: Fix build error when using xc_version_len Olaf Hering
@ 2016-03-31 14:23 ` Konrad Rzeszutek Wilk
2016-03-31 14:33 ` Olaf Hering
2016-04-01 13:47 ` Wei Liu
2016-04-01 13:50 ` [PATCH v2] tools/libxc: Fix build error when using xc_version_len [and 2 more messages] Ian Jackson
2 siblings, 1 reply; 9+ messages in thread
From: Konrad Rzeszutek Wilk @ 2016-03-31 14:23 UTC (permalink / raw)
To: Olaf Hering; +Cc: Ian Jackson, Wei Liu, xen-devel
On Thu, Mar 31, 2016 at 01:25:30PM +0200, Olaf Hering wrote:
> Tools fails to build with gcc 4.5, it does not provide ssize_t.
Which version of SLES/OpenSuSE had that? I had been using 4.4.4 and
5.3 and the compiler didn't hit that.
>
> Fixes d275ec9 ("libxc/libxl/python/xenstat/ocaml: Use new XEN_VERSION
> hypercall")
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> ---
> v2:
> use correct summary
>
> tools/libxc/include/xenctrl.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/libxc/include/xenctrl.h b/tools/libxc/include/xenctrl.h
> index a9e4dc1..2140702 100644
> --- a/tools/libxc/include/xenctrl.h
> +++ b/tools/libxc/include/xenctrl.h
> @@ -27,6 +27,7 @@
> #define __XEN_TOOLS__ 1
> #endif
>
> +#include <unistd.h>
> #include <stddef.h>
> #include <stdint.h>
> #include <stdio.h>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2] tools/libxc: Fix build error when using xc_version_len
2016-03-31 11:25 ` [PATCH v2] tools/libxc: Fix build error when using xc_version_len Olaf Hering
2016-03-31 14:23 ` Konrad Rzeszutek Wilk
@ 2016-04-01 13:47 ` Wei Liu
2016-04-01 13:50 ` [PATCH v2] tools/libxc: Fix build error when using xc_version_len [and 2 more messages] Ian Jackson
2 siblings, 0 replies; 9+ messages in thread
From: Wei Liu @ 2016-04-01 13:47 UTC (permalink / raw)
To: Olaf Hering; +Cc: Wei Liu, Ian Jackson, xen-devel
On Thu, Mar 31, 2016 at 01:25:30PM +0200, Olaf Hering wrote:
> Tools fails to build with gcc 4.5, it does not provide ssize_t.
>
> Fixes d275ec9 ("libxc/libxl/python/xenstat/ocaml: Use new XEN_VERSION
> hypercall")
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
> ---
> v2:
> use correct summary
>
Oh, I guessed I missed the subject line when acking v1.
> tools/libxc/include/xenctrl.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/libxc/include/xenctrl.h b/tools/libxc/include/xenctrl.h
> index a9e4dc1..2140702 100644
> --- a/tools/libxc/include/xenctrl.h
> +++ b/tools/libxc/include/xenctrl.h
> @@ -27,6 +27,7 @@
> #define __XEN_TOOLS__ 1
> #endif
>
> +#include <unistd.h>
> #include <stddef.h>
> #include <stdint.h>
> #include <stdio.h>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2] tools/libxc: Fix build error when using xc_version_len [and 2 more messages]
2016-03-31 11:25 ` [PATCH v2] tools/libxc: Fix build error when using xc_version_len Olaf Hering
2016-03-31 14:23 ` Konrad Rzeszutek Wilk
2016-04-01 13:47 ` Wei Liu
@ 2016-04-01 13:50 ` Ian Jackson
2016-04-01 15:29 ` Olaf Hering
2 siblings, 1 reply; 9+ messages in thread
From: Ian Jackson @ 2016-04-01 13:50 UTC (permalink / raw)
To: Wei Liu, Changlong Xie, Olaf Hering; +Cc: Wen Congyang, xen-devel
Olaf Hering writes ("[PATCH v2] tools/libxc: Fix build error when using xc_version_len"):
> Tools fails to build with gcc 4.5, it does not provide ssize_t.
Changlong Xie writes ("[PATCH] tools: add missing header for xenctrl.h"):
> Commit d275ec9c introduce ssize_t but not include relevant header,
> it will cause compile errors just like below:
Thanks for this. I have applied Olaf's version of this patch.
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2] tools/libxc: Fix build error when using xc_version_len [and 2 more messages]
2016-04-01 13:50 ` [PATCH v2] tools/libxc: Fix build error when using xc_version_len [and 2 more messages] Ian Jackson
@ 2016-04-01 15:29 ` Olaf Hering
0 siblings, 0 replies; 9+ messages in thread
From: Olaf Hering @ 2016-04-01 15:29 UTC (permalink / raw)
To: Ian Jackson; +Cc: Changlong Xie, Wei Liu, Wen Congyang, xen-devel
On Fri, Apr 01, Ian Jackson wrote:
> Olaf Hering writes ("[PATCH v2] tools/libxc: Fix build error when using xc_version_len"):
> > Tools fails to build with gcc 4.5, it does not provide ssize_t.
>
> Changlong Xie writes ("[PATCH] tools: add missing header for xenctrl.h"):
> > Commit d275ec9c introduce ssize_t but not include relevant header,
> > it will cause compile errors just like below:
>
> Thanks for this. I have applied Olaf's version of this patch.
>
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
d1da3d1:tools/libxc/include/xenctrl.h has now two #include unistd.h
Olaf
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-04-01 15:29 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-01 2:46 [PATCH] tools: add missing header for xenctrl.h Changlong Xie
2016-04-01 2:52 ` Changlong Xie
2016-04-01 10:04 ` Wei Liu
2016-03-31 11:25 ` [PATCH v2] tools/libxc: Fix build error when using xc_version_len Olaf Hering
2016-03-31 14:23 ` Konrad Rzeszutek Wilk
2016-03-31 14:33 ` Olaf Hering
2016-04-01 13:47 ` Wei Liu
2016-04-01 13:50 ` [PATCH v2] tools/libxc: Fix build error when using xc_version_len [and 2 more messages] Ian Jackson
2016-04-01 15:29 ` Olaf Hering
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).