xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Paul Durrant <paul.durrant@citrix.com>,
	Jun Nakajima <jun.nakajima@intel.com>,
	xen-devel@lists.xenproject.org, Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH v2] x86/hvm: separate ioreq server code from generic hvm code
Date: Fri, 1 Apr 2016 15:04:47 +0100	[thread overview]
Message-ID: <20160401140447.GF27636@citrix.com> (raw)
In-Reply-To: <56FE98AE02000078000E2161@prv-mh.provo.novell.com>

On Fri, Apr 01, 2016 at 07:50:06AM -0600, Jan Beulich wrote:
> >>> On 01.04.16 at 09:54, <paul.durrant@citrix.com> wrote:
> > The code in hvm/hvm.c related to handling I/O emulation using the ioreq
> > server framework is large and mostly self-contained.
> > 
> > This patch separates the ioreq server code into a new hvm/ioreq.c source
> > module and accompanying asm-x86/hvm/ioreq.h header file. There is no
> > intended functional change, only code movement.
> 
> Considering how badly the diff gets represented, I can only trust
> you on that.
> 
> > Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
> 
> Acked-by: Jan Beulich <jbeulich@suse.com>
> 
> But as indicated on IRC already, Wei will need to give his okay,
> as this is something that didn't get posted prior to the feature
> freeze date.
> 

Acked-by: Wei Liu <wei.liu2@citrix.com>

Not a new feature by my definition, so I don't object to this. This
needs to be applied as soon as possible though so that OSSTest can catch
any issue.

Wei.

> Jan
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-04-01 14:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-01  7:54 [PATCH v2] x86/hvm: separate ioreq server code from generic hvm code Paul Durrant
2016-04-01 13:50 ` Jan Beulich
2016-04-01 14:04   ` Wei Liu [this message]
2016-04-01 14:35 ` Jan Beulich
2016-04-01 14:53   ` Paul Durrant
2016-04-04 16:07 ` Boris Ostrovsky
2016-04-06 13:20   ` Wei Liu
2016-04-06 13:22     ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160401140447.GF27636@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=jun.nakajima@intel.com \
    --cc=keir@xen.org \
    --cc=paul.durrant@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).