From: Wei Liu <wei.liu2@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: libvir-list@redhat.com, cardoe@cardoe.com,
Jim Fehlig <jfehlig@suse.com>, Wei Liu <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] libxl: libxl_domain_create_restore has an extra argument
Date: Wed, 6 Apr 2016 12:24:35 +0100 [thread overview]
Message-ID: <20160406112435.GM18120__696.785320951854$1459941891$gmane$org@citrix.com> (raw)
In-Reply-To: <22275.54777.889693.883970@mariner.uk.xensource.com>
On Tue, Apr 05, 2016 at 04:12:57PM +0100, Ian Jackson wrote:
> Wei Liu writes ("Re: [PATCH] libxl: libxl_domain_create_restore has an extra argument"):
> > CC Jim as well
> >
> > On Tue, Apr 05, 2016 at 03:20:12PM +0100, Wei Liu wrote:
> > > In the latest libxenlight code, libxl_domain_create_restore accepts a
> > > new argument. Update libvirt's libxl driver for that. Use the macro
> > > provided by libxenlight to detect which version should be used.
> > >
> > > The new parameter (send_back_fd) is set to -1 because libvirt provides
> > > no such fd.
> ...
> > > -#ifdef LIBXL_HAVE_DOMAIN_CREATE_RESTORE_PARAMS
> > > +#if defined(LIBXL_HAVE_DOMAIN_CREATE_RESTORE_SEND_BACK_FD)
> > > + params.checkpointed_stream = 0;
> > > + ret = libxl_domain_create_restore(cfg->ctx, &d_config, &domid,
> > > + restore_fd, -1, ¶ms, NULL,
> > > + &aop_console_how);
> > > +#elif defined(LIBXL_HAVE_DOMAIN_CREATE_RESTORE_PARAMS)
> > > params.checkpointed_stream = 0;
> > > ret = libxl_domain_create_restore(cfg->ctx, &d_config, &domid,
> > > restore_fd, ¶ms, NULL,
>
> Another approach would be
>
> ret = libxl_domain_create_restore(cfg->ctx, &d_config, &domid,
> restore_fd,
> #ifdef LIBXL_HAVE_DOMAIN_CREATE_RESTORE_SEND_BACK_FD
> -1,
> #endif
> #ifdef LIBXL_HAVE_DOMAIN_CREATE_RESTORE_PARAMS
> ¶ms,
> #endif
> NULL, &aop_console_how);
>
> But which to choose is a matter of taste.
>
I merely followed the existing style. Let's keep it that way for now.
Wei.
> Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-06 11:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 14:20 [PATCH] libxl: libxl_domain_create_restore has an extra argument Wei Liu
2016-04-05 14:28 ` Wei Liu
2016-04-05 15:12 ` Ian Jackson
[not found] ` <22275.54777.889693.883970@mariner.uk.xensource.com>
2016-04-06 11:24 ` Wei Liu [this message]
2016-04-06 21:43 ` Doug Goldstein
[not found] ` <570582EB.4050305@cardoe.com>
2016-04-07 16:35 ` [libvirt] " Daniel P. Berrange
2016-04-07 17:44 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20160406112435.GM18120__696.785320951854$1459941891$gmane$org@citrix.com' \
--to=wei.liu2@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=cardoe@cardoe.com \
--cc=jfehlig@suse.com \
--cc=libvir-list@redhat.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).