* [PATCH] xsplice: Prevent new symbols duplicating core symbols
@ 2016-05-10 9:10 Ross Lagerwall
2016-05-10 9:32 ` Wei Liu
0 siblings, 1 reply; 2+ messages in thread
From: Ross Lagerwall @ 2016-05-10 9:10 UTC (permalink / raw)
To: xen-devel; +Cc: Ross Lagerwall, Wei Liu, Jan Beulich
When loading patches, the code prevents loading a patch containing a new
symbol that duplicates a symbol from another loaded patch. However, the
check should also prevent loading a new symbol that duplicates a symbol
from the core hypervisor.
Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
---
Wei, can you consider this for 4.7? Thanks
xen/common/xsplice.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/xen/common/xsplice.c b/xen/common/xsplice.c
index c9fc53a..21b9ec0 100644
--- a/xen/common/xsplice.c
+++ b/xen/common/xsplice.c
@@ -748,7 +748,8 @@ static int build_symbol_table(struct payload *payload,
if ( !found )
{
- if ( xsplice_symbols_lookup_by_name(symtab[i].name) )
+ if ( symbols_lookup_by_name(symtab[i].name) ||
+ xsplice_symbols_lookup_by_name(symtab[i].name) )
{
dprintk(XENLOG_ERR, XSPLICE "%s: duplicate new symbol: %s\n",
elf->name, symtab[i].name);
--
2.4.11
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xsplice: Prevent new symbols duplicating core symbols
2016-05-10 9:10 [PATCH] xsplice: Prevent new symbols duplicating core symbols Ross Lagerwall
@ 2016-05-10 9:32 ` Wei Liu
0 siblings, 0 replies; 2+ messages in thread
From: Wei Liu @ 2016-05-10 9:32 UTC (permalink / raw)
To: Ross Lagerwall; +Cc: Wei Liu, Jan Beulich, xen-devel
On Tue, May 10, 2016 at 10:10:02AM +0100, Ross Lagerwall wrote:
> When loading patches, the code prevents loading a patch containing a new
> symbol that duplicates a symbol from another loaded patch. However, the
> check should also prevent loading a new symbol that duplicates a symbol
> from the core hypervisor.
>
> Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
> ---
>
> Wei, can you consider this for 4.7? Thanks
>
This looks like a valid and simple bug fix, I'm fine with this going
into 4.7.
Wei.
> xen/common/xsplice.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/xen/common/xsplice.c b/xen/common/xsplice.c
> index c9fc53a..21b9ec0 100644
> --- a/xen/common/xsplice.c
> +++ b/xen/common/xsplice.c
> @@ -748,7 +748,8 @@ static int build_symbol_table(struct payload *payload,
>
> if ( !found )
> {
> - if ( xsplice_symbols_lookup_by_name(symtab[i].name) )
> + if ( symbols_lookup_by_name(symtab[i].name) ||
> + xsplice_symbols_lookup_by_name(symtab[i].name) )
> {
> dprintk(XENLOG_ERR, XSPLICE "%s: duplicate new symbol: %s\n",
> elf->name, symtab[i].name);
> --
> 2.4.11
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-10 9:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-10 9:10 [PATCH] xsplice: Prevent new symbols duplicating core symbols Ross Lagerwall
2016-05-10 9:32 ` Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).