[PATCH] xsplice: Unmask (aka reinstall NMI handler) if we need to abort.

* [PATCH] xsplice: Unmask (aka reinstall NMI handler) if we need to abort.
@ 2016-05-11 13:59 Konrad Rzeszutek Wilk
  2016-05-11 14:00 ` Andrew Cooper
  2016-05-11 14:05 ` Wei Liu
  0 siblings, 2 replies; 3+ messages in thread
From: Konrad Rzeszutek Wilk @ 2016-05-11 13:59 UTC (permalink / raw)
  To: xen-devel
  Cc: wei.liu2, Konrad Rzeszutek Wilk, Martin Pohlack, ross.lagerwall,
	<andrew.cooper3, jbeulich

If we have to abort in xsplice_spin() we end following
the goto abort. But unfortunataly we neglected to unmask.
This patch fixes that.

Reported-by: Martin Pohlack <mpohlack@amazon.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

---
Cc: jbeulich@suse.com
Cc: <andrew.cooper3@citrix.com
Cc: ross.lagerwall@citrix.com
Cc: Martin Pohlack <mpohlack@amazon.com>

This has been since v6 posting. v5 posting used the
set_nmi_callback and only used it around the IRQ semaphore.
---
 xen/common/xsplice.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/xen/common/xsplice.c b/xen/common/xsplice.c
index 21b9ec0..b68875b 100644
--- a/xen/common/xsplice.c
+++ b/xen/common/xsplice.c
@@ -1262,9 +1262,10 @@ void check_for_xsplice_work(void)
             arch_xsplice_post_action();
             local_irq_restore(flags);
         }
-        arch_xsplice_unmask();
 
  abort:
+        arch_xsplice_unmask();
+
         per_cpu(work_to_do, cpu) = 0;
         xsplice_work.do_work = 0;
 
-- 
2.5.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

^ permalink raw reply related	[flat|nested] 3+ messages in thread