xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: sstabellini@kernel.org, wei.liu2@citrix.com,
	steve.capper@arm.com, andrew.cooper3@citrix.com,
	xen-devel@lists.xen.org, julien.grall@arm.com,
	Wei Chen <wei.chen@linaro.org>
Subject: Re: [RFC v2] xen/arm: build: add missed dependency for head.S [and 1 more messages]
Date: Tue, 7 Jun 2016 17:24:51 +0100	[thread overview]
Message-ID: <20160607162451.GR25922@citrix.com> (raw)
In-Reply-To: <22358.61407.418451.98819@mariner.uk.xensource.com>

On Tue, Jun 07, 2016 at 05:01:35PM +0100, Ian Jackson wrote:
> Wei Chen writes ("[RFC v2] xen/arm: build: add missed dependency for head.S"):
> > In current Xen build rules, the build system will only check the
> > dependencies in current folder and obj-y generated dependencies
> > in other folder.
> > 
> > But Makefile may add some objects to ALL_OBJS. These objects may
> > be not in the same folder as Makefile. Use arch/arm/Makefile as
> > an example:
> >     ALL_OBJS := $(TARGET_SUBARCH)/head.o
> 
> Thanks for the v2.
> 
> But I think I actually somewhat prefer the v1 approach, for these
> reasons:
> 
> On 03/06/16 11:07, Wei Chen wrote:
> > In my mind, the better way to fix this bug is converting the DEPS from
> > ALL_OBJS. But I am afraid of the impact. I am not sure whether there
> > are some dependencies are not generated from obj files.
> > 
> Ian Jackson writes ("Re: [RFC] xen/arm: build: add missed dependency for head.S"):
> > I do like this idea but I have the same worry.  It might be possible
> > to dump ALL_OBJS out somehow and check this, but it might be
> > arch-dependent.
> > 
> > Wei Chen's patch is IMO a straightforward fix.
> 
> I won't NAK the v2 but I think if Wei Chen is still happy for us to do
> so, we should commit the v1.
> 
> Ian.

We shall take either v1 or v2. I don't really have an opinion which one.

Either one:

Release-acked-by: Wei Liu <wei.liu2@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-06-07 16:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-03 10:07 [RFC] xen/arm: build: add missed dependency for head.S Wei Chen
2016-06-06 17:08 ` Julien Grall
2016-06-07 10:03   ` Ian Jackson
2016-06-07  4:34     ` [RFC v2] " Wei Chen
2016-06-07 13:18       ` Konrad Rzeszutek Wilk
2016-06-08  3:10         ` Wei Chen
2016-06-07 16:01       ` [RFC v2] xen/arm: build: add missed dependency for head.S [and 1 more messages] Ian Jackson
2016-06-07 16:24         ` Wei Liu [this message]
2016-06-08  3:14           ` Wei Chen
2016-06-08  8:09             ` Wei Liu
2016-06-07 10:07     ` [RFC] xen/arm: build: add missed dependency for head.S Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160607162451.GR25922@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=julien.grall@arm.com \
    --cc=sstabellini@kernel.org \
    --cc=steve.capper@arm.com \
    --cc=wei.chen@linaro.org \
    --cc=xen-devel@lists.xen.org \
    --subject='Re: [RFC v2] xen/arm: build: add missed dependency for head.S [and 1 more messages]' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).