xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] XSM/policy: Allow the source domain access to settime and setdomainhandle domctls while creating domain.
@ 2016-07-07 13:45 Anshul
  2016-07-07 14:49 ` Daniel De Graaf
  0 siblings, 1 reply; 3+ messages in thread
From: Anshul @ 2016-07-07 13:45 UTC (permalink / raw)
  To: xen-devel; +Cc: ian.jackson, dgdegra, wei.liu2, Anshul Makkar

From: Anshul Makkar <anshul.makkar@citrix.com>

This patch resolves the following permission denied scenarios while creating
new domU :
avc:  denied  { setdomainhandle } for domid=0 target=1
scontext=system_u:system_r:dom0_t tcontext=system_u:system_r:domU_t tclass=domain

avc:  denied  { settime } for domid=0 target=1 scontext=system_u:system_r:dom0_t
tcontext=system_u:system_r:domU_t tclass=domain

Signed-off-by: Anshul Makkar <anshul.makkar@citrix.com>
---
 tools/flask/policy/modules/xen.if | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/flask/policy/modules/xen.if b/tools/flask/policy/modules/xen.if
index fd96303..8c43c28 100644
--- a/tools/flask/policy/modules/xen.if
+++ b/tools/flask/policy/modules/xen.if
@@ -48,7 +48,8 @@ define(`declare_build_label', `
 define(`create_domain_common', `
 	allow $1 $2:domain { create max_vcpus setdomainmaxmem setaddrsize
 			getdomaininfo hypercall setvcpucontext getscheduler
-			getvcpuinfo getaddrsize getaffinity setaffinity };
+			getvcpuinfo getaddrsize getaffinity setaffinity
+			settime setdomainhandle };
 	allow $1 $2:domain2 { set_cpuid settsc setscheduler setclaim
 			set_max_evtchn set_vnumainfo get_vnumainfo cacheflush
 			psr_cmt_op psr_cat_op soft_reset };
-- 
1.9.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] XSM/policy: Allow the source domain access to settime and setdomainhandle domctls while creating domain.
  2016-07-07 13:45 [PATCH] XSM/policy: Allow the source domain access to settime and setdomainhandle domctls while creating domain Anshul
@ 2016-07-07 14:49 ` Daniel De Graaf
  2016-07-07 14:52   ` Wei Liu
  0 siblings, 1 reply; 3+ messages in thread
From: Daniel De Graaf @ 2016-07-07 14:49 UTC (permalink / raw)
  To: Anshul.Makkar.anshul.makkar, xen-devel
  Cc: ian.jackson, Anshul Makkar, wei.liu2

On 07/07/2016 09:45 AM, Anshul.Makkar.anshul.makkar@citrix.com wrote:
> From: Anshul Makkar <anshul.makkar@citrix.com>
>
> This patch resolves the following permission denied scenarios while creating
> new domU :
> avc:  denied  { setdomainhandle } for domid=0 target=1
> scontext=system_u:system_r:dom0_t tcontext=system_u:system_r:domU_t tclass=domain
>
> avc:  denied  { settime } for domid=0 target=1 scontext=system_u:system_r:dom0_t
> tcontext=system_u:system_r:domU_t tclass=domain
>
> Signed-off-by: Anshul Makkar <anshul.makkar@citrix.com>

Acked-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] XSM/policy: Allow the source domain access to settime and setdomainhandle domctls while creating domain.
  2016-07-07 14:49 ` Daniel De Graaf
@ 2016-07-07 14:52   ` Wei Liu
  0 siblings, 0 replies; 3+ messages in thread
From: Wei Liu @ 2016-07-07 14:52 UTC (permalink / raw)
  To: Daniel De Graaf; +Cc: ian.jackson, anshul.makkar, wei.liu2, xen-devel

On Thu, Jul 07, 2016 at 10:49:01AM -0400, Daniel De Graaf wrote:
> On 07/07/2016 09:45 AM, Anshul.Makkar.anshul.makkar@citrix.com wrote:
> >From: Anshul Makkar <anshul.makkar@citrix.com>
> >
> >This patch resolves the following permission denied scenarios while creating
> >new domU :
> >avc:  denied  { setdomainhandle } for domid=0 target=1
> >scontext=system_u:system_r:dom0_t tcontext=system_u:system_r:domU_t tclass=domain
> >
> >avc:  denied  { settime } for domid=0 target=1 scontext=system_u:system_r:dom0_t
> >tcontext=system_u:system_r:domU_t tclass=domain
> >
> >Signed-off-by: Anshul Makkar <anshul.makkar@citrix.com>
> 
> Acked-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>

Queued. Thank you both.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-07-07 14:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-07 13:45 [PATCH] XSM/policy: Allow the source domain access to settime and setdomainhandle domctls while creating domain Anshul
2016-07-07 14:49 ` Daniel De Graaf
2016-07-07 14:52   ` Wei Liu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).