* [PATCH 1/2] systemd: use standard dependencies for xendriverdomain.service
@ 2016-07-24 19:26 Marek Marczykowski-Górecki
2016-07-25 9:17 ` Wei Liu
0 siblings, 1 reply; 3+ messages in thread
From: Marek Marczykowski-Górecki @ 2016-07-24 19:26 UTC (permalink / raw)
To: xen-devel; +Cc: Wei Liu, Ian Jackson, Marek Marczykowski-Górecki
[-- Attachment #1.1: Type: text/plain, Size: 1097 bytes --]
Having DefaultDependencies=no means it can be started before / is
remounted read-write, which will result in various failures (to start
with opening the log).
Since "libxl: trigger attach events for devices attached before xl devd
startup" it is no longer important to start it as early as possible,
because it will process devices created before its startup.
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
---
tools/hotplug/Linux/systemd/xendriverdomain.service.in | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/hotplug/Linux/systemd/xendriverdomain.service.in b/tools/hotplug/Linux/systemd/xendriverdomain.service.in
index c0cd454..0afb54d 100644
--- a/tools/hotplug/Linux/systemd/xendriverdomain.service.in
+++ b/tools/hotplug/Linux/systemd/xendriverdomain.service.in
@@ -1,6 +1,5 @@
[Unit]
Description=Xen driver domain device daemon
-DefaultDependencies=no
Requires=proc-xen.mount
After=proc-xen.mount
ConditionVirtualization=xen
--
2.5.5
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] systemd: use standard dependencies for xendriverdomain.service
2016-07-24 19:26 [PATCH 1/2] systemd: use standard dependencies for xendriverdomain.service Marek Marczykowski-Górecki
@ 2016-07-25 9:17 ` Wei Liu
2016-07-25 13:22 ` Wei Liu
0 siblings, 1 reply; 3+ messages in thread
From: Wei Liu @ 2016-07-25 9:17 UTC (permalink / raw)
To: Marek Marczykowski-Górecki
Cc: Wei Liu, Rusty Bird, Ian Jackson, xen-devel
On Sun, Jul 24, 2016 at 09:26:57PM +0200, Marek Marczykowski-Górecki wrote:
> Having DefaultDependencies=no means it can be started before / is
> remounted read-write, which will result in various failures (to start
> with opening the log).
> Since "libxl: trigger attach events for devices attached before xl devd
> startup" it is no longer important to start it as early as possible,
> because it will process devices created before its startup.
>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
The reasoning makes sense.
Acked-by: Wei Liu <wei.liu2@citrix.com>
Also CC Rusty (author of this file)
> ---
> tools/hotplug/Linux/systemd/xendriverdomain.service.in | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/hotplug/Linux/systemd/xendriverdomain.service.in b/tools/hotplug/Linux/systemd/xendriverdomain.service.in
> index c0cd454..0afb54d 100644
> --- a/tools/hotplug/Linux/systemd/xendriverdomain.service.in
> +++ b/tools/hotplug/Linux/systemd/xendriverdomain.service.in
> @@ -1,6 +1,5 @@
> [Unit]
> Description=Xen driver domain device daemon
> -DefaultDependencies=no
> Requires=proc-xen.mount
> After=proc-xen.mount
> ConditionVirtualization=xen
> --
> 2.5.5
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] systemd: use standard dependencies for xendriverdomain.service
2016-07-25 9:17 ` Wei Liu
@ 2016-07-25 13:22 ` Wei Liu
0 siblings, 0 replies; 3+ messages in thread
From: Wei Liu @ 2016-07-25 13:22 UTC (permalink / raw)
To: Marek Marczykowski-Górecki
Cc: Wei Liu, Rusty Bird, Ian Jackson, xen-devel
On Mon, Jul 25, 2016 at 10:17:44AM +0100, Wei Liu wrote:
> On Sun, Jul 24, 2016 at 09:26:57PM +0200, Marek Marczykowski-Górecki wrote:
> > Having DefaultDependencies=no means it can be started before / is
> > remounted read-write, which will result in various failures (to start
> > with opening the log).
> > Since "libxl: trigger attach events for devices attached before xl devd
> > startup" it is no longer important to start it as early as possible,
> > because it will process devices created before its startup.
> >
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > Cc: Wei Liu <wei.liu2@citrix.com>
> > Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
>
> The reasoning makes sense.
>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
>
> Also CC Rusty (author of this file)
>
Pushed.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-25 13:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-24 19:26 [PATCH 1/2] systemd: use standard dependencies for xendriverdomain.service Marek Marczykowski-Górecki
2016-07-25 9:17 ` Wei Liu
2016-07-25 13:22 ` Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).