From: Anthony PERARD <anthony.perard@citrix.com> To: xen-devel@lists.xenproject.org Cc: Anthony PERARD <anthony.perard@citrix.com>, Wei Liu <wei.liu2@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com> Subject: [PATCH 2/9] libxl: Pointer on usage of libxl__domain_userdata_lock Date: Tue, 9 Apr 2019 17:45:35 +0100 [thread overview] Message-ID: <20190409164542.30274-3-anthony.perard@citrix.com> (raw) In-Reply-To: <20190409164542.30274-1-anthony.perard@citrix.com> It is currently difficult to know how/when/why the userdata lock is supposed to be used. Add some pointers to the hotplug comments. Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> --- tools/libxl/libxl_internal.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h index 98a1ee6159..702acc6d5d 100644 --- a/tools/libxl/libxl_internal.h +++ b/tools/libxl/libxl_internal.h @@ -4500,6 +4500,12 @@ void libxl__unlock_domain_userdata(libxl__domain_userdata_lock *lock); * data store. The registry entry in libxl private data store * is "libxl-json". * Caller must hold user data lock. + * + * Other names used for this lock throughout the libxl code are json_lock, + * libxl__domain_userdata_lock, "libxl-json", data store lock. + * + * See comments about libxl__ao_device and "Algorithm for handling device + * removal" on how the libxl-json lock / json_lock can be used. */ int libxl__get_domain_configuration(libxl__gc *gc, uint32_t domid, libxl_domain_config *d_config); -- Anthony PERARD _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Anthony PERARD <anthony.perard@citrix.com> To: <xen-devel@lists.xenproject.org> Cc: Anthony PERARD <anthony.perard@citrix.com>, Wei Liu <wei.liu2@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com> Subject: [Xen-devel] [PATCH 2/9] libxl: Pointer on usage of libxl__domain_userdata_lock Date: Tue, 9 Apr 2019 17:45:35 +0100 [thread overview] Message-ID: <20190409164542.30274-3-anthony.perard@citrix.com> (raw) Message-ID: <20190409164535.TVA4VxkArkLS5qdY-H0wKrr3PnD9W9rmole92TTVtu8@z> (raw) In-Reply-To: <20190409164542.30274-1-anthony.perard@citrix.com> It is currently difficult to know how/when/why the userdata lock is supposed to be used. Add some pointers to the hotplug comments. Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> --- tools/libxl/libxl_internal.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h index 98a1ee6159..702acc6d5d 100644 --- a/tools/libxl/libxl_internal.h +++ b/tools/libxl/libxl_internal.h @@ -4500,6 +4500,12 @@ void libxl__unlock_domain_userdata(libxl__domain_userdata_lock *lock); * data store. The registry entry in libxl private data store * is "libxl-json". * Caller must hold user data lock. + * + * Other names used for this lock throughout the libxl code are json_lock, + * libxl__domain_userdata_lock, "libxl-json", data store lock. + * + * See comments about libxl__ao_device and "Algorithm for handling device + * removal" on how the libxl-json lock / json_lock can be used. */ int libxl__get_domain_configuration(libxl__gc *gc, uint32_t domid, libxl_domain_config *d_config); -- Anthony PERARD _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-04-09 16:45 UTC|newest] Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-09 16:45 [PATCH 0/9] libxl: New slow lock + fix libxl_cdrom_insert with QEMU depriv Anthony PERARD 2019-04-09 16:45 ` [Xen-devel] " Anthony PERARD 2019-04-09 16:45 ` [PATCH 1/9] libxl_internal: Remove lost comment Anthony PERARD 2019-04-09 16:45 ` [Xen-devel] " Anthony PERARD 2019-04-10 9:18 ` Wei Liu 2019-04-10 9:18 ` [Xen-devel] " Wei Liu 2019-06-04 16:42 ` Ian Jackson 2019-04-09 16:45 ` Anthony PERARD [this message] 2019-04-09 16:45 ` [Xen-devel] [PATCH 2/9] libxl: Pointer on usage of libxl__domain_userdata_lock Anthony PERARD 2019-06-04 16:46 ` Ian Jackson 2019-04-09 16:45 ` [PATCH 3/9] libxl_internal: Split out userdata lock function Anthony PERARD 2019-04-09 16:45 ` [Xen-devel] " Anthony PERARD 2019-06-04 16:55 ` Ian Jackson 2019-04-09 16:45 ` [PATCH 4/9] libxl_internal: Create new lock for devices hotplug via QMP Anthony PERARD 2019-04-09 16:45 ` [Xen-devel] " Anthony PERARD 2019-06-04 17:11 ` Ian Jackson 2019-06-05 14:10 ` Anthony PERARD 2019-06-05 14:32 ` Ian Jackson 2019-04-09 16:45 ` [PATCH 5/9] libxl_disk: Reorganise libxl_cdrom_insert Anthony PERARD 2019-04-09 16:45 ` [Xen-devel] " Anthony PERARD 2019-06-04 17:16 ` Ian Jackson 2019-04-09 16:45 ` [PATCH 6/9] libxl_disk: Cut libxl_cdrom_insert into steps Anthony PERARD 2019-04-09 16:45 ` [Xen-devel] " Anthony PERARD 2019-06-04 17:29 ` Ian Jackson 2019-06-07 17:22 ` Anthony PERARD 2019-04-09 16:45 ` [PATCH 7/9] libxl: Move qmp_parameters_* prototypes to libxl_internal.h Anthony PERARD 2019-04-09 16:45 ` [Xen-devel] " Anthony PERARD 2019-06-04 17:32 ` Ian Jackson 2019-04-09 16:45 ` [PATCH 8/9] libxl_disk: Use ev_qmp in libxl_cdrom_insert Anthony PERARD 2019-04-09 16:45 ` [Xen-devel] " Anthony PERARD 2019-06-04 17:45 ` Ian Jackson 2019-04-09 16:45 ` [PATCH 9/9] libxl_disk: Implement missing timeout for libxl_cdrom_insert Anthony PERARD 2019-04-09 16:45 ` [Xen-devel] " Anthony PERARD 2019-06-04 17:47 ` Ian Jackson 2019-06-05 14:22 ` Anthony PERARD 2019-06-05 14:33 ` Ian Jackson 2019-06-04 10:54 ` [Xen-devel] Ping: [PATCH 0/9] libxl: New slow lock + fix libxl_cdrom_insert with QEMU depriv Anthony PERARD
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190409164542.30274-3-anthony.perard@citrix.com \ --to=anthony.perard@citrix.com \ --cc=ian.jackson@eu.citrix.com \ --cc=wei.liu2@citrix.com \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).