From: Wei Liu <wei.liu2@citrix.com> To: Olaf Hering <olaf@aepfle.de> Cc: "Anthony PERARD" <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org, "Wei Liu" <wei.liu2@citrix.com>, "Ian Jackson" <ian.jackson@eu.citrix.com>, "Roger Pau Monné" <roger.pau@citrix.com> Subject: Re: [PATCH v5] libxl: fix migration of PV and PVH domUs with and without qemu Date: Tue, 14 May 2019 16:42:04 +0100 [thread overview] Message-ID: <20190514154204.GI2798@zion.uk.xensource.com> (raw) In-Reply-To: <20190514164419.23f9f545.olaf@aepfle.de> On Tue, May 14, 2019 at 04:44:19PM +0200, Olaf Hering wrote: > Am Tue, 14 May 2019 15:38:55 +0100 > schrieb Wei Liu <wei.liu2@citrix.com>: > > > > While it is easy for the resume path, doing the same in the suspend path > > > needs more changes. libxl__domain_suspend_device_model would need to receive > > > the callback and set it if a device model is active. > > > > What do you mean here? Can't you handle the NONE case just like you do > > in the resume function? > > It means calling libxl__domain_suspend_device_model unconditionally, and > let that function decide what to do. Maybe there is no downside to set the > callback unconditionally, I will check that. Sure. In the meantime I will apply this patch at some point to fix the bug first. Wei. > > Olaf _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Wei Liu <wei.liu2@citrix.com> To: Olaf Hering <olaf@aepfle.de> Cc: "Anthony PERARD" <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org, "Wei Liu" <wei.liu2@citrix.com>, "Ian Jackson" <ian.jackson@eu.citrix.com>, "Roger Pau Monné" <roger.pau@citrix.com> Subject: Re: [Xen-devel] [PATCH v5] libxl: fix migration of PV and PVH domUs with and without qemu Date: Tue, 14 May 2019 16:42:04 +0100 [thread overview] Message-ID: <20190514154204.GI2798@zion.uk.xensource.com> (raw) Message-ID: <20190514154204.u41-2KFWo-T237fNEBoMK5AyW1WUxWcAmOdlXUbYMC0@z> (raw) In-Reply-To: <20190514164419.23f9f545.olaf@aepfle.de> On Tue, May 14, 2019 at 04:44:19PM +0200, Olaf Hering wrote: > Am Tue, 14 May 2019 15:38:55 +0100 > schrieb Wei Liu <wei.liu2@citrix.com>: > > > > While it is easy for the resume path, doing the same in the suspend path > > > needs more changes. libxl__domain_suspend_device_model would need to receive > > > the callback and set it if a device model is active. > > > > What do you mean here? Can't you handle the NONE case just like you do > > in the resume function? > > It means calling libxl__domain_suspend_device_model unconditionally, and > let that function decide what to do. Maybe there is no downside to set the > callback unconditionally, I will check that. Sure. In the meantime I will apply this patch at some point to fix the bug first. Wei. > > Olaf _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-05-14 15:42 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-14 8:05 [PATCH v5] libxl: fix migration of PV and PVH domUs with and without qemu Olaf Hering 2019-05-14 8:05 ` [Xen-devel] " Olaf Hering 2019-05-14 8:14 ` Olaf Hering 2019-05-14 8:14 ` [Xen-devel] " Olaf Hering 2019-05-14 14:38 ` Wei Liu 2019-05-14 14:38 ` [Xen-devel] " Wei Liu 2019-05-14 14:44 ` Olaf Hering 2019-05-14 14:44 ` [Xen-devel] " Olaf Hering 2019-05-14 15:42 ` Wei Liu [this message] 2019-05-14 15:42 ` Wei Liu 2019-05-14 11:19 ` Roger Pau Monné 2019-05-14 11:19 ` [Xen-devel] " Roger Pau Monné
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190514154204.GI2798@zion.uk.xensource.com \ --to=wei.liu2@citrix.com \ --cc=anthony.perard@citrix.com \ --cc=ian.jackson@eu.citrix.com \ --cc=olaf@aepfle.de \ --cc=roger.pau@citrix.com \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).