From: Wei Liu <wei.liu2@citrix.com> To: Andrew Cooper <andrew.cooper3@citrix.com> Cc: xen-devel@lists.xenproject.org, Wei Liu <wei.liu2@citrix.com> Subject: Re: [PATCH v3] libxl: make vkbd tunable for HVM guests Date: Wed, 15 May 2019 10:53:14 +0100 [thread overview] Message-ID: <20190515095314.GD3977@zion.uk.xensource.com> (raw) In-Reply-To: <3b441efd-c459-eee5-12c9-6c749fc18689@citrix.com> On Wed, May 15, 2019 at 10:49:58AM +0100, Andrew Cooper wrote: > On 15/05/2019 10:47, Wei Liu wrote: > > On Tue, May 14, 2019 at 08:43:25AM +0000, Eslam Elnikety wrote: > >> Each HVM guest currently gets a vkbd frontend/backend pair (c/s ebbd2561b4c). > >> This consumes host resources unnecessarily for guests that have no use for > >> vkbd. Make this behaviour tunable to allow an administrator to choose. The > >> commit retains the current behaviour -- HVM guests still get vkdb unless > >> specified otherwise. > >> > >> Signed-off-by: Eslam Elnikety <elnikety@amazon.com> > >> --- > >> Changes in v2: > >> - Added a missing hunk / setting vkb_device per config > >> > >> Changes in v3: > >> - Added entries in libxl.h and in documentation > >> --- > >> docs/man/xl.cfg.pod.5.in | 4 ++++ > > I wonder where you got this file. :p > > > > The correct file name is xl.cfg.5.pod.in. > > I reversed the .pod and .5 in 8410fcb54ac808c19a030c6f0ec64e760ac64ca5 > > This is likely a patch against 4.11 or earlier. Oh, that explains it. Wei. > > ~Andrew > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xenproject.org > https://lists.xenproject.org/mailman/listinfo/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Wei Liu <wei.liu2@citrix.com> To: Andrew Cooper <andrew.cooper3@citrix.com> Cc: xen-devel@lists.xenproject.org, Wei Liu <wei.liu2@citrix.com> Subject: Re: [Xen-devel] [PATCH v3] libxl: make vkbd tunable for HVM guests Date: Wed, 15 May 2019 10:53:14 +0100 [thread overview] Message-ID: <20190515095314.GD3977@zion.uk.xensource.com> (raw) Message-ID: <20190515095314.Zgs5GignQUIx2NNSE-4X0UB3c0AJLynqKOnHb8uMUjU@z> (raw) In-Reply-To: <3b441efd-c459-eee5-12c9-6c749fc18689@citrix.com> On Wed, May 15, 2019 at 10:49:58AM +0100, Andrew Cooper wrote: > On 15/05/2019 10:47, Wei Liu wrote: > > On Tue, May 14, 2019 at 08:43:25AM +0000, Eslam Elnikety wrote: > >> Each HVM guest currently gets a vkbd frontend/backend pair (c/s ebbd2561b4c). > >> This consumes host resources unnecessarily for guests that have no use for > >> vkbd. Make this behaviour tunable to allow an administrator to choose. The > >> commit retains the current behaviour -- HVM guests still get vkdb unless > >> specified otherwise. > >> > >> Signed-off-by: Eslam Elnikety <elnikety@amazon.com> > >> --- > >> Changes in v2: > >> - Added a missing hunk / setting vkb_device per config > >> > >> Changes in v3: > >> - Added entries in libxl.h and in documentation > >> --- > >> docs/man/xl.cfg.pod.5.in | 4 ++++ > > I wonder where you got this file. :p > > > > The correct file name is xl.cfg.5.pod.in. > > I reversed the .pod and .5 in 8410fcb54ac808c19a030c6f0ec64e760ac64ca5 > > This is likely a patch against 4.11 or earlier. Oh, that explains it. Wei. > > ~Andrew > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xenproject.org > https://lists.xenproject.org/mailman/listinfo/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-05-15 9:53 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-14 8:43 [PATCH v3] libxl: make vkbd tunable for HVM guests Eslam Elnikety 2019-05-14 8:43 ` [Xen-devel] " Eslam Elnikety 2019-05-14 9:23 ` Wei Liu 2019-05-14 9:23 ` [Xen-devel] " Wei Liu 2019-05-15 9:47 ` Wei Liu 2019-05-15 9:47 ` [Xen-devel] " Wei Liu 2019-05-15 9:49 ` Andrew Cooper 2019-05-15 9:49 ` [Xen-devel] " Andrew Cooper 2019-05-15 9:53 ` Wei Liu [this message] 2019-05-15 9:53 ` Wei Liu 2019-05-15 10:19 ` Elnikety, Eslam 2019-05-15 10:19 ` [Xen-devel] " Elnikety, Eslam
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190515095314.GD3977@zion.uk.xensource.com \ --to=wei.liu2@citrix.com \ --cc=andrew.cooper3@citrix.com \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).