From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Tim Deegan <tim@xen.org>, Ian Jackson <Ian.Jackson@eu.citrix.com>,
Julien Grall <julien.grall@arm.com>,
Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] page-alloc: accompany BUG() with printk()
Date: Wed, 15 May 2019 12:09:01 +0200 [thread overview]
Message-ID: <20190515100901.4psea2vmmugrkigl@Air-de-Roger> (raw)
In-Reply-To: <fb2114ce-79d0-fcb1-5b4e-c540aecb360b@citrix.com>
On Wed, May 15, 2019 at 10:59:20AM +0100, Andrew Cooper wrote:
> On 15/05/2019 10:44, Roger Pau Monné wrote:
> > On Wed, May 15, 2019 at 02:44:07AM -0600, Jan Beulich wrote:
> >> Log information likely relevant for understanding why the BUG()s were
> > Why not use panic instead of printk + BUG?
>
> Because the backtrace is useful a lot of the time.
Oh, panic has no backtrace, that's not very useful. Maybe we could add
a panic_trace version to avoid having to do a printk + BUG. In any
case:
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Thanks, Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Tim Deegan <tim@xen.org>, Ian Jackson <Ian.Jackson@eu.citrix.com>,
Julien Grall <julien.grall@arm.com>,
Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] [PATCH] page-alloc: accompany BUG() with printk()
Date: Wed, 15 May 2019 12:09:01 +0200 [thread overview]
Message-ID: <20190515100901.4psea2vmmugrkigl@Air-de-Roger> (raw)
Message-ID: <20190515100901.Z9K9GbD9bPNMY_xmLRHq2-E7gd7KYpq6wpxCcuI4vz4@z> (raw)
In-Reply-To: <fb2114ce-79d0-fcb1-5b4e-c540aecb360b@citrix.com>
On Wed, May 15, 2019 at 10:59:20AM +0100, Andrew Cooper wrote:
> On 15/05/2019 10:44, Roger Pau Monné wrote:
> > On Wed, May 15, 2019 at 02:44:07AM -0600, Jan Beulich wrote:
> >> Log information likely relevant for understanding why the BUG()s were
> > Why not use panic instead of printk + BUG?
>
> Because the backtrace is useful a lot of the time.
Oh, panic has no backtrace, that's not very useful. Maybe we could add
a panic_trace version to avoid having to do a printk + BUG. In any
case:
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Thanks, Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-05-15 10:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 8:44 [PATCH] page-alloc: accompany BUG() with printk() Jan Beulich
2019-05-15 8:44 ` [Xen-devel] " Jan Beulich
2019-05-15 9:30 ` Wei Liu
2019-05-15 9:30 ` [Xen-devel] " Wei Liu
2019-05-15 9:44 ` Roger Pau Monné
2019-05-15 9:44 ` [Xen-devel] " Roger Pau Monné
2019-05-15 9:59 ` Andrew Cooper
2019-05-15 9:59 ` [Xen-devel] " Andrew Cooper
2019-05-15 10:09 ` Roger Pau Monné [this message]
2019-05-15 10:09 ` Roger Pau Monné
2019-05-15 10:12 ` Andrew Cooper
2019-05-15 10:12 ` [Xen-devel] " Andrew Cooper
2019-05-15 10:03 ` Andrew Cooper
2019-05-15 10:03 ` [Xen-devel] " Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190515100901.4psea2vmmugrkigl@Air-de-Roger \
--to=roger.pau@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=julien.grall@arm.com \
--cc=konrad.wilk@oracle.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).