From: "Roger Pau Monné" <roger.pau@citrix.com>
To: osstest service owner <osstest-admin@xenproject.org>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
xen-devel@lists.xenproject.org, Wei Liu <wei.liu2@citrix.com>,
Jan Beulich <jbeulich@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [xen-unstable-smoke test] 136291: regressions - FAIL
Date: Wed, 15 May 2019 12:34:07 +0200 [thread overview]
Message-ID: <20190515103407.kezb3vnmyhceem7w@Air-de-Roger> (raw)
In-Reply-To: <osstest-136291-mainreport@xen.org>
On Wed, May 15, 2019 at 10:24:44AM +0000, osstest service owner wrote:
> flight 136291 xen-unstable-smoke real [real]
> http://logs.test-lab.xenproject.org/osstest/logs/136291/
>
> Regressions :-(
>
> Tests which did not succeed and are blocking,
> including tests which could not be run:
> build-amd64 6 xen-build fail REGR. vs. 136179
The error is:
p2m.c: In function 'altp2m_get_effective_entry':
p2m.c:502:26: error: 'page_order' may be used uninitialized in this function [-Werror=maybe-uninitialized]
if ( prepopulate && page_order != PAGE_ORDER_4K )
I think the above patch should solve it, AFAICT it's not a real
uninitialized usage.
---8<---
From fd12faf088ea679fdfb86b4758403692ee99e06b Mon Sep 17 00:00:00 2001
From: Roger Pau Monne <roger.pau@citrix.com>
Date: Wed, 15 May 2019 12:32:38 +0200
Subject: [PATCH] altp2m: placate uninitialized variable error
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
gcc reports:
p2m.c: In function 'altp2m_get_effective_entry':
p2m.c:502:26: error: 'page_order' may be used uninitialized in this function [-Werror=maybe-uninitialized]
if ( prepopulate && page_order != PAGE_ORDER_4K )
Placate the error by initializing page_order to 0.
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
xen/arch/x86/mm/p2m.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c
index 57c5eeda91..133106962b 100644
--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -2352,7 +2352,7 @@ int altp2m_get_effective_entry(struct p2m_domain *ap2m, gfn_t gfn, mfn_t *mfn,
if ( !mfn_valid(*mfn) && !p2m_is_hostp2m(ap2m) )
{
struct p2m_domain *hp2m = p2m_get_hostp2m(ap2m->domain);
- unsigned int page_order;
+ unsigned int page_order = 0;
int rc;
*mfn = __get_gfn_type_access(hp2m, gfn_x(gfn), t, a,
--
2.17.2 (Apple Git-113)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: osstest service owner <osstest-admin@xenproject.org>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
xen-devel@lists.xenproject.org, Wei Liu <wei.liu2@citrix.com>,
Jan Beulich <jbeulich@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [Xen-devel] [xen-unstable-smoke test] 136291: regressions - FAIL
Date: Wed, 15 May 2019 12:34:07 +0200 [thread overview]
Message-ID: <20190515103407.kezb3vnmyhceem7w@Air-de-Roger> (raw)
Message-ID: <20190515103407.4TrpirRN-M9bZPJR-lpziZx1etvzXwDlNiGYnejt6bs@z> (raw)
In-Reply-To: <osstest-136291-mainreport@xen.org>
On Wed, May 15, 2019 at 10:24:44AM +0000, osstest service owner wrote:
> flight 136291 xen-unstable-smoke real [real]
> http://logs.test-lab.xenproject.org/osstest/logs/136291/
>
> Regressions :-(
>
> Tests which did not succeed and are blocking,
> including tests which could not be run:
> build-amd64 6 xen-build fail REGR. vs. 136179
The error is:
p2m.c: In function 'altp2m_get_effective_entry':
p2m.c:502:26: error: 'page_order' may be used uninitialized in this function [-Werror=maybe-uninitialized]
if ( prepopulate && page_order != PAGE_ORDER_4K )
I think the above patch should solve it, AFAICT it's not a real
uninitialized usage.
---8<---
From fd12faf088ea679fdfb86b4758403692ee99e06b Mon Sep 17 00:00:00 2001
From: Roger Pau Monne <roger.pau@citrix.com>
Date: Wed, 15 May 2019 12:32:38 +0200
Subject: [PATCH] altp2m: placate uninitialized variable error
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
gcc reports:
p2m.c: In function 'altp2m_get_effective_entry':
p2m.c:502:26: error: 'page_order' may be used uninitialized in this function [-Werror=maybe-uninitialized]
if ( prepopulate && page_order != PAGE_ORDER_4K )
Placate the error by initializing page_order to 0.
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
xen/arch/x86/mm/p2m.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c
index 57c5eeda91..133106962b 100644
--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -2352,7 +2352,7 @@ int altp2m_get_effective_entry(struct p2m_domain *ap2m, gfn_t gfn, mfn_t *mfn,
if ( !mfn_valid(*mfn) && !p2m_is_hostp2m(ap2m) )
{
struct p2m_domain *hp2m = p2m_get_hostp2m(ap2m->domain);
- unsigned int page_order;
+ unsigned int page_order = 0;
int rc;
*mfn = __get_gfn_type_access(hp2m, gfn_x(gfn), t, a,
--
2.17.2 (Apple Git-113)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-05-15 10:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 10:24 [xen-unstable-smoke test] 136291: regressions - FAIL osstest service owner
2019-05-15 10:24 ` [Xen-devel] " osstest service owner
2019-05-15 10:34 ` Roger Pau Monné [this message]
2019-05-15 10:34 ` Roger Pau Monné
2019-05-15 10:35 ` Wei Liu
2019-05-15 10:35 ` [Xen-devel] " Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190515103407.kezb3vnmyhceem7w@Air-de-Roger \
--to=roger.pau@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=osstest-admin@xenproject.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).