* [PATCH] AMD/IOMMU: adjust IOMMU list head initialization
@ 2019-04-10 9:37 Jan Beulich
2019-04-10 9:37 ` [Xen-devel] " Jan Beulich
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Jan Beulich @ 2019-04-10 9:37 UTC (permalink / raw)
To: xen-devel; +Cc: Brian Woods, Suravee Suthikulpanit
Do this statically, which will allow accessing the (empty) list even
without having come through acpi_ivrs_init().
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/drivers/passthrough/amd/iommu_init.c
+++ b/xen/drivers/passthrough/amd/iommu_init.c
@@ -36,7 +36,7 @@ static struct tasklet amd_iommu_irq_task
unsigned int __read_mostly ivrs_bdf_entries;
u8 __read_mostly ivhd_type;
static struct radix_tree_root ivrs_maps;
-struct list_head amd_iommu_head;
+LIST_HEAD_READ_MOSTLY(amd_iommu_head);
struct table_struct device_table;
bool_t iommuv2_enabled;
--- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
+++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
@@ -150,8 +150,6 @@ static void amd_iommu_setup_domain_devic
int __init acpi_ivrs_init(void)
{
- INIT_LIST_HEAD(&amd_iommu_head);
-
if ( !iommu_enable && !iommu_intremap )
return 0;
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Xen-devel] [PATCH] AMD/IOMMU: adjust IOMMU list head initialization
2019-04-10 9:37 [PATCH] AMD/IOMMU: adjust IOMMU list head initialization Jan Beulich
@ 2019-04-10 9:37 ` Jan Beulich
2019-04-10 10:12 ` Andrew Cooper
2019-05-02 14:50 ` Jan Beulich
2 siblings, 0 replies; 8+ messages in thread
From: Jan Beulich @ 2019-04-10 9:37 UTC (permalink / raw)
To: xen-devel; +Cc: Brian Woods, Suravee Suthikulpanit
Do this statically, which will allow accessing the (empty) list even
without having come through acpi_ivrs_init().
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/drivers/passthrough/amd/iommu_init.c
+++ b/xen/drivers/passthrough/amd/iommu_init.c
@@ -36,7 +36,7 @@ static struct tasklet amd_iommu_irq_task
unsigned int __read_mostly ivrs_bdf_entries;
u8 __read_mostly ivhd_type;
static struct radix_tree_root ivrs_maps;
-struct list_head amd_iommu_head;
+LIST_HEAD_READ_MOSTLY(amd_iommu_head);
struct table_struct device_table;
bool_t iommuv2_enabled;
--- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
+++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
@@ -150,8 +150,6 @@ static void amd_iommu_setup_domain_devic
int __init acpi_ivrs_init(void)
{
- INIT_LIST_HEAD(&amd_iommu_head);
-
if ( !iommu_enable && !iommu_intremap )
return 0;
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] AMD/IOMMU: adjust IOMMU list head initialization
2019-04-10 9:37 [PATCH] AMD/IOMMU: adjust IOMMU list head initialization Jan Beulich
2019-04-10 9:37 ` [Xen-devel] " Jan Beulich
@ 2019-04-10 10:12 ` Andrew Cooper
2019-04-10 10:12 ` [Xen-devel] " Andrew Cooper
2019-05-16 11:53 ` Ping: " Jan Beulich
2019-05-02 14:50 ` Jan Beulich
2 siblings, 2 replies; 8+ messages in thread
From: Andrew Cooper @ 2019-04-10 10:12 UTC (permalink / raw)
To: xen-devel
On 10/04/2019 10:37, Jan Beulich wrote:
> Do this statically, which will allow accessing the (empty) list even
> without having come through acpi_ivrs_init().
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Xen-devel] [PATCH] AMD/IOMMU: adjust IOMMU list head initialization
2019-04-10 10:12 ` Andrew Cooper
@ 2019-04-10 10:12 ` Andrew Cooper
2019-05-16 11:53 ` Ping: " Jan Beulich
1 sibling, 0 replies; 8+ messages in thread
From: Andrew Cooper @ 2019-04-10 10:12 UTC (permalink / raw)
To: xen-devel
On 10/04/2019 10:37, Jan Beulich wrote:
> Do this statically, which will allow accessing the (empty) list even
> without having come through acpi_ivrs_init().
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Ping: [PATCH] AMD/IOMMU: adjust IOMMU list head initialization
2019-04-10 9:37 [PATCH] AMD/IOMMU: adjust IOMMU list head initialization Jan Beulich
2019-04-10 9:37 ` [Xen-devel] " Jan Beulich
2019-04-10 10:12 ` Andrew Cooper
@ 2019-05-02 14:50 ` Jan Beulich
2019-05-02 14:50 ` [Xen-devel] " Jan Beulich
2 siblings, 1 reply; 8+ messages in thread
From: Jan Beulich @ 2019-05-02 14:50 UTC (permalink / raw)
To: Brian Woods, Suravee Suthikulpanit; +Cc: xen-devel
>>> On 10.04.19 at 11:37, <JBeulich@suse.com> wrote:
> Do this statically, which will allow accessing the (empty) list even
> without having come through acpi_ivrs_init().
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/xen/drivers/passthrough/amd/iommu_init.c
> +++ b/xen/drivers/passthrough/amd/iommu_init.c
> @@ -36,7 +36,7 @@ static struct tasklet amd_iommu_irq_task
> unsigned int __read_mostly ivrs_bdf_entries;
> u8 __read_mostly ivhd_type;
> static struct radix_tree_root ivrs_maps;
> -struct list_head amd_iommu_head;
> +LIST_HEAD_READ_MOSTLY(amd_iommu_head);
> struct table_struct device_table;
> bool_t iommuv2_enabled;
>
> --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
> +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
> @@ -150,8 +150,6 @@ static void amd_iommu_setup_domain_devic
>
> int __init acpi_ivrs_init(void)
> {
> - INIT_LIST_HEAD(&amd_iommu_head);
> -
> if ( !iommu_enable && !iommu_intremap )
> return 0;
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xenproject.org
> https://lists.xenproject.org/mailman/listinfo/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Xen-devel] Ping: [PATCH] AMD/IOMMU: adjust IOMMU list head initialization
2019-05-02 14:50 ` Jan Beulich
@ 2019-05-02 14:50 ` Jan Beulich
0 siblings, 0 replies; 8+ messages in thread
From: Jan Beulich @ 2019-05-02 14:50 UTC (permalink / raw)
To: Brian Woods, Suravee Suthikulpanit; +Cc: xen-devel
>>> On 10.04.19 at 11:37, <JBeulich@suse.com> wrote:
> Do this statically, which will allow accessing the (empty) list even
> without having come through acpi_ivrs_init().
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/xen/drivers/passthrough/amd/iommu_init.c
> +++ b/xen/drivers/passthrough/amd/iommu_init.c
> @@ -36,7 +36,7 @@ static struct tasklet amd_iommu_irq_task
> unsigned int __read_mostly ivrs_bdf_entries;
> u8 __read_mostly ivhd_type;
> static struct radix_tree_root ivrs_maps;
> -struct list_head amd_iommu_head;
> +LIST_HEAD_READ_MOSTLY(amd_iommu_head);
> struct table_struct device_table;
> bool_t iommuv2_enabled;
>
> --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
> +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
> @@ -150,8 +150,6 @@ static void amd_iommu_setup_domain_devic
>
> int __init acpi_ivrs_init(void)
> {
> - INIT_LIST_HEAD(&amd_iommu_head);
> -
> if ( !iommu_enable && !iommu_intremap )
> return 0;
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xenproject.org
> https://lists.xenproject.org/mailman/listinfo/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Ping: [PATCH] AMD/IOMMU: adjust IOMMU list head initialization
2019-04-10 10:12 ` Andrew Cooper
2019-04-10 10:12 ` [Xen-devel] " Andrew Cooper
@ 2019-05-16 11:53 ` Jan Beulich
2019-05-16 11:53 ` [Xen-devel] " Jan Beulich
1 sibling, 1 reply; 8+ messages in thread
From: Jan Beulich @ 2019-05-16 11:53 UTC (permalink / raw)
To: Brian Woods, Suravee Suthikulpanit; +Cc: xen-devel
>>> On 10.04.19 at 12:12, <andrew.cooper3@citrix.com> wrote:
> On 10/04/2019 10:37, Jan Beulich wrote:
>> Do this statically, which will allow accessing the (empty) list even
>> without having come through acpi_ivrs_init().
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
So just like done a minute ago for "AMD/IOMMU: don't open-code
for_each_amd_iommu()" I intend to commit this trivial patch in a
day or two without maintainer ack, unless I hear back otherwise.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Xen-devel] Ping: [PATCH] AMD/IOMMU: adjust IOMMU list head initialization
2019-05-16 11:53 ` Ping: " Jan Beulich
@ 2019-05-16 11:53 ` Jan Beulich
0 siblings, 0 replies; 8+ messages in thread
From: Jan Beulich @ 2019-05-16 11:53 UTC (permalink / raw)
To: Brian Woods, Suravee Suthikulpanit; +Cc: xen-devel
>>> On 10.04.19 at 12:12, <andrew.cooper3@citrix.com> wrote:
> On 10/04/2019 10:37, Jan Beulich wrote:
>> Do this statically, which will allow accessing the (empty) list even
>> without having come through acpi_ivrs_init().
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
So just like done a minute ago for "AMD/IOMMU: don't open-code
for_each_amd_iommu()" I intend to commit this trivial patch in a
day or two without maintainer ack, unless I hear back otherwise.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-05-16 11:53 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-10 9:37 [PATCH] AMD/IOMMU: adjust IOMMU list head initialization Jan Beulich
2019-04-10 9:37 ` [Xen-devel] " Jan Beulich
2019-04-10 10:12 ` Andrew Cooper
2019-04-10 10:12 ` [Xen-devel] " Andrew Cooper
2019-05-16 11:53 ` Ping: " Jan Beulich
2019-05-16 11:53 ` [Xen-devel] " Jan Beulich
2019-05-02 14:50 ` Jan Beulich
2019-05-02 14:50 ` [Xen-devel] " Jan Beulich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).