From: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
To: Julien Grall <julien.grall@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [Xen-devel] [PATCH v2 2/2] arm: rename tiny64.conf to tiny64_defconfig
Date: Mon, 20 May 2019 13:41:03 +0000 [thread overview]
Message-ID: <87a7fh8cr4.fsf@epam.com> (raw)
Message-ID: <20190520134103.dY-RRDPokC2lipQKhrrd_TJJHhRQvuNH_-OLCXj5p4E@z> (raw)
In-Reply-To: <1ca603c5-2e97-9529-963a-f381b04c727f@arm.com>
Hi Julien,
Julien Grall writes:
> Hi,
>
> First of all, please add a cover letter when you send a series. This
> help for threading and also a place to commend on general feedback.
Oh, okay. That was quite simple change and I didn't wanted to spam with
extra emails. I will include cover letter next time.
> Furthermore, please use scripts/{add, get}_maintainers.pl to find the
> correct maintainers. While I agree that CCing REST is a good idea, you
> haven't CCed all of them.
Problem is that I used this script:
$ ./scripts/get_maintainer.pl -f defconfig_v2/v2-0002-arm-rename-tiny64.conf-to-tiny64_defconfig.patch
Andrew Cooper <andrew.cooper3@citrix.com>
George Dunlap <George.Dunlap@eu.citrix.com>
Ian Jackson <ian.jackson@eu.citrix.com>
Jan Beulich <jbeulich@suse.com>
Julien Grall <julien.grall@arm.com>
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Stefano Stabellini <sstabellini@kernel.org>
Tim Deegan <tim@xen.org>
Wei Liu <wei.liu2@citrix.com>
xen-devel@lists.xenproject.org
I was quite surprised by result myself. Honestly, I wanted to CC only
you and Stefano, but decided to play by the rules.
Also, add_maintainers.pl just ignores this patch at all:
% scripts/add_maintainers.pl -v 2 -d defconfig_v2
Processing: v2-0001-makefile-add-support-for-_defconfig-targets.patch
Processing: v2-0002-arm-rename-tiny64.conf-to-tiny64_defconfig.patch
./scripts/get_maintainer.pl: file 'defconfig_v2/v2-0002-arm-rename-tiny64.conf-to-tiny64_defconfig.patch' doesn't appear to be a patch. Add -f to options?
>
> On 16/05/2019 14:37, Volodymyr Babchuk wrote:
>> As build system now supports *_defconfig rules it is good to be able
>> to configure minimal XEN image with
>
> I am afraid this is not correct. tiny64 will not be able to generate a
> minimal config to boot on any platform supported by Xen.
>
> It is meant to be used as a base for tailoring your platform where all
> the options are turned off by default.
>
> So I think offering a direct access is likely going to be misused in
> most of the cases without proper documentation.
In the original commit message Stefano suggested to use olddefconfig:
" Add a tiny kconfig configuration. Enabled only the credit scheduler.
It only carries non-default options (use make menuconfig or make
olddefconfig to produce a complete .config file). "
I don't see any significant difference between
# cp tiny64.conf .config && make olddefconfig
and
# make tiny64_defconfig
Anyways, it is up to you to accept or decline this particular patch. I
mostly interested in the first patch in the series, because our build
system depends on it. This very patch I sent out only because I wanted
to tidy up things a bit. But if you are saying that it is intended to
store minimal config in this way, I'm okay with it.
--
Best regards,Volodymyr Babchuk
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-05-20 13:41 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 13:37 [PATCH v2 1/2] makefile: add support for *_defconfig targets Volodymyr Babchuk
2019-05-16 13:37 ` [Xen-devel] " Volodymyr Babchuk
2019-05-16 13:37 ` [PATCH v2 2/2] arm: rename tiny64.conf to tiny64_defconfig Volodymyr Babchuk
2019-05-16 13:37 ` [Xen-devel] " Volodymyr Babchuk
2019-05-20 13:01 ` Julien Grall
2019-05-20 13:01 ` [Xen-devel] " Julien Grall
2019-05-20 13:41 ` Volodymyr Babchuk [this message]
2019-05-20 13:41 ` Volodymyr Babchuk
2019-05-20 14:31 ` Julien Grall
2019-05-20 14:31 ` [Xen-devel] " Julien Grall
2019-05-20 14:57 ` Volodymyr Babchuk
2019-05-20 14:57 ` [Xen-devel] " Volodymyr Babchuk
2019-05-28 16:21 ` Julien Grall
2019-05-28 16:21 ` [Xen-devel] " Julien Grall
2019-05-29 11:40 ` Volodymyr Babchuk
2019-05-29 11:40 ` [Xen-devel] " Volodymyr Babchuk
2019-05-29 15:27 ` Julien Grall
2019-05-29 15:27 ` [Xen-devel] " Julien Grall
2019-06-05 15:58 ` Jan Beulich
2019-06-05 16:01 ` Julien Grall
2019-06-10 20:03 ` Julien Grall
2019-06-11 6:43 ` Jan Beulich
2019-06-11 9:27 ` Julien Grall
2019-06-11 9:41 ` Jan Beulich
2019-06-11 10:12 ` George Dunlap
2019-06-11 13:52 ` Julien Grall
2019-06-11 13:52 ` Julien Grall
2019-06-11 18:52 ` Volodymyr Babchuk
2019-06-12 7:44 ` Jan Beulich
2019-06-15 18:27 ` Julien Grall
2019-05-16 15:10 ` [PATCH v2 1/2] makefile: add support for *_defconfig targets Jan Beulich
2019-05-16 15:10 ` [Xen-devel] " Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7fh8cr4.fsf@epam.com \
--to=volodymyr_babchuk@epam.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=julien.grall@arm.com \
--cc=konrad.wilk@oracle.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).